Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 4 | class PendingRejectedEmail extends VolunteerEmail |
||
| 5 | { |
||
| 6 | public function __construct($userProfile) |
||
| 11 | |||
| 12 | public function getSubject() |
||
| 16 | |||
| 17 | public function setShift($shift) |
||
| 21 | |||
| 22 | View Code Duplication | public function getHTMLBody() |
|
| 29 | |||
| 30 | View Code Duplication | public function getTextBody() |
|
| 37 | } |
||
| 38 | /* vim: set tabstop=4 shiftwidth=4 expandtab: */ |
||
| 39 |
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: