ThemePage::add_links() - Code Metrics - Inspection of "Merge branch 'master' of gitlab.com:BurningFlipsid..." - BurningFlipside/SecureFramework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f480bf...21d5d4 )

by Patrick

created 2017-02-08 20:13 UTC

ThemePage::add_links() B

↳ Parent: ThemePage

Complexity

Conditions	3
Paths	3

Size

Total Lines	31
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	20
nc	3
nop	0
dl	0
loc	31
rs	8.8571
c	0
b	0
f	0

<?php

require_once('class.SecurePage.php');
class ThemePage extends SecurePage
namespace YourVendor;

class YourClass { }
{
    public $theme_root;

    function __construct($title)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        parent::__construct($title, true);

        $root = $_SERVER['DOCUMENT_ROOT'];
        $script_dir = dirname(__FILE__);
        $this->theme_root = substr($script_dir, strlen($root));
        $this->add_links();
    }

    function add_links()

    {
        $dir = $this->theme_root;
        if(!FlipSession::isLoggedIn())
        {
            $this->add_link('Login', 'http://profiles.burningflipside.com/login.php?return='.$this->current_url());

        }
        else
        {
            if($this->user->isInGroupNamed('ThemeAdmins'))
            { 
                $this->add_link('Admin', $dir.'/_admin/');

            }
            $secure_menu = array(
                'Tickets'=>'/tickets/index.php',
                'View Registrations'=>'/register/view.php',
                //'Theme Camp Registration'=>$dir.'/tc_reg.php',

                'Art Project Registration'=>'/register/art_reg.php',
                'Art Car Registration'=>'/register/artCar_reg.php',
                'Event Registration'=>'/register/event_reg.php'
            );
            $this->add_link('Secure', 'https://secure.burningflipside.com/', $secure_menu);

            $this->add_link('Logout', 'http://profiles.burningflipside.com/logout.php');

        }
        $about_menu = array(
            'Burning Flipside'=>'http://www.burningflipside.com/about/event',
            'AAR, LLC'=>'http://www.burningflipside.com/LLC',
            'Privacy Policy'=>'http://www.burningflipside.com/about/privacy'
        );
        $this->add_link('About', 'http://www.burningflipside.com/about', $about_menu);

    }
}
?>



1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2017-02-08 20:17 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 3 and the first side effect is on line 2. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			require_once('class.SecurePage.php');
3			class ThemePage extends SecurePage
			0 ignored issues – show Coding Style Compatibility introduced 2017-02-08 20:17 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			public $theme_root;
6
7			function __construct($title)
			0 ignored issues – show Best Practice introduced 2017-02-08 20:17 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Coding Style introduced 2017-02-08 20:17 UTC by Report Bug Copy Issue Report `__construct` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
8			{
9			parent::__construct($title, true);
			0 ignored issues – show Unused Code introduced 2017-02-08 20:17 UTC by Report Bug Copy Issue Report The call to `SecurePage::__construct()` has too many arguments starting with `true`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
10			$root = $_SERVER['DOCUMENT_ROOT'];
11			$script_dir = dirname(__FILE__);
12			$this->theme_root = substr($script_dir, strlen($root));
13			$this->add_links();
14			}
15
16			function add_links()
			0 ignored issues – show Best Practice introduced 2017-02-08 20:17 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
17			{
18			$dir = $this->theme_root;
19			if(!FlipSession::isLoggedIn())
20			{
21			$this->add_link('Login', 'http://profiles.burningflipside.com/login.php?return='.$this->current_url());
			0 ignored issues – show Bug introduced 2017-02-08 20:17 UTC by Report Bug Copy Issue Report The method `current_url()` does not seem to exist on `object<ThemePage>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Bug introduced 2017-02-08 20:17 UTC by Report Bug Copy Issue Report The method `add_link()` does not exist on `ThemePage`. Did you maybe mean `add_links()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
22			}
23			else
24			{
25			if($this->user->isInGroupNamed('ThemeAdmins'))
26			{
27			$this->add_link('Admin', $dir.'/_admin/');
			0 ignored issues – show Bug introduced 2017-02-08 20:17 UTC by Report Bug Copy Issue Report The method `add_link()` does not exist on `ThemePage`. Did you maybe mean `add_links()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
28			}
29			$secure_menu = array(
30			'Tickets'=>'/tickets/index.php',
31			'View Registrations'=>'/register/view.php',
32			//'Theme Camp Registration'=>$dir.'/tc_reg.php',
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-08 20:17 UTC by Report Bug Copy Issue Report `84%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
33			'Art Project Registration'=>'/register/art_reg.php',
34			'Art Car Registration'=>'/register/artCar_reg.php',
35			'Event Registration'=>'/register/event_reg.php'
36			);
37			$this->add_link('Secure', 'https://secure.burningflipside.com/', $secure_menu);
			0 ignored issues – show Bug introduced 2017-02-08 20:17 UTC by Report Bug Copy Issue Report The method `add_link()` does not exist on `ThemePage`. Did you maybe mean `add_links()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
38			$this->add_link('Logout', 'http://profiles.burningflipside.com/logout.php');
			0 ignored issues – show Bug introduced 2017-02-08 20:17 UTC by Report Bug Copy Issue Report The method `add_link()` does not exist on `ThemePage`. Did you maybe mean `add_links()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
39			}
40			$about_menu = array(
41			'Burning Flipside'=>'http://www.burningflipside.com/about/event',
42			'AAR, LLC'=>'http://www.burningflipside.com/LLC',
43			'Privacy Policy'=>'http://www.burningflipside.com/about/privacy'
44			);
45			$this->add_link('About', 'http://www.burningflipside.com/about', $about_menu);
			0 ignored issues – show Bug introduced 2017-02-08 20:17 UTC by Report Bug Copy Issue Report The method `add_link()` does not exist on `ThemePage`. Did you maybe mean `add_links()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
46			}
47			}
48			?>
			0 ignored issues – show Best Practice introduced 2017-02-08 20:17 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
49

BurningFlipside / SecureFramework

Push — master ( f480bf...21d5d4 )

ThemePage::add_links() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like