ThemeDB

Complexity

Total Complexity

30

Size/Duplication

Total Lines	158
Duplicated Lines	17.72 %

Coupling/Cohesion

Components	2
Dependencies	2

Importance

Changes

0

14 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getCurrentYear()	0	13	3
B	getAllFromCollection()	0	23	6
B	searchFromCollection()	0	22	5
A	getObjectFromCollectionByID()	10	10	2
A	addObjectToCollection()	11	11	2
A	updateObjectInCollection()	0	12	2
A	deleteObjectFromCollection()	7	7	1
A	getAllThemes()	0	4	1
A	getAllThemesForUser()	0	4	1
A	getThemeByID()	0	4	1
A	deleteTheme()	0	4	1
A	addTheme()	0	10	2
A	updateTheme()	0	11	2

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 3 and the first side effect is on line 2.

require_once("/var/www/secure_settings/class.FlipsideSettings.php");
class ThemeDB

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private $dataSet;
    private $tables = array();
    
    function __construct()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->dataSet = \DataSetFactory::getDataSetByName('registration');
    }

    function getCurrentYear()

It is generally recommended to explicitly declare the visibility for methods.

    {
        if(!isset($this->tables['vars']))
        {
            $this->tables['vars'] = $this->dataSet['vars'];
        }
        $data = $this->tables['vars']->read(new \Data\Filter('name eq year'));
        if(empty($data))
        {
            return false;
        }
        return $data[0]['value'];
    }

    function getAllFromCollection($collection, $year = false, $uid = false, $fields = false)

It is generally recommended to explicitly declare the visibility for methods.

    {
        if($year === false)
        {
            $year = $this->getCurrentYear();
        }
        $table = $this->dataSet[$collection];
        $filter = false;
        if($year !== '*' && $uid !== false)
        {
            $filter = new \Data\Filter("year eq $year and registrars eq $uid");
        }
        else if($year !== '*')
        {
            $filter = new \Data\Filter("year eq $year");
        }
        else if($uid !== false)
        {
            $filter = new \Data\Filter("registrars eq $uid");
        }
        $data = $table->read($filter, $fields);
        return $data;
    }

    function searchFromCollection($collection, $criteria, $fields = false)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $col = $this->db->selectCollection($collection);

The property db does not exist. Did you maybe forget to declare it?

        foreach($criteria as $key=>$value)
        {
            if($value[0] === '/')
            {
                $criteria[$key] = array('$regex'=>new MongoRegex("$value"));
            }
        }
        $cursor = $col->find($criteria);
        if($fields !== false)
        {
            $cursor->fields($fields);
        }
        $ret    = array();
        foreach($cursor as $doc)
        {
            array_push($ret, $doc);
        }
        return $ret;
    }

    function getObjectFromCollectionByID($collection, $id)

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        $table = $this->dataSet[$collection];
        $data = $table->read(new \Data\Filter("_id eq $id"));
        if(empty($data))
        {
            return false;
        }
        return $data[0];
    }

    function addObjectToCollection($collection, $obj)

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
         unset($obj['_id']);
         $table = $this->dataSet[$collection];
         $res = $table->create($obj);
         if($res !== false)
         {
             return $res;
         }
         return false;
    }

    function updateObjectInCollection($collection, $obj)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $id = $obj['_id'];
        unset($obj['_id']);
        $table = $this->dataSet[$collection];
        $res = $table->update(new \Data\Filter("_id eq $id"), $obj);
        if($res !== false)
        {
            return true;
        }
        return false;
    }

    function deleteObjectFromCollection($collection, $obj)

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        $id = $obj['_id'];
        unset($obj['_id']);
        $table = $this->dataSet[$collection];
        return $table->delete(new \Data\Filter("_id eq $id"));
    }

    function getAllThemes($year = false)

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->getAllFromCollection('themes', $year);
    }

    function getAllThemesForUser($uid, $year = false)

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->getAllFromCollection('themes', $year, $uid);
    }

    function getThemeByID($id)

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->getObjectFromCollectionByID('themes', $id);
    }

    function deleteTheme($theme)

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->db->themes->remove(array('_id'=>new MongoId($theme['_id'])));
    }

    function addTheme($theme)

It is generally recommended to explicitly declare the visibility for methods.

    {
         unset($theme['_id']);
         $res = $this->db->themes->insert($theme);
         if($res['ok'] === true)
         {
             return $theme['_id'];
         }
         return false;
    }

    function updateTheme($theme)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $id = new MongoId($theme['_id']);
        unset($theme['_id']);
        $res = $this->db->themes->update(array('_id' => $id), $theme);
        if($res['ok'] === true)
        {
            return true;
        }
        return false;
    } 
}
// vim: set tabstop=4 shiftwidth=4 expandtab:
?>

It is not recommended to use PHP's closing tag ?> in files other than templates.