Issues in class.GroupsAPI.php (master) - Issues in master - BurningFlipside/Profiles - Measure and Improve Code Quality continuously with Scrutinizer

Issues (31)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

api/v1/class.GroupsAPI.php (1 issue)

Labels

Duplication 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
class GroupsAPI extends ProfilesAdminAPI
{
    public function setup($app)
    {
        $app->get('[/]', array($this, 'getGroups'));
        $app->get('/{name}[/]', array($this, 'getGroup'));
        $app->patch('/{name}[/]', array($this, 'updateGroup'));
        $app->get('/{name}/non-members', array($this, 'getNonMembers'));
    }

    public function getGroups($request, $response)
    {
        if($this->validateIsAdmin($request, true) === false)
        {
            return $response->withStatus(301)->withHeader('Location', '../users/me/groups');
        }
        $auth = \Flipside\AuthProvider::getInstance();
        $odata = $request->getAttribute('odata', new \Flipside\ODataParams(array()));
        $groups = $auth->getGroupsByFilter($odata->filter, $odata->select, $odata->top, $odata->skip, 
                                           $odata->orderby);
        return $response->withJson($groups);
    }

    private function expandGroupMembers($group, $odata, $directOnly)
    {
        if($odata->expand !== false && in_array('member', $odata->expand))
        {
            $ret = array();
            $ret['cn'] = $group->getGroupName();
            $ret['description'] = $group->getDescription();
            $ret['member'] = $group->members(true, ($directOnly !== true));
            return json_decode(json_encode($ret), true);
        }
        else if($directOnly)
        {
            $ret = array();
            $ret['cn'] = $group->getGroupName();
            $ret['description'] = $group->getDescription();
            $ret['member'] = $group->getMemberUids(false);
            return json_decode(json_encode($ret), true);
        }
        return json_decode(json_encode($group), true);
    }

    private function getGroupForUserByName($name)
    {
        $groups = $this->user->getGroups();
        $count = count($groups);
        for($i = 0; $i < $count; $i++)

        {
            if(strcasecmp($groups[$i]->getGroupName(), $name) === 0)
            {
                return $groups[$i];
            }
        }
        return false;
    }

    public function getGroup($request, $response, $args)
    {
        $odata = $request->getAttribute('odata', new \Flipside\ODataParams(array()));
        $expand = false;
        $user = $request->getAttribute('user');
        if($user === false)
        {
            $local = $request->getServerParam('SERVER_ADDR');
            $remote = $request->getServerParam('REMOTE_ADDR');
            if($local === $remote)
            {
                $auth = \Flipside\AuthProvider::getInstance();
                $group = $auth->getGroupByName($args['name']);
                $expand = true;
            }
            else
            {
                return $response->withStatus(401);
            }
        }
        else if($this->validateIsAdmin($request, true) === false)
        {
            $group = $this->getGroupForUserByName($args['name']);
        }
        else
        {
            $auth = \Flipside\AuthProvider::getInstance();
            $group = $auth->getGroupByName($args['name']);
            $expand = true;
        }
        if(empty($group))
        {
            return $response->withStatus(404);
        }
        $params = $request->getQueryParams();
        $directOnly = false;
        if(isset($params['directOnly']) && $params['directOnly'] === 'true')
        {
            $directOnly = true;
        }
        if($expand)
        {
            $group = $this->expandGroupMembers($group, $odata, $directOnly);
        }
        return $response->withJson($group);
    }

    protected function serializeArray(&$res, $array, $keys, $type=false)
    {
        $count = count($array);
        for($i = 0; $i < $count; $i++)
        {
            $tmp = json_decode(json_encode($array[$i]), true);
            if($type === false)
            {
                $tmp['type'] = $this->getTypeOfEntity($array[$i]);
            }
            else
            {
                $tmp['type'] = $type;
            }
            if($keys !== false)
            {
                $tmp = array_intersect_key($tmp, $keys);
            }
            $res[] = $tmp;
        }
    }

    public function getAllGroupsAndUsers($keys)
    {
        $auth = \Flipside\AuthProvider::getInstance();
        $groups = $auth->getGroupsByFilter(false);
        $res = array();
        $this->serializeArray($res, $groups, $keys, 'Group');
        $users  = $auth->getUsersByFilter(false);
        $this->serializeArray($res, $users, $keys, 'User');
        return $res;
    }

    public function getTypeOfEntity($entity)
    {
        if(is_subclass_of($entity, 'Auth\Group'))
        {
            return 'Group';
        }
        else
        {
            return 'User';
        }
    }

    public function getNonMemberEntities($nonMembers, $keys)
    {
        if($keys !== false)
        {
            $res = array();
            $this->serializeArray($res, $nonMembers, $keys);
            return $res;
        }
        return $nonMembers;
    }

    public function getNonMembers($request, $response, $args)
    {
        $this->validateIsAdmin($request);
        $odata = $request->getAttribute('odata', new \Flipside\ODataParams(array()));
        $keys = false;
        if($odata->select !== false)
        {
            $keys = array_flip($odata->select);
        }
        $auth = \Flipside\AuthProvider::getInstance();
        if($args['name'] === 'none')
        {
            $res = $this->getAllGroupsAndUsers($keys);
            return $response->withJson($res);
        }
        $group = $auth->getGroupByName($args['name']);
        if($group === false)
        {
            return $response->withStatus(404);
        }
        $res = $group->getNonMembers($odata->select);
        $res = $this->getNonMemberEntities($res, $keys);
        return $response->withJson($res);
    }

    public function updateGroup($request, $response, $args)
    {
        $this->validateIsAdmin($request);
        $auth = \Flipside\AuthProvider::getInstance();
        $group = $auth->getGroupByName($args['name']);
        if($group === false)
        {
            return $response->withStatus(404);
        }
        $obj = $request->getParsedBody();
        $ret = $group->editGroup($obj);
        return $response->withJson($ret);
    }
}
/* vim: set tabstop=4 shiftwidth=4 expandtab: */


1		<?php
2		class GroupsAPI extends ProfilesAdminAPI
3		{
4		public function setup($app)
5		{
6		$app->get('[/]', array($this, 'getGroups'));
7		$app->get('/{name}[/]', array($this, 'getGroup'));
8		$app->patch('/{name}[/]', array($this, 'updateGroup'));
9		$app->get('/{name}/non-members', array($this, 'getNonMembers'));
10		}
11
12		public function getGroups($request, $response)
13		{
14		if($this->validateIsAdmin($request, true) === false)
15		{
16		return $response->withStatus(301)->withHeader('Location', '../users/me/groups');
17		}
18		$auth = \Flipside\AuthProvider::getInstance();
19		$odata = $request->getAttribute('odata', new \Flipside\ODataParams(array()));
20		$groups = $auth->getGroupsByFilter($odata->filter, $odata->select, $odata->top, $odata->skip,
21		$odata->orderby);
22		return $response->withJson($groups);
23		}
24
25		private function expandGroupMembers($group, $odata, $directOnly)
26		{
27		if($odata->expand !== false && in_array('member', $odata->expand))
28		{
29		$ret = array();
30		$ret['cn'] = $group->getGroupName();
31		$ret['description'] = $group->getDescription();
32		$ret['member'] = $group->members(true, ($directOnly !== true));
33		return json_decode(json_encode($ret), true);
34		}
35		else if($directOnly)
36		{
37		$ret = array();
38		$ret['cn'] = $group->getGroupName();
39		$ret['description'] = $group->getDescription();
40		$ret['member'] = $group->getMemberUids(false);
41		return json_decode(json_encode($ret), true);
42		}
43		return json_decode(json_encode($group), true);
44		}
45
46		private function getGroupForUserByName($name)
47		{
48		$groups = $this->user->getGroups();
49		$count = count($groups);
50	View Code Duplication	for($i = 0; $i < $count; $i++)
		0 ignored issues – show Duplication introduced 2017-06-20 14:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		{
52		if(strcasecmp($groups[$i]->getGroupName(), $name) === 0)
53		{
54		return $groups[$i];
55		}
56		}
57		return false;
58		}
59
60		public function getGroup($request, $response, $args)
61		{
62		$odata = $request->getAttribute('odata', new \Flipside\ODataParams(array()));
63		$expand = false;
64		$user = $request->getAttribute('user');
65		if($user === false)
66		{
67		$local = $request->getServerParam('SERVER_ADDR');
68		$remote = $request->getServerParam('REMOTE_ADDR');
69		if($local === $remote)
70		{
71		$auth = \Flipside\AuthProvider::getInstance();
72		$group = $auth->getGroupByName($args['name']);
73		$expand = true;
74		}
75		else
76		{
77		return $response->withStatus(401);
78		}
79		}
80		else if($this->validateIsAdmin($request, true) === false)
81		{
82		$group = $this->getGroupForUserByName($args['name']);
83		}
84		else
85		{
86		$auth = \Flipside\AuthProvider::getInstance();
87		$group = $auth->getGroupByName($args['name']);
88		$expand = true;
89		}
90		if(empty($group))
91		{
92		return $response->withStatus(404);
93		}
94		$params = $request->getQueryParams();
95		$directOnly = false;
96		if(isset($params['directOnly']) && $params['directOnly'] === 'true')
97		{
98		$directOnly = true;
99		}
100		if($expand)
101		{
102		$group = $this->expandGroupMembers($group, $odata, $directOnly);
103		}
104		return $response->withJson($group);
105		}
106
107		protected function serializeArray(&$res, $array, $keys, $type=false)
108		{
109		$count = count($array);
110		for($i = 0; $i < $count; $i++)
111		{
112		$tmp = json_decode(json_encode($array[$i]), true);
113		if($type === false)
114		{
115		$tmp['type'] = $this->getTypeOfEntity($array[$i]);
116		}
117		else
118		{
119		$tmp['type'] = $type;
120		}
121		if($keys !== false)
122		{
123		$tmp = array_intersect_key($tmp, $keys);
124		}
125		$res[] = $tmp;
126		}
127		}
128
129		public function getAllGroupsAndUsers($keys)
130		{
131		$auth = \Flipside\AuthProvider::getInstance();
132		$groups = $auth->getGroupsByFilter(false);
133		$res = array();
134		$this->serializeArray($res, $groups, $keys, 'Group');
135		$users = $auth->getUsersByFilter(false);
136		$this->serializeArray($res, $users, $keys, 'User');
137		return $res;
138		}
139
140		public function getTypeOfEntity($entity)
141		{
142		if(is_subclass_of($entity, 'Auth\Group'))
143		{
144		return 'Group';
145		}
146		else
147		{
148		return 'User';
149		}
150		}
151
152		public function getNonMemberEntities($nonMembers, $keys)
153		{
154		if($keys !== false)
155		{
156		$res = array();
157		$this->serializeArray($res, $nonMembers, $keys);
158		return $res;
159		}
160		return $nonMembers;
161		}
162
163		public function getNonMembers($request, $response, $args)
164		{
165		$this->validateIsAdmin($request);
166		$odata = $request->getAttribute('odata', new \Flipside\ODataParams(array()));
167		$keys = false;
168		if($odata->select !== false)
169		{
170		$keys = array_flip($odata->select);
171		}
172		$auth = \Flipside\AuthProvider::getInstance();
173		if($args['name'] === 'none')
174		{
175		$res = $this->getAllGroupsAndUsers($keys);
176		return $response->withJson($res);
177		}
178		$group = $auth->getGroupByName($args['name']);
179		if($group === false)
180		{
181		return $response->withStatus(404);
182		}
183		$res = $group->getNonMembers($odata->select);
184		$res = $this->getNonMemberEntities($res, $keys);
185		return $response->withJson($res);
186		}
187
188		public function updateGroup($request, $response, $args)
189		{
190		$this->validateIsAdmin($request);
191		$auth = \Flipside\AuthProvider::getInstance();
192		$group = $auth->getGroupByName($args['name']);
193		if($group === false)
194		{
195		return $response->withStatus(404);
196		}
197		$obj = $request->getParsedBody();
198		$ret = $group->editGroup($obj);
199		return $response->withJson($ret);
200		}
201		}
202		/* vim: set tabstop=4 shiftwidth=4 expandtab: */
203

BurningFlipside / Profiles

Issues (31)

Security Analysis not enabled

api/v1/class.GroupsAPI.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like