Issues in class.LeadsAPI.php - New Issues - Inspection of "Optimize lead directory api code" - BurningFlipside/Profiles - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b92daf...e10cff )

by Patrick

created 2018-12-19 16:46 UTC

api/v1/class.LeadsAPI.php (2 issues)

Labels

Bug 2

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
class LeadsAPI extends ProfilesAdminDataAPI
{
    public function __construct()
    {
        parent::__construct('profiles', 'position', 'short_name');
    }

    public function setup($app)
    {
        parent::setup($app);
    }

    protected function canCreate($request)
    {
        $this->validateIsAdmin($request);
        return true;
    }

    protected function canUpdate($request, $entity)
    {
        $this->validateIsAdmin($request);
        return true;
    }

    protected function hasPositionAccess()
    {
        if(!isset($this->positionAccess))
        {
            $this->positionAccess = ($this->user->isInGroupNamed('Leads') ||
class MyClass { }

$x = new MyClass();
$x->foo = true;
                $this->user->isInGroupNamed('CC') ||
                $this->user->isInGroupNamed('AFs'));
        }
        return $this->positionAccess;
    }

    protected function getPositionsByType($type, $auth)
    {
        switch($type)
        {
            case 'aar':
                $aarGroup = $auth->getGroupByName('AAR');
                return $aarGroup->members(true, false);
            case 'af':
                $afGroup = $auth->getGroupByName('AFs');
                return $afGroup->members(true, false);
            case 'cc':
                $ccGroup = $auth->getGroupByName('CC');
                return $ccGroup->members(true, false);
            case 'lead':
                $leadGroup = $auth->getGroupByName('Leads');
                return $leadGroup->members(true, false);
            default:
                $filter = new \Data\Filter('ou eq '.$type);
                return $auth->getUsersByFilter($filter);
        }
    }

    protected function getPositionsWithParams($params)
    {
        $auth = AuthProvider::getInstance();
        if(isset($params['type']))
        {
            return $this->getPositionsByType($params['type'], $auth);
        }
        $leads = array();
        $leadGroup = $auth->getGroupByName('Leads');
        $aarGroup  = $auth->getGroupByName('AAR');
        $afGroup   = $auth->getGroupByName('AFs');
        $ccGroup   = $auth->getGroupByName('CC');
        $leads     = array_merge($leads, $leadGroup->members(true, false));
        $leads     = array_merge($leads, $aarGroup->members(true, false));
        $leads     = array_merge($leads, $afGroup->members(true, false));
        $leads     = array_merge($leads, $ccGroup->members(true, false));
        return $leads;
    }

    public function readEntries($request, $response, $args)
    {
        if($this->canRead($request) === false || $this->hasPositionAccess() === false)
        {
            return $response->withStatus(401);
        }
        $odata = $request->getAttribute('odata', new \ODataParams(array()));
        $leads = $this->getPositionsWithParams($request->getQueryParams());
        $leads = $odata->filterArrayPerSelect($leads);
        return $response->withJson($leads);
    }
}
/* vim: set tabstop=4 shiftwidth=4 expandtab: */


1			<?php
2			class LeadsAPI extends ProfilesAdminDataAPI
3			{
4			public function __construct()
5			{
6			parent::__construct('profiles', 'position', 'short_name');
7			}
8
9			public function setup($app)
10			{
11			parent::setup($app);
12			}
13
14			protected function canCreate($request)
15			{
16			$this->validateIsAdmin($request);
17			return true;
18			}
19
20			protected function canUpdate($request, $entity)
21			{
22			$this->validateIsAdmin($request);
23			return true;
24			}
25
26			protected function hasPositionAccess()
27			{
28			if(!isset($this->positionAccess))
29			{
30			$this->positionAccess = ($this->user->isInGroupNamed('Leads') \|\|
			0 ignored issues – show Bug introduced 2018-12-19 16:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `positionAccess` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2018-12-19 16:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `user` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
31			$this->user->isInGroupNamed('CC') \|\|
32			$this->user->isInGroupNamed('AFs'));
33			}
34			return $this->positionAccess;
35			}
36
37			protected function getPositionsByType($type, $auth)
38			{
39			switch($type)
40			{
41			case 'aar':
42			$aarGroup = $auth->getGroupByName('AAR');
43			return $aarGroup->members(true, false);
44			case 'af':
45			$afGroup = $auth->getGroupByName('AFs');
46			return $afGroup->members(true, false);
47			case 'cc':
48			$ccGroup = $auth->getGroupByName('CC');
49			return $ccGroup->members(true, false);
50			case 'lead':
51			$leadGroup = $auth->getGroupByName('Leads');
52			return $leadGroup->members(true, false);
53			default:
54			$filter = new \Data\Filter('ou eq '.$type);
55			return $auth->getUsersByFilter($filter);
56			}
57			}
58
59			protected function getPositionsWithParams($params)
60			{
61			$auth = AuthProvider::getInstance();
62			if(isset($params['type']))
63			{
64			return $this->getPositionsByType($params['type'], $auth);
65			}
66			$leads = array();
67			$leadGroup = $auth->getGroupByName('Leads');
68			$aarGroup = $auth->getGroupByName('AAR');
69			$afGroup = $auth->getGroupByName('AFs');
70			$ccGroup = $auth->getGroupByName('CC');
71			$leads = array_merge($leads, $leadGroup->members(true, false));
72			$leads = array_merge($leads, $aarGroup->members(true, false));
73			$leads = array_merge($leads, $afGroup->members(true, false));
74			$leads = array_merge($leads, $ccGroup->members(true, false));
75			return $leads;
76			}
77
78			public function readEntries($request, $response, $args)
79			{
80			if($this->canRead($request) === false \|\| $this->hasPositionAccess() === false)
81			{
82			return $response->withStatus(401);
83			}
84			$odata = $request->getAttribute('odata', new \ODataParams(array()));
85			$leads = $this->getPositionsWithParams($request->getQueryParams());
86			$leads = $odata->filterArrayPerSelect($leads);
87			return $response->withJson($leads);
88			}
89			}
90			/* vim: set tabstop=4 shiftwidth=4 expandtab: */
91

BurningFlipside / Profiles

Push — master ( b92daf...e10cff )

api/v1/class.LeadsAPI.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like