AreasAPI::getLeads() - Code Metrics - Inspection of "Remove more duplicate validateIsAdmin code" - BurningFlipside/Profiles - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — fix/scruitinizer (5a2662)

by Patrick

created 2017-06-21 01:29 UTC

AreasAPI::getLeads() A

↳ Parent: AreasAPI

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	9
nc	2
nop	3
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0

<?php
class AreasAPI extends ProfilesAdminDataAPI
{
    public function __construct()
    {
        parent::__construct('profiles', 'area', 'short_name');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function setup($app)
    {
        parent::setup($app);
        $app->get('/{name}/leads', array($this, 'getLeads'));
    }

    protected function canCreate($request)
    {
        $this->validateIsAdmin($request);
        return true;
    }

    protected function canUpdate($request, $entity)
    {
        $this->validateIsAdmin($request);
        return true;
    }

    public function getLeads($request, $response, $args)
    {
        $this->validateLoggedIn($request);
        $dataTable = DataSetFactory::getDataTableByNames('profiles', 'position');
        $odata = $request->getAttribute('odata', new \ODataParams(array()));
        $leads = $dataTable->read(new \Data\Filter("area eq '".$args['name']."'"), $odata->select, $odata->top,
                                  $odata->skip, $odata->orderby);
        if(empty($leads))
        {
            return $response->withStatus(404);
        }
        return $response->withJson($leads);
    }
}
/* vim: set tabstop=4 shiftwidth=4 expandtab: */


1			<?php
2			class AreasAPI extends ProfilesAdminDataAPI
3			{
4			public function __construct()
5			{
6			parent::__construct('profiles', 'area', 'short_name');
			0 ignored issues – show Documentation introduced 2017-06-20 14:43 UTC by Report Bug Copy Issue Report `'short_name'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
7			}
8
9			public function setup($app)
10			{
11			parent::setup($app);
12			$app->get('/{name}/leads', array($this, 'getLeads'));
13			}
14
15			protected function canCreate($request)
16			{
17			$this->validateIsAdmin($request);
18			return true;
19			}
20
21			protected function canUpdate($request, $entity)
22			{
23			$this->validateIsAdmin($request);
24			return true;
25			}
26
27			public function getLeads($request, $response, $args)
28			{
29			$this->validateLoggedIn($request);
30			$dataTable = DataSetFactory::getDataTableByNames('profiles', 'position');
31			$odata = $request->getAttribute('odata', new \ODataParams(array()));
32			$leads = $dataTable->read(new \Data\Filter("area eq '".$args['name']."'"), $odata->select, $odata->top,
33			$odata->skip, $odata->orderby);
34			if(empty($leads))
35			{
36			return $response->withStatus(404);
37			}
38			return $response->withJson($leads);
39			}
40			}
41			/* vim: set tabstop=4 shiftwidth=4 expandtab: */
42

BurningFlipside / Profiles

Branch — fix/scruitinizer (5a2662)

AreasAPI::getLeads() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like