PendingUserAPI

Complexity

Total Complexity

16

Size/Duplication

Total Lines	85
Duplicated Lines	14.12 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setup()	0	7	1
A	validateIsAdmin()	12	12	3
A	listPendingUsers()	0	9	1
A	showPendingUser()	0	14	4
A	deletePendingUser()	0	7	1
B	activatePendingUser()	0	28	6

<?php
class PendingUserAPI extends Http\Rest\RestAPI
{
    public function setup($app)
    {
        $app->get('[/]', array($this, 'listPendingUsers'));
        $app->get('/{hash}[/]', array($this, 'showPendingUser'));
        $app->delete('/{hash}[/]', array($this, 'deletePendingUser'));
        $app->map(['GET', 'POST'], '/{hash}/Actions/activate[/]', array($this, 'activatePendingUser'));
    }

    protected function validateIsAdmin($request)

This method seems to be duplicated in your project.

    {
        $user = $request->getAttribute('user');
        if($user === false)
        {
            throw new Exception('Must be logged in', \Http\Rest\ACCESS_DENIED);
        }
        if(!$user->isInGroupNamed('LDAPAdmins'))
        {
            throw new Exception('Must be Admin', \Http\Rest\ACCESS_DENIED);
        }
    }

    public function listPendingUsers($request, $response, $args)

The parameter $args is not used and could be removed.

    {
        $this->validateIsAdmin($request);
        $odata = $request->getAttribute('odata', new \ODataParams(array()));
        $auth = AuthProvider::getInstance();
        $users = $auth->getPendingUsersByFilter($odata->filter, $odata->select, $odata->top, $odata->skip, 
                                                $odata->orderby);
        return $response->withJson($users);
    }

    public function showPendingUser($request, $response, $args)
    {
        $this->validateIsAdmin($request);
        $user = \AuthProvider::getInstance()->getPendingUsersByFilter(new \Data\Filter("hash eq '".$args['hash']."'"));
        if($user === false)
        {
            return $response->withStatus(404);
        }
        if(!is_object($user) && isset($user[0]))
        {
            $user = $user[0];
        }
        return $response->withJson($user);
    }

    public function deletePendingUser($request, $response, $args)
    {
        $this->validateIsAdmin($request);
        $auth = \AuthProvider::getInstance();
        $res = $auth->deletePendingUsersByFilter(new \Data\Filter("hash eq '".$args['hash']."'"));
        return $response->withJson($res);
    }

    public function activatePendingUser($request, $response, $args)

The parameter $args is not used and could be removed.

    {
        $user = $request->getAttribute('user');
        if($user === false)
        {
            throw new Exception('Must be logged in', \Http\Rest\ACCESS_DENIED);
        }
        $auth = \AuthProvider::getInstance();
        $user = $auth->getPendingUsersByFilter(new \Data\Filter("hash eq '$hash'"));

The variable $hash does not exist. Did you forget to declare it?

        if($user === false || !isset($user[0]))
        {
            return $app->withStatus(404);

The variable $app does not exist. Did you forget to declare it?

        }
        $res = $auth->activatePendingUser($user[0]);
        if($request->isGet())
        {
            $uri = '../../activate_error.php';
            if($res)
            {
                $uri = '../../';
            }
            return $response->withStatus(302)->withHeader('Location', $uri);
        }
        else
        {
            return $response->withJson($res);
        }
    }
}
/* vim: set tabstop=4 shiftwidth=4 expandtab: */