AreasAPI

Complexity

Total Complexity

9

Size/Duplication

Total Lines	52
Duplicated Lines	23.08 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	setup()	0	5	1
A	validateIsAdmin()	12	12	3
A	canCreate()	0	5	1
A	canUpdate()	0	5	1
A	getLeads()	0	13	2

<?php
class AreasAPI extends Http\Rest\DataTableAPI
{
    public function __construct()
    {
        parent::__construct('profiles', 'area', 'short_name');

'short_name' is of type string, but the function expects a boolean.

    }

    public function setup($app)
    {
        parent::setup($app);
        $app->get('/{name}/leads', array($this, 'getLeads'));
    }

    protected function validateIsAdmin($request)

This method seems to be duplicated in your project.

    {
        $user = $request->getAttribute('user');
        if($user === false)
        {
            throw new Exception('Must be logged in', \Http\Rest\ACCESS_DENIED);
        }
        if(!$user->isInGroupNamed('LDAPAdmins'))
        {
            throw new Exception('Must be Admin', \Http\Rest\ACCESS_DENIED);
        }
    }

    protected function canCreate($request)
    {
        $this->validateIsAdmin($request);
        return true;
    }

    protected function canUpdate($request, $entity)
    {
        $this->validateIsAdmin($request);
        return true;
    }

    public function getLeads($request, $response, $args)
    {
        $this->validateLoggedIn($request);
        $dataTable = DataSetFactory::getDataTableByNames('profiles', 'position');
        $odata = $request->getAttribute('odata', new \ODataParams(array()));
        $leads = $dataTable->read(new \Data\Filter("area eq '".$args['name']."'"), $odata->select, $odata->top,
                                  $odata->skip, $odata->orderby);
        if(empty($leads))
        {
            return $response->withStatus(404);
        }
        return $response->withJson($leads);
    }
}
/* vim: set tabstop=4 shiftwidth=4 expandtab: */