SerializationMiddleware::__invoke() - Code Metrics - Inspection of "Merge down to master" - BurningFlipside/CommonCode - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#58)

by Patrick

created 2017-06-17 05:03 UTC

SerializationMiddleware::__invoke() C

↳ Parent: SerializationMiddleware

Complexity

Conditions	22
Paths	22

Size

Total Lines	51
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	22
eloc	41
c	1
b	0
f	0
nc	22
nop	3
dl	0
loc	51
rs	5.5531

How to fix Long Method Complexity

<?php
namespace Http\Rest;

use \Psr\Http\Message\ServerRequestInterface as Request;
use \Psr\Http\Message\ResponseInterface as Response;

require 'vendor/autoload.php';

class SerializationMiddleware
{
    protected $format = null;

    private function getFormatFromHeader($request)
    {
        $mimeType = $request->getHeader('Accept');
        switch($mimeType)
        {
            case 'text/csv':
                return 'csv';
            case 'text/x-vCard':
                return 'vcard';
            default:
                return 'json';
        }
    }

    private function getParamFromArrayIfSet($array, $param, $default = null)
    {
        if(isset($array[$param]))
        {
            return $array[$param];
        }
        return $default;
    }

    private function getFormat($request, $response)
    {
        $params = $request->getQueryParams();
        $this->format = $this->getParamFromArrayIfSet($params, 'fmt');
        if($this->format === null)
        {
            $this->format = $this->getParamFromArrayIfSet($params, '$format');
            if($this->format === null)
            {
                $this->format = $this->getFormatFromHeader($request);
            }
        }
        if(strstr($this->format, 'odata.streaming=true'))
        {
            return $response->withStatus(406);
        }
        return $response;
    }

    protected function reserializeBody($response, $serializer)
    {
        $body = $response->getBody();
        $body->rewind();
        $data = json_decode($body->getContents());
        $serializer = new $serializer();
        $res = $serializer->serializeData($this->format, $data);
        $response = $response->withBody(new \Slim\Http\Body(fopen('php://temp', 'r+')));
        $response->getBody()->write($res);
        return $response->withHeader('Content-Type', $this->format);
    }

    public function __invoke($request, $response, $next)
    {
        $response = $this->getFormat($request, $response);
        if($response->getStatusCode() !== 200)
        {
            return $response;
        }
        $request = $request->withAttribute('format', $this->format);
        $response = $next($request, $response);
        if($response->getHeaderLine('Content-Type') !== 'application/json;charset=utf-8')
        {
            //The underlying API call gave us back a different content type. Just pass that on...
            return $response;
        }
        switch($this->format)
        {
            case 'application/json':
            case 'application/x-javascript':
            case 'text/javascript':
            case 'text/x-javascript':
            case 'text/x-json':
            case 'json':
                return $response;
            case 'data-table':
                //This is a special case for json...
                $body = $response->getBody();
                $body->rewind();
                $data = json_decode($body->getContents());
                return $response->withJson(array('data'=>$data));
            case 'xml':
            case 'application/xml':
            case 'text/xml':
                return $this->reserializeBody($response, '\Serialize\XMLSerializer');
            case 'csv':
            case 'text/csv':
                return $this->reserializeBody($response, '\Serialize\CSVSerializer');
            case 'xlsx':
            case 'xls':
            case 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet':
            case 'application/vnd.ms-excel':
                return $this->reserializeBody($response, '\Serialize\ExcelSerializer');
            case 'yaml':
            case 'application/x-yaml':
            case 'text/x-yaml':
                return $this->reserializeBody($response, '\Serialize\YAMLSerializer');
            default:
                print_r($this->format); die();
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        }
        return $response;
    }
}


1			<?php
2			namespace Http\Rest;
3
4			use \Psr\Http\Message\ServerRequestInterface as Request;
5			use \Psr\Http\Message\ResponseInterface as Response;
6
7			require 'vendor/autoload.php';
8
9			class SerializationMiddleware
10			{
11			protected $format = null;
12
13			private function getFormatFromHeader($request)
14			{
15			$mimeType = $request->getHeader('Accept');
16			switch($mimeType)
17			{
18			case 'text/csv':
19			return 'csv';
20			case 'text/x-vCard':
21			return 'vcard';
22			default:
23			return 'json';
24			}
25			}
26
27			private function getParamFromArrayIfSet($array, $param, $default = null)
28			{
29			if(isset($array[$param]))
30			{
31			return $array[$param];
32			}
33			return $default;
34			}
35
36			private function getFormat($request, $response)
37			{
38			$params = $request->getQueryParams();
39			$this->format = $this->getParamFromArrayIfSet($params, 'fmt');
40			if($this->format === null)
41			{
42			$this->format = $this->getParamFromArrayIfSet($params, '$format');
43			if($this->format === null)
44			{
45			$this->format = $this->getFormatFromHeader($request);
46			}
47			}
48			if(strstr($this->format, 'odata.streaming=true'))
49			{
50			return $response->withStatus(406);
51			}
52			return $response;
53			}
54
55			protected function reserializeBody($response, $serializer)
56			{
57			$body = $response->getBody();
58			$body->rewind();
59			$data = json_decode($body->getContents());
60			$serializer = new $serializer();
61			$res = $serializer->serializeData($this->format, $data);
62			$response = $response->withBody(new \Slim\Http\Body(fopen('php://temp', 'r+')));
63			$response->getBody()->write($res);
64			return $response->withHeader('Content-Type', $this->format);
65			}
66
67			public function __invoke($request, $response, $next)
68			{
69			$response = $this->getFormat($request, $response);
70			if($response->getStatusCode() !== 200)
71			{
72			return $response;
73			}
74			$request = $request->withAttribute('format', $this->format);
75			$response = $next($request, $response);
76			if($response->getHeaderLine('Content-Type') !== 'application/json;charset=utf-8')
77			{
78			//The underlying API call gave us back a different content type. Just pass that on...
79			return $response;
80			}
81			switch($this->format)
82			{
83			case 'application/json':
84			case 'application/x-javascript':
85			case 'text/javascript':
86			case 'text/x-javascript':
87			case 'text/x-json':
88			case 'json':
89			return $response;
90			case 'data-table':
91			//This is a special case for json...
92			$body = $response->getBody();
93			$body->rewind();
94			$data = json_decode($body->getContents());
95			return $response->withJson(array('data'=>$data));
96			case 'xml':
97			case 'application/xml':
98			case 'text/xml':
99			return $this->reserializeBody($response, '\Serialize\XMLSerializer');
100			case 'csv':
101			case 'text/csv':
102			return $this->reserializeBody($response, '\Serialize\CSVSerializer');
103			case 'xlsx':
104			case 'xls':
105			case 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet':
106			case 'application/vnd.ms-excel':
107			return $this->reserializeBody($response, '\Serialize\ExcelSerializer');
108			case 'yaml':
109			case 'application/x-yaml':
110			case 'text/x-yaml':
111			return $this->reserializeBody($response, '\Serialize\YAMLSerializer');
112			default:
113			print_r($this->format); die();
114			break;
			0 ignored issues – show Unused Code introduced 2017-06-07 21:43 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
115			}
116			return $response;
117			}
118			}
119

BurningFlipside / CommonCode

Pull Request — master (#58)

SerializationMiddleware::__invoke() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like