FlipsideAPIUser - Code Metrics - Inspection of "Initial Commit of Magic Functions for User Attribu..." - BurningFlipside/CommonCode - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — MagicUser (b8f336)

by Patrick

created 2016-06-09 21:33 UTC

FlipsideAPIUser B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	183
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	183
rs	8.2608
wmc	40
lcom	1
cbo	1

18 Methods

Rating	Name	Size	Complexity
A	__construct()	15	4
B	isInGroupNamed()	21	5
A	__get()	9	2
A	__set()	3	1
A	getEmail()	8	2
A	getUid()	8	2
A	getPhoneNumber()	8	2
A	getOrganization()	8	2
A	getTitles()	8	2
A	getState()	8	2
A	getCity()	8	2
A	getLastName()	8	2
A	getNickName()	8	2
A	getAddress()	8	2
A	getPostalCode()	8	2
A	getCountry()	8	2
A	getOrganizationUnits()	8	2
A	getLoginProviders()	8	2

How to fix Complexity

<?php
namespace Auth;
if(!class_exists('Httpful\Request'))
{
    require(realpath(dirname(__FILE__)).'/../libs/httpful/bootstrap.php');
}

class FlipsideAPIUser extends User
{
    private $userData;
    private $groupData = null;

    public function __construct($data = false)
    {
        if(($data !== false) && !isset($data['extended']))
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
        {
            //Generic user object
            //TODO get from API
        }
        else
        {
            if(isset($data['extended']))
            {
                $this->userData = $data['extended'];
            }
        }
    }

    public function isInGroupNamed($name)
    {
        if($this->groupData === null)
        {
            $resp = \Httpful\Request::get('https://profiles.test.burningflipside.com/api/v1/users/me/groups')->authenticateWith($this->userData->uid, $this->userData->userPassword)->send();
            if($resp->hasErrors())
            {
                return false;
            }
            $this->groupData = $resp->body;
        }
        $count = count($this->groupData);
        for($i = 0; $i < $count; $i++)
        {
            if($this->groupData[$i]->cn === $name)
            {
                return true;
            }
        }
        return false;
    }

    public function __get($propName)
    {
        if($this->userData === null)
        {
            return parent::__get($propName);
        }
        $propName = strtolower($propName);
        return $this->userData->{$propName};
    }

    public function __set($propName, $value)
    {
    }

    public function getEmail()
    {
        if($this->userData === null)
        {
            return parent::getEmail();
        }
        return $this->userData->mail;
    }

    public function getUid()
    {
        if($this->userData === null)
        {
            return parent::getUid();
        }
        return $this->userData->uid;
    }

    public function getPhoneNumber()
    {
        if($this->userData === null)
        {
            return parent::getPhoneNumber();
        }
        return $this->userData->mobile;
    }

    public function getOrganization()
    {
        if($this->userData === null)
        {
            return parent::getOrganization();
        }
        return $this->userData->o;
    }

    public function getTitles()
    {
        if($this->userData === null)
        {
            return parent::getTitles();
        }
        return $this->userData->title;
    }

    public function getState()
    {
        if($this->userData === null)
        {
            return parent::getState();
        }
        return $this->userData->st;
    }

    public function getCity()
    {
        if($this->userData === null)
        {
            return parent::getCity();
        }
        return $this->userData->l;
    }

    public function getLastName()
    {
        if($this->userData === null)
        {
            return parent::getLastName();
        }
        return $this->userData->sn;
    }

    public function getNickName()
    {
        if($this->userData === null)
        {
            return parent::getNickName();
        }
        return $this->userData->displayname;
    }

    public function getAddress()
    {
        if($this->userData === null)
        {
            return parent::getAddress();
        }
        return $this->userData->postaladdress;
    }

    public function getPostalCode()
    {
        if($this->userData === null)
        {
            return parent::getPostalCode();
        }
        return $this->userData->postalcode;
    }

    public function getCountry()
    {
        if($this->userData === null)
        {
            return parent::getCountry();
        }
        return $this->userData->c;
    }

    public function getOrganizationUnits()
    {
        if($this->userData === null)
        {
            return parent::getOrganizationUnits();
        }
        return $this->userData->ou;
    }

    public function getLoginProviders()
    {
        if($this->userData === null)
        {
            return parent::getLoginProviders();
        }
        return $this->userData->host;
    }
}



1			<?php
2			namespace Auth;
3			if(!class_exists('Httpful\Request'))
4			{
5			require(realpath(dirname(__FILE__)).'/../libs/httpful/bootstrap.php');
6			}
7
8			class FlipsideAPIUser extends User
9			{
10			private $userData;
11			private $groupData = null;
12
13			public function __construct($data = false)
14			{
15			if(($data !== false) && !isset($data['extended']))
			0 ignored issues – show Unused Code introduced 2016-05-13 18:20 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
16			{
17			//Generic user object
18			//TODO get from API
19			}
20			else
21			{
22			if(isset($data['extended']))
23			{
24			$this->userData = $data['extended'];
25			}
26			}
27			}
28
29			public function isInGroupNamed($name)
30			{
31			if($this->groupData === null)
32			{
33			$resp = \Httpful\Request::get('https://profiles.test.burningflipside.com/api/v1/users/me/groups')->authenticateWith($this->userData->uid, $this->userData->userPassword)->send();
34			if($resp->hasErrors())
35			{
36			return false;
37			}
38			$this->groupData = $resp->body;
39			}
40			$count = count($this->groupData);
41			for($i = 0; $i < $count; $i++)
42			{
43			if($this->groupData[$i]->cn === $name)
44			{
45			return true;
46			}
47			}
48			return false;
49			}
50
51			public function __get($propName)
52			{
53			if($this->userData === null)
54			{
55			return parent::__get($propName);
56			}
57			$propName = strtolower($propName);
58			return $this->userData->{$propName};
59			}
60
61			public function __set($propName, $value)
62			{
63			}
64
65			public function getEmail()
66			{
67			if($this->userData === null)
68			{
69			return parent::getEmail();
70			}
71			return $this->userData->mail;
72			}
73
74			public function getUid()
75			{
76			if($this->userData === null)
77			{
78			return parent::getUid();
79			}
80			return $this->userData->uid;
81			}
82
83			public function getPhoneNumber()
84			{
85			if($this->userData === null)
86			{
87			return parent::getPhoneNumber();
88			}
89			return $this->userData->mobile;
90			}
91
92			public function getOrganization()
93			{
94			if($this->userData === null)
95			{
96			return parent::getOrganization();
97			}
98			return $this->userData->o;
99			}
100
101			public function getTitles()
102			{
103			if($this->userData === null)
104			{
105			return parent::getTitles();
106			}
107			return $this->userData->title;
108			}
109
110			public function getState()
111			{
112			if($this->userData === null)
113			{
114			return parent::getState();
115			}
116			return $this->userData->st;
117			}
118
119			public function getCity()
120			{
121			if($this->userData === null)
122			{
123			return parent::getCity();
124			}
125			return $this->userData->l;
126			}
127
128			public function getLastName()
129			{
130			if($this->userData === null)
131			{
132			return parent::getLastName();
133			}
134			return $this->userData->sn;
135			}
136
137			public function getNickName()
138			{
139			if($this->userData === null)
140			{
141			return parent::getNickName();
142			}
143			return $this->userData->displayname;
144			}
145
146			public function getAddress()
147			{
148			if($this->userData === null)
149			{
150			return parent::getAddress();
151			}
152			return $this->userData->postaladdress;
153			}
154
155			public function getPostalCode()
156			{
157			if($this->userData === null)
158			{
159			return parent::getPostalCode();
160			}
161			return $this->userData->postalcode;
162			}
163
164			public function getCountry()
165			{
166			if($this->userData === null)
167			{
168			return parent::getCountry();
169			}
170			return $this->userData->c;
171			}
172
173			public function getOrganizationUnits()
174			{
175			if($this->userData === null)
176			{
177			return parent::getOrganizationUnits();
178			}
179			return $this->userData->ou;
180			}
181
182			public function getLoginProviders()
183			{
184			if($this->userData === null)
185			{
186			return parent::getLoginProviders();
187			}
188			return $this->userData->host;
189			}
190			}
191
192

BurningFlipside / CommonCode

Branch — MagicUser (b8f336)

FlipsideAPIUser B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

18 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like