MongoDataSet::update() - Code Metrics - Inspection of "Master" - BurningFlipside/CommonCode - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#120)

by Patrick

created 2019-06-21 17:10 UTC

MongoDataSet::update() A

↳ Parent: MongoDataSet

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	8
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	4
dl	8
loc	8
rs	10
c	0
b	0
f	0

<?php
namespace Data;

function MongofillAutoload($classname)
{
    $classname = str_replace('/', '\\', $classname);
    $classname = ltrim($classname, '\\');
    $namespace = '';
    if($lastNsPos = strrpos($classname, '\\'))
    {
        $namespace = substr($classname, 0, $lastNsPos);
        $classname = substr($classname, $lastNsPos + 1);
    }
    if(strlen($namespace))
    {
        $namespace .= DIRECTORY_SEPARATOR;
    }
    $filename = __DIR__.'/../libs/mongofill/src/'.$namespace.$classname.'.php';
    if(is_readable($filename))
    {
        require $filename;
    }
}

class MongoDataSet extends DataSet
{
    protected $client;
    protected $manager;
    protected $db;
    protected $db_name;

    function __construct($params)

    {
        $this->client = null;
        $this->mangaer = null;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->db = null;
        $this->db_name = null;
        if(class_exists('MongoClient'))
        {
            $this->setupMongoClient($params);
        }
        else if(class_exists('\MongoDB\Driver\Manager'))
        {
            $this->setupMongoManager($params);
        }
        else
        {
            require __DIR__.'/../libs/mongofill/src/functions.php';
            autoLoadHandler('\Data\MongofillAutoload');
            $this->setupMongoClient($params);
        }
    }

    function tableExists($name)

    {
        $collections = $this->db->getCollectionNames();
        if(in_array($name, $collections))
        {
            return true;
        }
        return false;
    }

    function getTable($name)

    {
        if($this->db !== null)
        {
            return new MongoDataTable($this->db->selectCollection($name));

        }
        else
        {
            return new MongoDataTable($this, $name);
        }
    }

    private function setupMongoClient($params)
    {
        if($params === false)
        {
            return;
        }
        if(isset($params['user']))
        {
            $this->client = new \MongoClient('mongodb://'.$params['host'].'/'.$params['db'], array('username'=>$params['user'], 'password'=>$params['pass']));
        }
        else
        {
            $this->client = new \MongoClient('mongodb://'.$params['host'].'/'.$params['db']);
        }
        $this->db = $this->client->selectDB($params['db']);
    }

    private function setupMongoManager($params)
    {
        if($params === false)
        {
            return;
        }
        if(isset($params['user']))
        {
            $this->manager = new \MongoDB\Driver\Manager('mongodb://'.$params['user'].':'.$params['pass'].'@'.$params['host'].'/'.$params['db']);
        }
        else
        {
            $this->manager = new \MongoDB\Driver\Manager('mongodb://'.$params['host'].'/'.$params['db']);
        }
        $this->db_name = $params['db'];
    }

    public function find($query = array(), $fields = array(), $collectionName)
    {
        $namespace = $this->db_name.'.'.$collectionName;
        $dbQuery = new \MongoDB\Driver\Query($query, $fields);
        return $this->manager->executeQuery($namespace, $dbQuery);
    }

    public function insert(&$document, $options = array(), $collectionName)
    {
        $namespace = $this->db_name.'.'.$collectionName;
        $dbWrite = new \MongoDB\Driver\BulkWrite();
        $id = $dbWrite->insert($document);
        $res = $this->manager->executeBulkWrite($namespace, $dbWrite, $options);
        if($res->getInsertedCount() === 1)
        {
            $document['_id'] = $id;
            return true;
        }
        return false;
    }

    public function remove($criteria = array(), array $options = array(), $collectionName)

    {
        $namespace = $this->db_name.'.'.$collectionName;
        $dbWrite = new \MongoDB\Driver\BulkWrite();
        $dbWrite->delete($criteria);
        $res = $this->manager->executeBulkWrite($namespace, $dbWrite, $options);
        return $res->getDeletedCount() >= 1;
    }

    public function update($criteria, $new_object, $options = array(), $collectionName)

    {
        $namespace = $this->db_name.'.'.$collectionName;
        $dbWrite = new \MongoDB\Driver\BulkWrite();
        $dbWrite->update($criteria, $new_object, $options);
        $res = $this->manager->executeBulkWrite($namespace, $dbWrite, $options);
        return $res->getModifiedCount() === 1;
    }

    public function count($query = array(), $options = array(), $collectionName)

    {
        $cmd = new \MongoDB\Driver\Command(['count'=>$collectionName, 'query'=>$query]);
        return $this->manager->executeCommand($this->db_name, $cmd);
    }
}
/* vim: set tabstop=4 shiftwidth=4 expandtab: */


1		<?php
2		namespace Data;
3
4		function MongofillAutoload($classname)
5		{
6		$classname = str_replace('/', '\\', $classname);
7		$classname = ltrim($classname, '\\');
8		$namespace = '';
9		if($lastNsPos = strrpos($classname, '\\'))
10		{
11		$namespace = substr($classname, 0, $lastNsPos);
12		$classname = substr($classname, $lastNsPos + 1);
13		}
14		if(strlen($namespace))
15		{
16		$namespace .= DIRECTORY_SEPARATOR;
17		}
18		$filename = __DIR__.'/../libs/mongofill/src/'.$namespace.$classname.'.php';
19		if(is_readable($filename))
20		{
21		require $filename;
22		}
23		}
24
25		class MongoDataSet extends DataSet
26		{
27		protected $client;
28		protected $manager;
29		protected $db;
30		protected $db_name;
31
32		function __construct($params)
		0 ignored issues – show Best Practice introduced 2016-05-13 18:20 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
33		{
34		$this->client = null;
35		$this->mangaer = null;
		0 ignored issues – show Bug introduced 2016-05-13 18:20 UTC by Report Bug Copy Issue Report The property `mangaer` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
36		$this->db = null;
37		$this->db_name = null;
38		if(class_exists('MongoClient'))
39		{
40		$this->setupMongoClient($params);
41		}
42		else if(class_exists('\MongoDB\Driver\Manager'))
43		{
44		$this->setupMongoManager($params);
45		}
46		else
47		{
48		require __DIR__.'/../libs/mongofill/src/functions.php';
49		autoLoadHandler('\Data\MongofillAutoload');
50		$this->setupMongoClient($params);
51		}
52		}
53
54		function tableExists($name)
		0 ignored issues – show Best Practice introduced 2016-05-13 18:20 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
55		{
56		$collections = $this->db->getCollectionNames();
57		if(in_array($name, $collections))
58		{
59		return true;
60		}
61		return false;
62		}
63
64		function getTable($name)
		0 ignored issues – show Best Practice introduced 2016-05-13 18:20 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
65		{
66		if($this->db !== null)
67		{
68		return new MongoDataTable($this->db->selectCollection($name));
		0 ignored issues – show Bug introduced 2016-05-13 18:20 UTC by Report Bug Copy Issue Report The method `selectCollection` cannot be called on `$this->db` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
69		}
70		else
71		{
72		return new MongoDataTable($this, $name);
73		}
74		}
75
76		private function setupMongoClient($params)
77		{
78		if($params === false)
79		{
80		return;
81		}
82		if(isset($params['user']))
83		{
84		$this->client = new \MongoClient('mongodb://'.$params['host'].'/'.$params['db'], array('username'=>$params['user'], 'password'=>$params['pass']));
85		}
86		else
87		{
88		$this->client = new \MongoClient('mongodb://'.$params['host'].'/'.$params['db']);
89		}
90		$this->db = $this->client->selectDB($params['db']);
91		}
92
93		private function setupMongoManager($params)
94		{
95		if($params === false)
96		{
97		return;
98		}
99		if(isset($params['user']))
100		{
101		$this->manager = new \MongoDB\Driver\Manager('mongodb://'.$params['user'].':'.$params['pass'].'@'.$params['host'].'/'.$params['db']);
102		}
103		else
104		{
105		$this->manager = new \MongoDB\Driver\Manager('mongodb://'.$params['host'].'/'.$params['db']);
106		}
107		$this->db_name = $params['db'];
108		}
109
110		public function find($query = array(), $fields = array(), $collectionName)
111		{
112		$namespace = $this->db_name.'.'.$collectionName;
113		$dbQuery = new \MongoDB\Driver\Query($query, $fields);
114		return $this->manager->executeQuery($namespace, $dbQuery);
115		}
116
117		public function insert(&$document, $options = array(), $collectionName)
118		{
119		$namespace = $this->db_name.'.'.$collectionName;
120		$dbWrite = new \MongoDB\Driver\BulkWrite();
121		$id = $dbWrite->insert($document);
122		$res = $this->manager->executeBulkWrite($namespace, $dbWrite, $options);
123		if($res->getInsertedCount() === 1)
124		{
125		$document['_id'] = $id;
126		return true;
127		}
128		return false;
129		}
130
131	View Code Duplication	public function remove($criteria = array(), array $options = array(), $collectionName)
		0 ignored issues – show Duplication introduced 2019-06-21 16:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
132		{
133		$namespace = $this->db_name.'.'.$collectionName;
134		$dbWrite = new \MongoDB\Driver\BulkWrite();
135		$dbWrite->delete($criteria);
136		$res = $this->manager->executeBulkWrite($namespace, $dbWrite, $options);
137		return $res->getDeletedCount() >= 1;
138		}
139
140	View Code Duplication	public function update($criteria, $new_object, $options = array(), $collectionName)
		0 ignored issues – show Duplication introduced 2019-06-21 16:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
141		{
142		$namespace = $this->db_name.'.'.$collectionName;
143		$dbWrite = new \MongoDB\Driver\BulkWrite();
144		$dbWrite->update($criteria, $new_object, $options);
145		$res = $this->manager->executeBulkWrite($namespace, $dbWrite, $options);
146		return $res->getModifiedCount() === 1;
147		}
148
149		public function count($query = array(), $options = array(), $collectionName)
		0 ignored issues – show Unused Code introduced 2018-02-16 15:57 UTC by Report Bug Copy Issue Report The parameter `$options` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
150		{
151		$cmd = new \MongoDB\Driver\Command(['count'=>$collectionName, 'query'=>$query]);
152		return $this->manager->executeCommand($this->db_name, $cmd);
153		}
154		}
155		/* vim: set tabstop=4 shiftwidth=4 expandtab: */
156

BurningFlipside / CommonCode

Pull Request — develop (#120)

MongoDataSet::update() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like