BurningFlipside / CommonCode

Data/class.ObjectDataTable.php

<?php
namespace Data;

class ObjectDataTable extends \Data\DataTable
{
    protected $dataTable;
    protected $className = 'SerializableObject';

    public static function getInstance()
    {
        static $instance = null;
        if(null === $instance)
        {
            $instance = new static();

The call to ObjectDataTable::__construct() misses a required argument $dataTable.

        }
        return $instance;
    }

    protected function __construct($dataTable)
    {
        $this->dataTable = $dataTable;
    }

    public function create($data)
    {
        if(is_array($data))
        {
            $data = new $this->className($data);
        }
        if(method_exists($data, 'preCreate'))
        {
            $data = $data->preCreate();
        }
        return $this->dataTable->create($data);
    }

    public function read($filter=false, $select=false, $count=false, $skip=false, $sort=false, $params=false)
    {
        $res = $this->dataTable->read($filter, $select, $count, $skip, $sort, $params);
        if($res === false)
        {
            return false;
        }
        if(!is_array($res))
        {
            $res = array($res);
        }
        $objCount = count($res);
        for($i = 0; $i < $objCount; $i++)
        {
            $res[$i] = new $this->className($res[$i]);
        }
        return $res;
    }

    public function update($filter, $data)
    {
        if(method_exists($data, 'preUpdate'))
        {
            $data = $data->preUpdate();
        }
        return $this->dataTable->update($filter, $data);
    }

    public function delete($filter)
    {
        if(method_exists($data, 'preDelete'))

The variable $data seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

        {
            $data = $data->preDelete();

The variable $data seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

$data is not used, you could remove the assignment.

        }
        return $dataTable->delete($filter);

The variable $dataTable does not exist. Did you forget to declare it?

    }

    public function count($filter=false)
    {
        return parent::count($filter);
    }
}