View GitHub Repository CommonCode

Schedule Inspection
Subscribe
Completed
Pull Request — develop (#17)
by Patrick
06:46
created
Status
Category
Toggle Patches
Http/Html/class.FlipPage.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch 
@@ -365,7 +365,6 @@
 
 block discarded – undo
365 365 
     /**
366 366 
      * Draw the page
367 367 
      *
368 
-     * @param boolean $header Draw the header
369 368 
      */
370 369 
     public function printPage($response)
371 370 
     {
Please login to merge, or discard this patch.
Http/Html/class.WebPage.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -125,12 +125,12 @@
 
 block discarded – undo
125 125 
     protected function printHead($response)
126 126 
     {
127 127 
         $head = '<HEAD><TITLE>'.$this->title.'</TITLE>';
128 
-        $head.='<meta name="viewport" content="width=device-width, initial-scale=1.0">';
128 
+        $head .= '<meta name="viewport" content="width=device-width, initial-scale=1.0">';
129 129 
         foreach($this->headTags as $tag)
130 130 
         {
131 
-            $head.=$tag."\n";
131 
+            $head .= $tag."\n";
132 132 
         }
133 
-        $head.='</HEAD>';
133 
+        $head .= '</HEAD>';
134 134 
         return $response->write($head);
135 135 
     }
136 136
Please login to merge, or discard this patch.
Http/Rest/class.SerializationMiddleware.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch 
@@ -24,6 +24,9 @@  discard block
 
 block discarded – undo
24 24 
         }
25 25 
     }
26 26
27 
+    /**
28 
+     * @param string $param
29 
+     */
27 30 
     private function getParamFromArrayIfSet($array, $param, $default = null)
28 31 
     {
29 32 
         if(isset($array[$param]))
 
@@ -52,6 +55,9 @@  discard block
 
 block discarded – undo
52 55 
         return $response;
53 56 
     }
54 57
58 
+    /**
59 
+     * @param string $serializer
60 
+     */
55 61 
     protected function reserializeBody($response, $serializer)
56 62 
     {
57 63 
         $body = $response->getBody();
Please login to merge, or discard this patch.
Http/class.WebSite.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -12,7 +12,7 @@  discard block
 
 block discarded – undo
12 12 
     {
13 13 
         parent::__construct();
14 14 
         $c = $this->getContainer();
15 
-        $c['errorHandler'] = function($c) { return new WebErrorHandler();};
15 
+        $c['errorHandler'] = function($c) { return new WebErrorHandler(); };
16 16 
         $this->add(new AuthMiddleware());
17 17 
         $this->add(new ODataMiddleware());
18 18 
     }
 
@@ -24,6 +24,6 @@  discard block
 
 block discarded – undo
24 24
25 25 
     public function registerAPI($uri, $api)
26 26 
     {
27 
-        $this->group($uri, function() use($api) {$api->setup($this);})->add(new \Http\Rest\SerializationMiddleware());
27 
+        $this->group($uri, function() use($api) {$api->setup($this); })->add(new \Http\Rest\SerializationMiddleware());
28 28 
     }
29 29 
 }
Please login to merge, or discard this patch.