FlipsideAPIUser::getCity() - Code Metrics - Inspection of "Add Magic Methods to User for properties" - BurningFlipside/CommonCode - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#12)

by Patrick

created 2016-06-10 02:18 UTC

FlipsideAPIUser::getCity() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	4
nc	2
nop	0
dl	0
loc	8
rs	9.4285
c	1
b	0
f	0

<?php
namespace Auth;
if(!class_exists('Httpful\Request'))
{
    require(realpath(dirname(__FILE__)).'/../libs/httpful/bootstrap.php');
}

class FlipsideAPIUser extends User
{
    private $userData;
    private $groupData = null;

    public function __construct($data = false)
    {
        if(($data !== false) && !isset($data['extended']))
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
        {
            //Generic user object
            //TODO get from API
        }
        else
        {
            if(isset($data['extended']))
            {
                $this->userData = $data['extended'];
            }
        }
    }

    public function isInGroupNamed($name)
    {
        if($this->groupData === null)
        {
            $resp = \Httpful\Request::get('https://profiles.test.burningflipside.com/api/v1/users/me/groups')->authenticateWith($this->userData->uid, $this->userData->userPassword)->send();
            if($resp->hasErrors())
            {
                return false;
            }
            $this->groupData = $resp->body;
        }
        $count = count($this->groupData);
        for($i = 0; $i < $count; $i++)
        {
            if($this->groupData[$i]->cn === $name)
            {
                return true;
            }
        }
        return false;
    }

    public function __get($propName)
    {
        if($this->userData === null)
        {
            return parent::__get($propName);
        }
        $propName = strtolower($propName);
        return $this->userData->{$propName};
    }

    public function __set($propName, $value)
    {
    }
}



1			<?php
2			namespace Auth;
3			if(!class_exists('Httpful\Request'))
4			{
5			require(realpath(dirname(__FILE__)).'/../libs/httpful/bootstrap.php');
6			}
7
8			class FlipsideAPIUser extends User
9			{
10			private $userData;
11			private $groupData = null;
12
13			public function __construct($data = false)
14			{
15			if(($data !== false) && !isset($data['extended']))
			0 ignored issues – show Unused Code introduced 2016-05-13 18:20 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
16			{
17			//Generic user object
18			//TODO get from API
19			}
20			else
21			{
22			if(isset($data['extended']))
23			{
24			$this->userData = $data['extended'];
25			}
26			}
27			}
28
29			public function isInGroupNamed($name)
30			{
31			if($this->groupData === null)
32			{
33			$resp = \Httpful\Request::get('https://profiles.test.burningflipside.com/api/v1/users/me/groups')->authenticateWith($this->userData->uid, $this->userData->userPassword)->send();
34			if($resp->hasErrors())
35			{
36			return false;
37			}
38			$this->groupData = $resp->body;
39			}
40			$count = count($this->groupData);
41			for($i = 0; $i < $count; $i++)
42			{
43			if($this->groupData[$i]->cn === $name)
44			{
45			return true;
46			}
47			}
48			return false;
49			}
50
51			public function __get($propName)
52			{
53			if($this->userData === null)
54			{
55			return parent::__get($propName);
56			}
57			$propName = strtolower($propName);
58			return $this->userData->{$propName};
59			}
60
61			public function __set($propName, $value)
62			{
63			}
64			}
65
66

BurningFlipside / CommonCode

Pull Request — master (#12)

FlipsideAPIUser::getCity() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like