Issues in class.Settings.php - New Issues - Inspection of "New settings class" - BurningFlipside/CommonCode - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

by Patrick

created 2016-06-07 20:04 UTC

class.Settings.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class Settings extends \Singleton
{
    protected function __construct()
    {
        if(isset($GLOBALS['FLIPSIDE_SETTINGS_LOC']))
        {
            require $GLOBALS['FLIPSIDE_SETTINGS_LOC'].'/class.FlipsideSettings.php';
            return;
        }
        if(is_readable('/var/www/secure_settings/class.FlipsideSettings.php'))
        {
            require '/var/www/secure_settings/class.FlipsideSettings.php';
            return;
        }
    }

    public function getClassesByPropName($propName)
    {
        $ret = array();
        if(isset(FlipsideSettings::$$propName))
        {
            $prop = FlipsideSettings::$$propName;
            $keys = array_keys($prop);
            $count = count($keys);
            for($i = 0; $i < $count; $i++)
            {
                $class = $keys[$i];
                array_push($this->methods, new $class($prop[$keys[$i]]));
class MyClass { }

$x = new MyClass();
$x->foo = true;
            }
        }
        return $ret;
    }

    public function getDataSetData($dataSetName)
    {
        if(!isset(FlipsideSettings::$dataset) || !isset(FlipsideSettings::$dataset[$dataSetName]))
        {
            return false;
        }
        return FlipsideSettings::$dataset[$dataSetName];
    }

    public function getGlobalSetting($propName, $default = false)
    {
        if(isset(FlipsideSettings::$global) && FlipsideSettings::$global[$propName])
        {
            return FlipsideSettings::$global[$propName];
        }
        return $default;
    }

    public function getSiteLinks()
    {
        if(isset(FlipsideSettings::$sites))
        {
            return FlipsideSettings::$sites;
        }
        return array();
    }

    private function getLDAPHost($default)
    {
        if(!isset(FlipsideSettings::$ldap) || !isset(FlipsideSettings::$ldap['host']))
        {
            return $default;
        }
        if(isset(\FlipsideSettings::$ldap['proto']))
        {
            return \FlipsideSettings::$ldap['proto'].'://'.\FlipsideSettings::$ldap['host'];
        }
        return \FlipsideSettings::$ldap['host'];
    }

    public function getLDAPSetting(string $propName, $ldapAuth = false, $default = false)
    {
        switch($propName)
        {
            case 'host':
                return $this->getLDAPHost($default);
            default:
                if($ldapAuth == false)

                {
                    return FlipsideSettings::$ldap[$propName];
                }
                return FlipsideSettings::$ldap_auth[$propName];
        }
    }
}


1			<?php
2
3			class Settings extends \Singleton
4			{
5			protected function __construct()
6			{
7			if(isset($GLOBALS['FLIPSIDE_SETTINGS_LOC']))
8			{
9			require $GLOBALS['FLIPSIDE_SETTINGS_LOC'].'/class.FlipsideSettings.php';
10			return;
11			}
12			if(is_readable('/var/www/secure_settings/class.FlipsideSettings.php'))
13			{
14			require '/var/www/secure_settings/class.FlipsideSettings.php';
15			return;
16			}
17			}
18
19			public function getClassesByPropName($propName)
20			{
21			$ret = array();
22			if(isset(FlipsideSettings::$$propName))
23			{
24			$prop = FlipsideSettings::$$propName;
25			$keys = array_keys($prop);
26			$count = count($keys);
27			for($i = 0; $i < $count; $i++)
28			{
29			$class = $keys[$i];
30			array_push($this->methods, new $class($prop[$keys[$i]]));
			0 ignored issues – show Bug introduced 2016-06-07 20:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `methods` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
31			}
32			}
33			return $ret;
34			}
35
36			public function getDataSetData($dataSetName)
37			{
38			if(!isset(FlipsideSettings::$dataset) \|\| !isset(FlipsideSettings::$dataset[$dataSetName]))
39			{
40			return false;
41			}
42			return FlipsideSettings::$dataset[$dataSetName];
43			}
44
45			public function getGlobalSetting($propName, $default = false)
46			{
47			if(isset(FlipsideSettings::$global) && FlipsideSettings::$global[$propName])
48			{
49			return FlipsideSettings::$global[$propName];
50			}
51			return $default;
52			}
53
54			public function getSiteLinks()
55			{
56			if(isset(FlipsideSettings::$sites))
57			{
58			return FlipsideSettings::$sites;
59			}
60			return array();
61			}
62
63			private function getLDAPHost($default)
64			{
65			if(!isset(FlipsideSettings::$ldap) \|\| !isset(FlipsideSettings::$ldap['host']))
66			{
67			return $default;
68			}
69			if(isset(\FlipsideSettings::$ldap['proto']))
70			{
71			return \FlipsideSettings::$ldap['proto'].'://'.\FlipsideSettings::$ldap['host'];
72			}
73			return \FlipsideSettings::$ldap['host'];
74			}
75
76			public function getLDAPSetting(string $propName, $ldapAuth = false, $default = false)
77			{
78			switch($propName)
79			{
80			case 'host':
81			return $this->getLDAPHost($default);
82			default:
83			if($ldapAuth == false)
			0 ignored issues – show Coding Style Best Practice introduced 2016-06-07 20:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
84			{
85			return FlipsideSettings::$ldap[$propName];
86			}
87			return FlipsideSettings::$ldap_auth[$propName];
88			}
89			}
90			}
91

BurningFlipside / CommonCode

Pull Request — master (#11)

class.Settings.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like