BurningFlipside / CommonCode

class.FlipAdminPage.php

Braces +2 added lines, -4 removed lines

@@ -34,8 +34,7 @@ 
         if($this->user === false || $this->user === null)
         {
             $this->add_link('<i class="fa fa-sign-in"></i> Login', $this->loginUrl);
-        }
-        else
+        } else
         {
             $this->add_links();
             $this->add_link('<i class="fa fa-sign-out"></i> Logout', $this->logoutUrl);
@@ -166,8 +165,7 @@ 
                 <h1 class="page-header">You must <a href="'.$this->loginUrl.'?return='.$this->current_url().'">log in <span class="glyphicon glyphicon-log-in"></span></a> to access the '.$this->title.' Admin system!</h1>
             </div>
         </div>';
-        }
-        else if($this->is_admin === false)
+        } else if($this->is_admin === false)
         {
             $this->body = '
         <div class="row">

Spacing +13 added lines, -13 removed lines

@@ -6,13 +6,13 @@ 
     public $user;
     public $is_admin = false;
 
-    function __construct($title, $adminGroup='LDAPAdmins')
+    function __construct($title, $adminGroup = 'LDAPAdmins')
     {
         $this->user = FlipSession::getUser();
         $this->is_admin = $this->userIsAdmin($adminGroup);
         parent::__construct($title);
         $adminCSS = '/css/common/admin.min.css';
-        if($this->minified !== 'min')
+        if ($this->minified !== 'min')
         {
             $adminCSS = '/css/common/admin.css';
         }
@@ -22,7 +22,7 @@ 
 
     protected function userIsAdmin($adminGroup)
     {
-        if($this->user === false || $this->user === null)
+        if ($this->user === false || $this->user === null)
         {
             return false;
         }
@@ -31,7 +31,7 @@ 
 
     function addAllLinks()
     {
-        if($this->user === false || $this->user === null)
+        if ($this->user === false || $this->user === null)
         {
             $this->addLink('<i class="fa fa-sign-in"></i> Login', $this->loginUrl);
         }
@@ -47,13 +47,13 @@ 
         $ret  = '<li>';
         $href = $this->getHrefForDropdown($link);
         $ret .= $this->createLink($name.' <i class="fa fa-arrow-right"></i>', $href);
-        $ret.='<ul>';
+        $ret .= '<ul>';
         $subNames = array_keys($link);
-        foreach($subNames as $subName)
+        foreach ($subNames as $subName)
         {
-            $ret.=$this->getLinkByName($subName, $link);
+            $ret .= $this->getLinkByName($subName, $link);
         }
-        $ret.='</ul></li>';
+        $ret .= '</ul></li>';
         return $ret;
     }
 
@@ -62,7 +62,7 @@ 
         $sites   = $this->getSiteLinksForHeader();
         $sideNav = $this->getLinksMenus();
         $log     = '<a href="https://profiles.burningflipside.com/logout.php"><i class="fa fa-sign-out"></i></a>';
-        if($this->user === false || $this->user === null)
+        if ($this->user === false || $this->user === null)
         {
             $log = '<a href="https://profiles.burningflipside.com/login.php?return='.$this->currentUrl().'"><i class="fa fa-sign-in"></i></a>';
         }
@@ -108,7 +108,7 @@ 
     const CARD_YELLOW = 'panel-yellow';
     const CARD_RED    = 'panel-red';
 
-    function add_card($iconName, $bigText, $littleText, $link='#', $color = self::CARD_BLUE, $textColor=false)
+    function add_card($iconName, $bigText, $littleText, $link = '#', $color = self::CARD_BLUE, $textColor = false)
     {
         $card = '<div class="col-lg-3 col-md-6">
                      <div class="panel '.$color.'">
@@ -135,9 +135,9 @@ 
         $this->body .= $card;
     }
 
-    function printPage($header=true)
+    function printPage($header = true)
     {
-        if($this->user === false || $this->user === null)
+        if ($this->user === false || $this->user === null)
         {
             $this->body = '
         <div class="row">
@@ -146,7 +146,7 @@ 
             </div>
         </div>';
         }
-        else if($this->is_admin === false)
+        else if ($this->is_admin === false)
         {
             $this->body = '
         <div class="row">

Auth/class.PendingUser.php

Spacing +6 added lines, -6 removed lines

@@ -49,7 +49,7 @@ 
      */
     public function getEmail()
     {
-        if(isset($this->email))
+        if (isset($this->email))
         {
             return $this->email;
         }
@@ -63,7 +63,7 @@ 
      */
     public function getGivenName()
     {
-        if(isset($this->givenName))
+        if (isset($this->givenName))
         {
             return $this->givenName;
         }
@@ -77,7 +77,7 @@ 
      */
     public function getLastName()
     {
-        if(isset($this->sn))
+        if (isset($this->sn))
         {
             return $this->sn;
         }
@@ -104,7 +104,7 @@ 
      */
     function getLoginProviders()
     {
-        if(isset($this->host))
+        if (isset($this->host))
         {
             return $this->host;
         }
@@ -120,7 +120,7 @@ 
      */
     function addLoginProvider($provider)
     {
-        if(isset($this->host))
+        if (isset($this->host))
         {
             array_push($this->host, $provider);
         }
@@ -199,7 +199,7 @@ 
                 Burning Flipside Technology Team');
         $email_msg->setSubject('Burning Flipside Registration');
         $email_provider = \EmailProvider::getInstance();
-        if($email_provider->sendEmail($email_msg) === false)
+        if ($email_provider->sendEmail($email_msg) === false)
         {
             throw new \Exception('Unable to send email!');
         }

Braces +1 added lines, -2 removed lines

@@ -34,8 +34,7 @@
             $args['RawMessage'] = array();
             $args['RawMessage']['Data'] = base64_encode($email->getRawMessage());
             return $this->ses->sendRawEmail($args);
-        }
-        else
+        } else
         {
             $args = array();
             $args['Source'] = $email->getFromAddress();

Auth/class.FlipsideAPIUser.php

Spacing +24 added lines, -24 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 namespace Auth;
-if(!class_exists('Httpful\Request'))
+if (!class_exists('Httpful\Request'))
 {
     require(realpath(dirname(__FILE__)).'/../libs/httpful/bootstrap.php');
 }
@@ -10,16 +10,16 @@ 
     private $userData;
     private $groupData = null;
 
-    public function __construct($data=false)
+    public function __construct($data = false)
     {
-        if($data !== false && !isset($data['extended']))
+        if ($data !== false && !isset($data['extended']))
         {
             //Generic user object
             //TODO get from API
         }
         else
         {
-            if(isset($data['extended']))
+            if (isset($data['extended']))
             {
                 $this->userData = $data['extended'];
             }
@@ -28,19 +28,19 @@ 
 
     function isInGroupNamed($name)
     {
-        if($this->groupData === null)
+        if ($this->groupData === null)
         {
             $resp = \Httpful\Request::get('https://profiles.test.burningflipside.com/api/v1/users/me/groups')->authenticateWith($this->userData->uid, $this->userData->userPassword)->send();
-            if($resp->hasErrors())
+            if ($resp->hasErrors())
             {
                 return false;
             }
             $this->groupData = $resp->body;
         }
         $count = count($this->groupData);
-        for($i = 0; $i < $count; $i++)
+        for ($i = 0; $i < $count; $i++)
         {
-            if($this->groupData[$i]->cn === $name)
+            if ($this->groupData[$i]->cn === $name)
             {
                 return true;
             }
@@ -50,7 +50,7 @@ 
 
     function getDisplayName()
     {
-        if($this->userData === null)
+        if ($this->userData === null)
         {
             return parent::getDisplayName();
         }
@@ -59,7 +59,7 @@ 
 
     function getGivenName()
     {
-        if($this->userData === null)
+        if ($this->userData === null)
         {
             return parent::getGivenName();
         }
@@ -68,7 +68,7 @@ 
 
     function getEmail()
     {
-        if($this->userData === null)
+        if ($this->userData === null)
         {
             return parent::getEmail();
         }
@@ -77,7 +77,7 @@ 
 
     function getUid()
     {
-        if($this->userData === null)
+        if ($this->userData === null)
         {
             return parent::getUid();
         }
@@ -86,7 +86,7 @@ 
 
     function getPhoneNumber()
     {
-        if($this->userData === null)
+        if ($this->userData === null)
         {
             return parent::getPhoneNumber();
         }
@@ -95,7 +95,7 @@ 
 
     function getOrganization()
     {
-        if($this->userData === null)
+        if ($this->userData === null)
         {
             return parent::getOrganization();
         }
@@ -104,7 +104,7 @@ 
 
     function getTitles()
     {
-        if($this->userData === null)
+        if ($this->userData === null)
         {
             return parent::getTitles();
         }
@@ -113,7 +113,7 @@ 
 
     function getState()
     {
-        if($this->userData === null)
+        if ($this->userData === null)
         {
             return parent::getState();
         }
@@ -122,7 +122,7 @@ 
 
     function getCity()
     {
-        if($this->userData === null)
+        if ($this->userData === null)
         {
             return parent::getCity();
         }
@@ -131,7 +131,7 @@ 
 
     function getLastName()
     {
-        if($this->userData === null)
+        if ($this->userData === null)
         {
             return parent::getLastName();
         }
@@ -140,7 +140,7 @@ 
 
     function getNickName()
     {
-        if($this->userData === null)
+        if ($this->userData === null)
         {
             return parent::getNickName();
         }
@@ -149,7 +149,7 @@ 
 
     function getAddress()
     {
-        if($this->userData === null)
+        if ($this->userData === null)
         {
             return parent::getAddress();
         }
@@ -158,7 +158,7 @@ 
 
     function getPostalCode()
     {
-        if($this->userData === null)
+        if ($this->userData === null)
         {
             return parent::getPostalCode();
         }
@@ -167,7 +167,7 @@ 
 
     function getCountry()
     {
-        if($this->userData === null)
+        if ($this->userData === null)
         {
             return parent::getCountry();
         }
@@ -176,7 +176,7 @@ 
 
     function getOrganizationUnits()
     {
-        if($this->userData === null)
+        if ($this->userData === null)
         {
             return parent::getOrganizationUnits();
         }
@@ -185,7 +185,7 @@ 
 
     function getLoginProviders()
     {
-        if($this->userData === null)
+        if ($this->userData === null)
         {
             return parent::getLoginProviders();
         }

Braces +1 added lines, -2 removed lines

@@ -34,8 +34,7 @@
             $args['RawMessage'] = array();
             $args['RawMessage']['Data'] = base64_encode($email->getRawMessage());
             return $this->ses->sendRawEmail($args);
-        }
-        else
+        } else
         {
             $args = array();
             $args['Source'] = $email->getFromAddress();

Auth/class.Group.php

Spacing +13 added lines, -13 removed lines

@@ -23,12 +23,12 @@ 
         return false;
     }
 
-    public function getMemberUids($recursive=true)
+    public function getMemberUids($recursive = true)
     {
         return array();
     }
 
-    public function members($details=false, $recursive=true, $includeGroups=true)
+    public function members($details = false, $recursive = true, $includeGroups = true)
     {
         return array();
     }
@@ -46,20 +46,20 @@ 
     public function jsonSerialize()
     {
         $group = array();
-        try{
+        try {
         $group['cn'] = $this->getGroupName();
         $group['description'] = $this->getDescription();
         $group['member'] = $this->getMemberUids();
-        } catch(\Exception $e) {echo $e->getMessage(); die();}
+        } catch (\Exception $e) {echo $e->getMessage(); die(); }
         return $group;
     }
 
-    public function getNonMembers($select=false)
+    public function getNonMembers($select = false)
     {
         return array();
     }
 
-    public function addMember($name, $isGroup=false, $flush=true)
+    public function addMember($name, $isGroup = false, $flush = true)
     {
         return false;
     }
@@ -70,24 +70,24 @@ 
         $auth = \AuthProvider::getInstance();
         $ldap = $auth->getAuthenticator('Auth\LDAPAuthenticator');
         $ldap->get_and_bind_server(true);
-        if(isset($group->description))
+        if (isset($group->description))
         {
             $this->setDescription($group->description);
             unset($group->description);
         }
-        if(isset($group->member))
+        if (isset($group->member))
         {
             $this->clearMembers();
             $count = count($group->member);
-            for($i = 0; $i < $count; $i++)
+            for ($i = 0; $i < $count; $i++)
             {
                 $isLast = false;
-                if($i === $count - 1)
+                if ($i === $count - 1)
                 {
                     $isLast = true;
                 }
-                if(!isset($group->member[$i]->type)) continue;
-                if($group->member[$i]->type === 'Group')
+                if (!isset($group->member[$i]->type)) continue;
+                if ($group->member[$i]->type === 'Group')
                 {
                     $this->addMember($group->member[$i]->cn, true, $isLast);
                 }
@@ -101,7 +101,7 @@ 
         return true;
     }
 
-    static function from_name($name, $data=false)
+    static function from_name($name, $data = false)
     {
         return false;
     }

Braces +4 added lines, -3 removed lines

@@ -86,12 +86,13 @@
                 {
                     $isLast = true;
                 }
-                if(!isset($group->member[$i]->type)) continue;
+                if(!isset($group->member[$i]->type)) {
+                    continue;
+                }
                 if($group->member[$i]->type === 'Group')
                 {
                     $this->addMember($group->member[$i]->cn, true, $isLast);
-                }
-                else
+                } else
                 {
                     $this->addMember($group->member[$i]->uid, false, $isLast);
                 }

Auth/class.SQLPendingUser.php

Spacing +3 added lines, -3 removed lines

@@ -28,7 +28,7 @@ 
 
     function getEmail()
     {
-        if(is_array($this->blob->mail))
+        if (is_array($this->blob->mail))
         {
             return $this->blob->mail[0];
         }
@@ -37,7 +37,7 @@ 
 
     function getUid()
     {
-        if(is_array($this->blob->uid))
+        if (is_array($this->blob->uid))
         {
             return $this->blob->uid[0];
         }
@@ -46,7 +46,7 @@ 
 
     function getPassword()
     {
-        if(is_array($this->blob->password))
+        if (is_array($this->blob->password))
         {
             return $this->blob->password[0];
         }

Auth/class.SQLAuthenticator.php

Spacing +48 added lines, -48 removed lines

@@ -1,7 +1,7 @@ 
 <?php
 namespace Auth;
 
-if(!function_exists('password_hash') || !function_exists('password_verify')) 
+if (!function_exists('password_hash') || !function_exists('password_verify')) 
 {
     define('PASSWORD_BCRYPT', 1);
     define('PASSWORD_DEFAULT', PASSWORD_BCRYPT);
@@ -9,22 +9,22 @@ 
 
     function password_hash($password, $algo = PASSWORD_DEFAULT)
     {
-        if(is_null($password) || is_int($password))
+        if (is_null($password) || is_int($password))
         {
             $password = (string)$password;
         }
-        if(!is_string($password))
+        if (!is_string($password))
         {
             trigger_error("password_hash(): Password must be a string", E_USER_WARNING);
             return false;
         }
-        if(!is_int($algo))
+        if (!is_int($algo))
         {
-            trigger_error("password_hash() expects parameter 2 to be long, " . gettype($algo) . " given", E_USER_WARNING);
+            trigger_error("password_hash() expects parameter 2 to be long, ".gettype($algo)." given", E_USER_WARNING);
             return false;
         }
         $resultLength = 0;
-        switch($algo)
+        switch ($algo)
         {
             case PASSWORD_BCRYPT:
                 $cost = PASSWORD_BCRYPT_DEFAULT_COST;
@@ -43,9 +43,9 @@ 
         $base64String = base64_encode($salt);
         $salt = strtr(rtrim($base64String, '='), $base64Digits, $bcrypt64Digits);
         $salt = substr($salt, 0, $requiredSaltLen);
-        $hash = $hashFormat . $salt;
+        $hash = $hashFormat.$salt;
         $ret = crypt($password, $hash);
-        if(!is_string($ret) || strlen($ret) != $resultLength)
+        if (!is_string($ret) || strlen($ret) != $resultLength)
         {
             return false;
         }
@@ -55,13 +55,13 @@ 
     function password_verify($password, $hash)
     {
         $ret = crypt($password, $hash);
-        if(!is_string($ret) || strlen($ret) != strlen($hash) || strlen($ret) <= 13)
+        if (!is_string($ret) || strlen($ret) != strlen($hash) || strlen($ret) <= 13)
         {
             return false;
         }
         $status = 0;
         $count  = strlen($ret);
-        for($i = 0; $i < $count; $i++)
+        for ($i = 0; $i < $count; $i++)
         {
             $status |= (ord($ret[$i]) ^ ord($hash[$i]));
         }
@@ -80,11 +80,11 @@ 
     {
         parent::__construct($params);
         $this->params = $params;
-        if($this->current)
+        if ($this->current)
         {
             $this->dataSet = $this->getCurrentDataSet();
         }
-        if($this->pending)
+        if ($this->pending)
         {
             $this->pendingDataSet = $this->getPendingDataSet();
         }
@@ -95,7 +95,7 @@ 
      */
     private function getCurrentDataSet()
     {
-        if(isset($this->params['current_data_set']))
+        if (isset($this->params['current_data_set']))
         {
             return \DataSetFactory::get_data_set($this->params['current_data_set']);
         }
@@ -107,30 +107,30 @@ 
      */
     private function getPendingDataSet()
     {
-        if(isset($this->params['pending_data_set']))
+        if (isset($this->params['pending_data_set']))
         {
             return \DataSetFactory::get_data_set($this->params['pending_data_set']);
         }
         return \DataSetFactory::get_data_set('pending_authentication');
     }
 
-    private function getDataTable($name, $pending=false)
+    private function getDataTable($name, $pending = false)
     {
-         if(isset($this->dataTables[$name]) && isset($this->dataTables[$name][$pending]))
+         if (isset($this->dataTables[$name]) && isset($this->dataTables[$name][$pending]))
          {
              return $this->dataTables[$name][$pending];
          }
          $dataSet = $this->dataSet;
-         if($pending)
+         if ($pending)
          {
              $dataSet = $this->pendingDataSet;
          }
-         if($dataSet === null)
+         if ($dataSet === null)
          {
              throw new \Exception('Unable to obtain dataset for SQL Authentication!');
          }
          $dataTable = $dataSet[$name];
-         if(!isset($this->dataTables[$name]))
+         if (!isset($this->dataTables[$name]))
          {
              $this->dataTables[$name] = array();
          }
@@ -140,7 +140,7 @@ 
 
     private function getPendingUserDataTable()
     {
-        if(isset($this->params['pending_user_table']))
+        if (isset($this->params['pending_user_table']))
         {
             return $this->getDataTable($this->params['pending_user_table'], true);
         }
@@ -149,15 +149,15 @@ 
 
     public function login($username, $password)
     {
-        if($this->current === false) return false;
+        if ($this->current === false) return false;
         $userDataTable = $this->getDataTable('user');
         $filter = new \Data\Filter("uid eq '$username'");
         $users = $userDataTable->read($filter, 'uid,pass');
-        if($users === false || !isset($users[0]))
+        if ($users === false || !isset($users[0]))
         {
             return false;
         }
-        if(password_verify($password, $users[0]['pass']))
+        if (password_verify($password, $users[0]['pass']))
         {
             return array('res'=>true, 'extended'=>$users[0]['uid']);
         }
@@ -166,7 +166,7 @@ 
 
     public function isLoggedIn($data)
     {
-        if(isset($data['res']))
+        if (isset($data['res']))
         {
             return $data['res'];
         }
@@ -183,7 +183,7 @@ 
         $groupDataTable = $this->getDataTable('group');
         $filter = new \Data\Filter("gid eq '$name'");
         $groups = $groupDataTable->read($filter);
-        if($groups === false || !isset($groups[0]))
+        if ($groups === false || !isset($groups[0]))
         {
             return false;
         }
@@ -195,7 +195,7 @@ 
         $userDataTable = $this->getDataTable('user');
         $filter = new \Data\Filter("uid eq '$name'");
         $users = $userDataTable->read($filter);
-        if($users === false || !isset($users[0]))
+        if ($users === false || !isset($users[0]))
         {
             return false;
         }
@@ -211,33 +211,33 @@ 
     private function convertDataToClass($dataTableName, $className, $filter, $select, $top, $skip, $orderby)
     {
         $data = $this->getDataByFilter($dataTableName, $filter, $select, $top, $skip, $orderby);
-        if($data === false)
+        if ($data === false)
         {
             return false;
         }
         $count = count($data);
-        for($i = 0; $i < $count; $i++)
+        for ($i = 0; $i < $count; $i++)
         {
             $data[$i] = new $className($groups[$i]);
         }
         return $data;
     }
 
-    public function getGroupsByFilter($filter, $select=false, $top=false, $skip=false, $orderby=false)
+    public function getGroupsByFilter($filter, $select = false, $top = false, $skip = false, $orderby = false)
     {
         return $this->convertDataToClass('group', 'SQLGroup', $filter, $select, $top, $skip, $orderby);
     }
 
-    public function getUsersByFilter($filter, $select=false, $top=false, $skip=false, $orderby=false)
+    public function getUsersByFilter($filter, $select = false, $top = false, $skip = false, $orderby = false)
     {
         return $this->convertDataToClass('group', 'SQLUser', $filter, $select, $top, $skip, $orderby);
     }
 
     public function getPendingUserCount()
     {
-        if($this->pending === false) return 0;
+        if ($this->pending === false) return 0;
         $dataTable = $this->getPendingUserDataTable();
-        if($dataTable === null) return 0;
+        if ($dataTable === null) return 0;
         return $dataTable->count();
     }
 
@@ -245,26 +245,26 @@ 
     {
         $userDataTable = $this->getPendingUserDataTable();
         $fieldData = $filter->to_mongo_filter();
-        $firstFilter = new \Data\Filter('substringof(data,"'.implode($fieldData,' ').'")');
+        $firstFilter = new \Data\Filter('substringof(data,"'.implode($fieldData, ' ').'")');
         $users = $userDataTable->read($firstFilter, $select, $top, $skip, $orderby);
-        if($users === false)
+        if ($users === false)
         {
             return false;
         }
         $ret = array();
         $count = count($users);
-        for($i = 0; $i < $count; $i++)
+        for ($i = 0; $i < $count; $i++)
         {
             $user = new SQLPendingUser($users[$i], $userDataTable);
             $err = false;
-            foreach($fieldData as $field=>$data)
+            foreach ($fieldData as $field=>$data)
             {
-                if(strcasecmp($user[$field], $data) !== 0)
+                if (strcasecmp($user[$field], $data) !== 0)
                 {
                     $err = true; break;
                 }
             }
-            if(!$err)
+            if (!$err)
             {
                 array_push($ret, $user);
             }
@@ -272,22 +272,22 @@ 
         return $ret;
     }
 
-    public function getPendingUsersByFilter($filter, $select=false, $top=false, $skip=false, $orderby=false)
+    public function getPendingUsersByFilter($filter, $select = false, $top = false, $skip = false, $orderby = false)
 
     {
-        if($this->pending === false) return false;
-        if($filter !== false && !$filter->contains('hash'))
+        if ($this->pending === false) return false;
+        if ($filter !== false && !$filter->contains('hash'))
         {
             return $this->searchPendingUsers($filter, $select, $top, $skip, $orderby);
         }
         $userDataTable = $this->getPendingUserDataTable();
         $users = $userDataTable->read($filter, $select, $top, $skip, $orderby);
-        if($users === false)
+        if ($users === false)
         {
             return false;
         }
         $count = count($users);
-        for($i = 0; $i < $count; $i++)
+        for ($i = 0; $i < $count; $i++)
         {
             $users[$i] = new SQLPendingUser($users[$i], $userDataTable);
         }
@@ -296,9 +296,9 @@ 
 
     public function createPendingUser($user)
     {
-        if($this->pending === false) return false;
+        if ($this->pending === false) return false;
         $userDataTable = $this->getPendingUserDataTable();
-        if(isset($user->password2))
+        if (isset($user->password2))
         {
             unset($user->password2);
         }
@@ -306,10 +306,10 @@ 
         $hash = hash('sha512', $json);
         $array = array('hash'=>$hash, 'data'=>$json);
         $ret = $userDataTable->create($array);
-        if($ret !== false)
+        if ($ret !== false)
         {
             $users = $this->getPendingUsersByFilter(new \Data\Filter("hash eq '$hash'"));
-            if($users === false || !isset($users[0]))
+            if ($users === false || !isset($users[0]))
             {
                 throw new \Exception('Error retreiving user object after successful create!');
             }
@@ -321,7 +321,7 @@ 
     public function getTempUserByHash($hash)
     {
         $users = $this->getPendingUsersByFilter(new \Data\Filter("hash eq '$hash'"));
-        if($users === false || !isset($users[0]))
+        if ($users === false || !isset($users[0]))
         {
             return false;
         }

Braces +15 added lines, -5 removed lines

@@ -149,7 +149,9 @@ 
 
     public function login($username, $password)
     {
-        if($this->current === false) return false;
+        if($this->current === false) {
+            return false;
+        }
         $userDataTable = $this->getDataTable('user');
         $filter = new \Data\Filter("uid eq '$username'");
         $users = $userDataTable->read($filter, 'uid,pass');
@@ -235,9 +237,13 @@ 
 
     public function getPendingUserCount()
     {
-        if($this->pending === false) return 0;
+        if($this->pending === false) {
+            return 0;
+        }
         $dataTable = $this->getPendingUserDataTable();
-        if($dataTable === null) return 0;
+        if($dataTable === null) {
+            return 0;
+        }
         return $dataTable->count();
     }
 
@@ -275,7 +281,9 @@ 
     public function getPendingUsersByFilter($filter, $select=false, $top=false, $skip=false, $orderby=false)
 
     {
-        if($this->pending === false) return false;
+        if($this->pending === false) {
+            return false;
+        }
         if($filter !== false && !$filter->contains('hash'))
         {
             return $this->searchPendingUsers($filter, $select, $top, $skip, $orderby);
@@ -296,7 +304,9 @@ 
 
     public function createPendingUser($user)
     {
-        if($this->pending === false) return false;
+        if($this->pending === false) {
+            return false;
+        }
         $userDataTable = $this->getPendingUserDataTable();
         if(isset($user->password2))
         {

Auth/class.GoogleAuthenticator.php

Spacing +9 added lines, -9 removed lines

@@ -10,11 +10,11 @@ 
     public function __construct($params)

     {

         parent::__construct($params);

-        if(!isset($params['client_secrets_path']))

+        if (!isset($params['client_secrets_path']))

         {

             throw new \Exception('Missing required parameter client_secrets_path!');

         }

-        if(!isset($params['redirect_url']))

+        if (!isset($params['redirect_url']))

         {

             $params['redirect_url'] = 'https://'.$_SERVER['HTTP_HOST'].'/oauth2callback.php?src=google';

         }

@@ -34,21 +34,21 @@ 
     public function authenticate($code, &$currentUser = false)

     {

         $googleUser = false;

-        try{

+        try {

             $this->client->authenticate($code);

             $this->token = $this->client->getAccessToken();

             \FlipSession::setVar('GoogleToken', $this->token);

             $oauth2Service = new \Google_Service_Oauth2($this->client);

             $googleUser = $oauth2Service->userinfo->get();

-        } catch(\Exception $ex) {

+        } catch (\Exception $ex) {

             return self::LOGIN_FAILED;

         }

 

         $auth = \AuthProvider::getInstance();

         $localUsers = $auth->getUsersByFilter(new \Data\Filter('mail eq '.$googleUser->email));

-        if($localUsers !== false && isset($localUsers[0]))

+        if ($localUsers !== false && isset($localUsers[0]))

         {

-            if($localUsers[0]->canLoginWith('google.com'))

+            if ($localUsers[0]->canLoginWith('google.com'))

             {

                 $auth->impersonateUser($localUsers[0]);

                 return self::SUCCESS;

@@ -64,7 +64,7 @@ 
             $user->setLastName($googleUser->familyName);

             $user->addLoginProvider('google.com');

             $ret = $auth->activatePendingUser($user);

-            if($ret === false)

+            if ($ret === false)

             {

                  throw new \Exception('Unable to create user! '.$res);

             }

@@ -74,7 +74,7 @@ 
 

     public function getUser($data = false)

     {

-        if($data === false)

+        if ($data === false)

         {

             $data = $this->token;

         }

@@ -89,7 +89,7 @@ 
             $profileUser['displayName'] = $googleUser->name;

             $profileUser['jpegPhoto'] = base64_encode(file_get_contents($googleUser->picture));

             return $profileUser;

-        } catch(\Exception $e)

+        } catch (\Exception $e)

         {

             return false;

         }

Braces +1 added lines, -2 removed lines

@@ -55,8 +55,7 @@
             }

             $currentUser = $localUsers[0];

             return self::ALREADY_PRESENT;

-        }

-        else

+        } else

         {

             $user = new PendingUser();

             $user->setEmail($googleUser->email);

Auth/OAuth2/class.OAuth2Authenticator.php

Spacing +7 added lines, -7 removed lines

@@ -14,7 +14,7 @@ 
 namespace Auth\OAuth2;
 
 /** Only load the HTTPFul bootstrap if it isn't already loaded*/
-if(!class_exists('Httpful\Request'))
+if (!class_exists('Httpful\Request'))
 {
     require('/var/www/common/libs/httpful/bootstrap.php');
 }
@@ -37,7 +37,7 @@ 
     public function __construct($params)
     {
         parent::__construct($params);
-        if(!isset($params['redirect_url']))
+        if (!isset($params['redirect_url']))
         {
             $this->redirect_uri = 'https://'.$_SERVER['HTTP_HOST'].'/oauth/callbacks/'.$this->getHostName();
         }
@@ -115,21 +115,21 @@ 
     public function authenticate($params, &$current_user)
     {
         $resp = $this->doAuthPost($params);
-        if($resp->hasErrors())
+        if ($resp->hasErrors())
         {
             return self::LOGIN_FAILED; 
         }
         \FlipSession::setVar('OAuthToken', $resp->body);
         $user = $this->getUserFromToken($resp->body);
-        if($user === false)
+        if ($user === false)
         {
             return self::LOGIN_FAILED;
         }
         $auth = \AuthProvider::getInstance();
         $local_users = $auth->getUsersByFilter(new \Data\Filter('mail eq '.$user->getEmail()));
-        if($local_users !== false && isset($local_users[0]))
+        if ($local_users !== false && isset($local_users[0]))
         {
-            if($local_users[0]->canLoginWith($this->getHostName()))
+            if ($local_users[0]->canLoginWith($this->getHostName()))
             {
                 $auth->impersonateUser($local_users[0]);
                 return self::SUCCESS;
@@ -138,7 +138,7 @@ 
             return self::ALREADY_PRESENT;
         }
         $ret = $auth->activatePendingUser($user);
-        if($ret === false)
+        if ($ret === false)
         {
             throw new \Exception('Unable to create user! '.$res);
         }

Braces +1 added lines, -2 removed lines

@@ -34,8 +34,7 @@
             $args['RawMessage'] = array();
             $args['RawMessage']['Data'] = base64_encode($email->getRawMessage());
             return $this->ses->sendRawEmail($args);
-        }
-        else
+        } else
         {
             $args = array();
             $args['Source'] = $email->getFromAddress();

Auth/OAuth2/class.GitLabAuthenticator.php

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
 
     public function getUserFromToken($token)
     {
-        if($token === false)
+        if ($token === false)
         {
             $token = \FlipSession::getVar('OAuthToken');
         }