Completed
Pull Request — master (#125)
by Patrick
03:52 queued 01:31
created
Auth/LDAPCachableObject.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
      *
44 44
      * @param string $fieldName The name of the field to retrieve
45 45
      *
46
-     * @return mixed string the value of the field
46
+     * @return string string the value of the field
47 47
      */
48 48
     protected function getFieldSingleValue($fieldName)
49 49
     {
Please login to merge, or discard this patch.
Auth/User.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -311,7 +311,7 @@
 block discarded – undo
311 311
      *
312 312
      * @param stdClass $data The user's new data
313 313
      *
314
-     * @return boolean true if the user's data was changed, false otherwise
314
+     * @return boolean|null true if the user's data was changed, false otherwise
315 315
      */
316 316
     public function editUser($data)
317 317
     {
Please login to merge, or discard this patch.
AuthProvider.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -253,10 +253,10 @@
 block discarded – undo
253 253
      * Get an array of Auth\PendingUser from a filtered set
254 254
      *
255 255
      * @param Data\Filter|boolean $filter The filter conditions or false to retreive all
256
-     * @param array|boolean $select The user fields to obtain or false to obtain all
257
-     * @param integer|boolean $top The number of users to obtain or false to obtain all
258
-     * @param integer|boolean $skip The number of users to skip or false to skip none
259
-     * @param array|boolean $orderby The field to sort by and the method to sort or false to not sort
256
+     * @param boolean $select The user fields to obtain or false to obtain all
257
+     * @param boolean $top The number of users to obtain or false to obtain all
258
+     * @param boolean $skip The number of users to skip or false to skip none
259
+     * @param boolean $orderby The field to sort by and the method to sort or false to not sort
260 260
      * @param string|boolean $methodName The AuthMethod if information is desired only from a particular Auth\Authenticator
261 261
      *
262 262
      * @return array|boolean An array of Auth\PendingUser objects or false if no pending users were found
Please login to merge, or discard this patch.
Data/FilterClause.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -176,7 +176,7 @@
 block discarded – undo
176 176
      * Convert the right hand side of the filter clause into an Mongo array
177 177
      *
178 178
      * @param string $op The standard operator
179
-     * @param string $var The second variable in the operator
179
+     * @param string $var2 The second variable in the operator
180 180
      *
181 181
      * @return array An array of mongo operations
182 182
      */
Please login to merge, or discard this patch.
Switch Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -265,18 +265,18 @@
 block discarded – undo
265 265
         }
266 266
         switch($this->op)
267 267
         {
268
-        case '!=':
269
-            return $value != $this->var2;
270
-        case '=':
271
-            return $value == $this->var2;
272
-        case '<':
273
-            return $value < $this->var2;
274
-        case '<=':
275
-            return $value <= $this->var2;
276
-        case '>':
277
-            return $value > $this->var2;
278
-        case '>=':
279
-            return $value >= $this->var2;
268
+            case '!=':
269
+                return $value != $this->var2;
270
+            case '=':
271
+                return $value == $this->var2;
272
+            case '<':
273
+                return $value < $this->var2;
274
+            case '<=':
275
+                return $value <= $this->var2;
276
+            case '>':
277
+                return $value > $this->var2;
278
+            case '>=':
279
+                return $value >= $this->var2;
280 280
         }
281 281
     }
282 282
 }
Please login to merge, or discard this patch.
Data/SQLDataSet.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -150,7 +150,7 @@
 block discarded – undo
150 150
      * @param string $select The colums to read
151 151
      * @param boolean|string $count The number of rows to read
152 152
      * @param boolean|string $skip The number of rows to skip over
153
-     * @param boolean|array $sort The array to sort by or false to not sort
153
+     * @param boolean $sort The array to sort by or false to not sort
154 154
      *
155 155
      * @return false|array An array of all the returned records
156 156
      */
Please login to merge, or discard this patch.
FlipsideCAPTCHA.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -108,6 +108,9 @@  discard block
 block discarded – undo
108 108
         $this->wwwUrl = $settings->getGlobalSetting('www_url', 'https://www.burningflipside.com');
109 109
     }
110 110
 
111
+    /**
112
+     * @param string $fieldName
113
+     */
111 114
     protected function getCaptchField($fieldName)
112 115
     {
113 116
         $dataset = DataSetFactory::getDataSetByName('profiles');
@@ -130,6 +133,9 @@  discard block
 block discarded – undo
130 133
         return $this->getCaptchField('hint');
131 134
     }
132 135
 
136
+    /**
137
+     * @return string
138
+     */
133 139
     private function get_answer()
134 140
     {
135 141
         return $this->getCaptchField('answer');
Please login to merge, or discard this patch.
Http/FlipAdminPage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -11,6 +11,9 @@
 block discarded – undo
11 11
         $this->setTemplateName('admin.html');
12 12
     }
13 13
 
14
+    /**
15
+     * @param string $adminGroup
16
+     */
14 17
     protected function userIsAdmin($adminGroup)
15 18
     {
16 19
         if($this->user === false || $this->user === null)
Please login to merge, or discard this patch.
Http/Rest/DataTableAPI.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
     /**
16 16
      * Create the DataTableAPI for the given DataTable info
17 17
      *
18
-     * @param string $datSetName The name of the DataSet used in the Settings
18
+     * @param string $dataSetName The name of the DataSet used in the Settings
19 19
      * @param string $dataTableName The name of the table in the DataSet
20 20
      * @param string|false $primaryKeyName The table primary key. Must be specified for update/delete capable tables
21 21
      */
Please login to merge, or discard this patch.
Http/Rest/SerializationMiddleware.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -24,6 +24,9 @@
 block discarded – undo
24 24
         }
25 25
     }
26 26
 
27
+    /**
28
+     * @param string $param
29
+     */
27 30
     private function getParamFromArrayIfSet($array, $param, $default = null)
28 31
     {
29 32
         if(isset($array[$param]))
Please login to merge, or discard this patch.