LDAPSettableObject::setCachedOnlyProp() - Code Metrics - Inspection of "Reduce complexity of LDAPUser" - BurningFlipside/CommonCode - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d18140...e77a87 )

by Patrick

created 2016-07-06 18:12 UTC

LDAPSettableObject::setCachedOnlyProp() A

↳ Parent: LDAPSettableObject

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	7
c	1
b	0
f	0
nc	3
nop	2
dl	0
loc	13
rs	9.4285

<?php
namespace Auth;

trait LDAPSettableObject
{
    protected function setCachedOnlyProp($propName, $value)
    {
        if(in_array($propName, $this->cachedOnlyProps))
class MyClass { }

$x = new MyClass();
$x->foo = true;
        {
            if(!is_object($this->ldapObj))
class MyClass { }

$x = new MyClass();
$x->foo = true;
            {
                $this->setFieldLocal($propName, $value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                return true;
            }
            throw new \Exception('Unsupported!');
        }
        return false;
    }

    protected function setMultiValueProp($propName, $value)
    {
        if(in_array($propName, $this->multiValueProps) && !is_array($value))
class MyClass { }

$x = new MyClass();
$x->foo = true;
        {
             $this->setField($propName, array($value));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
             return true;
        }
        return false;
    }

    public function __set($propName, $value)
    {
        if($this->setCachedOnlyProp($propName, $value) === true)
        {
            return;
        }
        if($this->setMultiValueProp($propName, $value) === true)
        {
            return;
        }
        $this->setField($propName, $value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}

/* vim: set tabstop=4 shiftwidth=4 expandtab: */


1			<?php
2			namespace Auth;
3
4			trait LDAPSettableObject
5			{
6			protected function setCachedOnlyProp($propName, $value)
7			{
8			if(in_array($propName, $this->cachedOnlyProps))
			0 ignored issues – show Bug introduced 2016-07-06 18:15 UTC by Report Bug Copy Issue Report The property `cachedOnlyProps` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
9			{
10			if(!is_object($this->ldapObj))
			0 ignored issues – show Bug introduced 2016-07-06 18:15 UTC by Report Bug Copy Issue Report The property `ldapObj` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
11			{
12			$this->setFieldLocal($propName, $value);
			0 ignored issues – show Bug introduced 2016-07-06 18:15 UTC by Report Bug Copy Issue Report It seems like `setFieldLocal()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
13			return true;
14			}
15			throw new \Exception('Unsupported!');
16			}
17			return false;
18			}
19
20			protected function setMultiValueProp($propName, $value)
21			{
22			if(in_array($propName, $this->multiValueProps) && !is_array($value))
			0 ignored issues – show Bug introduced 2016-07-06 18:15 UTC by Report Bug Copy Issue Report The property `multiValueProps` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
23			{
24			$this->setField($propName, array($value));
			0 ignored issues – show Bug introduced 2016-07-06 18:15 UTC by Report Bug Copy Issue Report It seems like `setField()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25			return true;
26			}
27			return false;
28			}
29
30			public function __set($propName, $value)
31			{
32			if($this->setCachedOnlyProp($propName, $value) === true)
33			{
34			return;
35			}
36			if($this->setMultiValueProp($propName, $value) === true)
37			{
38			return;
39			}
40			$this->setField($propName, $value);
			0 ignored issues – show Bug introduced 2016-07-06 18:15 UTC by Report Bug Copy Issue Report It seems like `setField()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
41			}
42			}
43
44			/* vim: set tabstop=4 shiftwidth=4 expandtab: */
45

BurningFlipside / CommonCode

Push — master ( d18140...e77a87 )

LDAPSettableObject::setCachedOnlyProp() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like