SerializationMiddleware::__invoke() - Code Metrics - Inspection of "Merge pull request #52 from BurningFlipside/develo..." - BurningFlipside/CommonCode - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ab2960...44d5ac )

by Patrick

created 2017-06-14 18:00 UTC

SerializationMiddleware::__invoke() D

↳ Parent: SerializationMiddleware

Complexity

Conditions	17
Paths	17

Size

Total Lines	35
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	17
eloc	29
nc	17
nop	3
dl	0
loc	35
rs	4.9807
c	0
b	0
f	0

How to fix Complexity

<?php
namespace Http\Rest;

use \Psr\Http\Message\ServerRequestInterface as Request;
use \Psr\Http\Message\ResponseInterface as Response;

require 'vendor/autoload.php';

class SerializationMiddleware
{
    protected $format = null;

    private function getFormatFromHeader($request)
    {
        $mimeType = $request->getHeader('Accept');
        switch($mimeType)
        {
            case 'text/csv':
                return 'csv';
            case 'text/x-vCard':
                return 'vcard';
            default:
                return 'json';
        }
    }

    private function getParamFromArrayIfSet($array, $param, $default = null)
    {
        if(isset($array[$param]))
        {
            return $array[$param];
        }
        return $default;
    }

    private function getFormat($request, $response)
    {
        $params = $request->getQueryParams();
        $this->format = $this->getParamFromArrayIfSet($params, 'fmt');
        if($this->format === null)
        {
            $this->format = $this->getParamFromArrayIfSet($params, '$format');
            if($this->format === null)
            {
                $this->format = $this->getFormatFromHeader($request);
            }
        }
        if(strstr($this->format, 'odata.streaming=true'))
        {
            return $response->withStatus(406);
        }
        return $response;
    }

    protected function reserializeBody($response, $serializer)
    {
        $body = $response->getBody();
        $body->rewind();
        $data = json_decode($body->getContents());
        $serializer = new $serializer();
        $res = $serializer->serializeData($this->format, $data);
        $response = $response->withBody(new \Slim\Http\Body(fopen('php://temp', 'r+')));
        $response->getBody()->write($res);
        return $response->withHeader('Content-Type', $this->format);
    }

    public function __invoke($request, $response, $next)
    {
        $response = $this->getFormat($request, $response);
        if($response->getStatusCode() !== 200)
        {
            return $response;
        }
        $response = $next($request, $response);
        switch($this->format)
        {
            case 'application/json':
            case 'application/x-javascript':
            case 'text/javascript':
            case 'text/x-javascript':
            case 'text/x-json':
            case 'json':
                return $response;
            case 'xml':
            case 'application/xml':
            case 'text/xml':
                return $this->reserializeBody($response, '\Serialize\XMLSerializer');
            case 'csv':
            case 'text/csv':
                return $this->reserializeBody($response, '\Serialize\CSVSerializer');
            case 'xlsx':
            case 'xls':
            case 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet':
            case 'application/vnd.ms-excel':
                return $this->reserializeBody($response, '\Serialize\ExcelSerializer');
            default:
                print_r($this->format); die();
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        }
        return $response;
    }
}


1			<?php
2			namespace Http\Rest;
3
4			use \Psr\Http\Message\ServerRequestInterface as Request;
5			use \Psr\Http\Message\ResponseInterface as Response;
6
7			require 'vendor/autoload.php';
8
9			class SerializationMiddleware
10			{
11			protected $format = null;
12
13			private function getFormatFromHeader($request)
14			{
15			$mimeType = $request->getHeader('Accept');
16			switch($mimeType)
17			{
18			case 'text/csv':
19			return 'csv';
20			case 'text/x-vCard':
21			return 'vcard';
22			default:
23			return 'json';
24			}
25			}
26
27			private function getParamFromArrayIfSet($array, $param, $default = null)
28			{
29			if(isset($array[$param]))
30			{
31			return $array[$param];
32			}
33			return $default;
34			}
35
36			private function getFormat($request, $response)
37			{
38			$params = $request->getQueryParams();
39			$this->format = $this->getParamFromArrayIfSet($params, 'fmt');
40			if($this->format === null)
41			{
42			$this->format = $this->getParamFromArrayIfSet($params, '$format');
43			if($this->format === null)
44			{
45			$this->format = $this->getFormatFromHeader($request);
46			}
47			}
48			if(strstr($this->format, 'odata.streaming=true'))
49			{
50			return $response->withStatus(406);
51			}
52			return $response;
53			}
54
55			protected function reserializeBody($response, $serializer)
56			{
57			$body = $response->getBody();
58			$body->rewind();
59			$data = json_decode($body->getContents());
60			$serializer = new $serializer();
61			$res = $serializer->serializeData($this->format, $data);
62			$response = $response->withBody(new \Slim\Http\Body(fopen('php://temp', 'r+')));
63			$response->getBody()->write($res);
64			return $response->withHeader('Content-Type', $this->format);
65			}
66
67			public function __invoke($request, $response, $next)
68			{
69			$response = $this->getFormat($request, $response);
70			if($response->getStatusCode() !== 200)
71			{
72			return $response;
73			}
74			$response = $next($request, $response);
75			switch($this->format)
76			{
77			case 'application/json':
78			case 'application/x-javascript':
79			case 'text/javascript':
80			case 'text/x-javascript':
81			case 'text/x-json':
82			case 'json':
83			return $response;
84			case 'xml':
85			case 'application/xml':
86			case 'text/xml':
87			return $this->reserializeBody($response, '\Serialize\XMLSerializer');
88			case 'csv':
89			case 'text/csv':
90			return $this->reserializeBody($response, '\Serialize\CSVSerializer');
91			case 'xlsx':
92			case 'xls':
93			case 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet':
94			case 'application/vnd.ms-excel':
95			return $this->reserializeBody($response, '\Serialize\ExcelSerializer');
96			default:
97			print_r($this->format); die();
98			break;
			0 ignored issues – show Unused Code introduced 2017-06-07 21:43 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
99			}
100			return $response;
101			}
102			}
103

BurningFlipside / CommonCode

Push — master ( ab2960...44d5ac )

SerializationMiddleware::__invoke() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like