FlipAdminPage::getContent() - Code Metrics - Inspection of "Switch to template based rendering" - BurningFlipside/CommonCode - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 40b8dd...0c2ef0 )

by Patrick

created 2018-06-08 16:41 UTC

FlipAdminPage::getContent() A

↳ Parent: FlipAdminPage

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	5
nc	2
nop	0
dl	0
loc	13
rs	9.4285
c	1
b	0
f	0

<?php
namespace Http;
class FlipAdminPage extends LoginRequiredPage
{
    public $is_admin = false;

    public function __construct($title, $adminGroup = 'LDAPAdmins')
    {
        parent::__construct($title);
        $this->is_admin = $this->userIsAdmin($adminGroup);
        $this->setTemplateName('admin.html');
    }

    protected function userIsAdmin($adminGroup)

    {
        if($this->user === false || $this->user === null)
class MyClass { }

$x = new MyClass();
$x->foo = true;
        {
            return false;
        }
        return $this->user->isInGroupNamed($adminGroup);
    }

    public function isAdmin()
    {
        return $this->is_admin;
    }

    protected function getContent()
    {
        if($this->isAdmin() === false)
        {
            $this->body = '
        <div class="row">
            <div class="col-lg-12">
                <h1 class="page-header">The current user does not have access rights to the '.$this->content['pageTitle'].' Admin system!</h1>
class MyClass { }

$x = new MyClass();
$x->foo = true;
            </div>
        </div>';
        }
        return parent::getContent();
    }
}
/* vim: set tabstop=4 shiftwidth=4 expandtab: */


1		<?php
2		namespace Http;
3		class FlipAdminPage extends LoginRequiredPage
4		{
5		public $is_admin = false;
6
7		public function __construct($title, $adminGroup = 'LDAPAdmins')
8		{
9		parent::__construct($title);
10		$this->is_admin = $this->userIsAdmin($adminGroup);
11		$this->setTemplateName('admin.html');
12		}
13
14	View Code Duplication	protected function userIsAdmin($adminGroup)
		0 ignored issues – show Duplication introduced 2018-06-08 16:50 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
15		{
16		if($this->user === false \|\| $this->user === null)
		0 ignored issues – show Bug introduced 2018-06-08 16:50 UTC by Report Bug Copy Issue Report The property `user` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
17		{
18		return false;
19		}
20		return $this->user->isInGroupNamed($adminGroup);
21		}
22
23		public function isAdmin()
24		{
25		return $this->is_admin;
26		}
27
28		protected function getContent()
29		{
30		if($this->isAdmin() === false)
31		{
32		$this->body = '
33		<div class="row">
34		<div class="col-lg-12">
35		<h1 class="page-header">The current user does not have access rights to the '.$this->content['pageTitle'].' Admin system!</h1>
		0 ignored issues – show Bug introduced 2018-06-08 16:50 UTC by Report Bug Copy Issue Report The property `content` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
36		</div>
37		</div>';
38		}
39		return parent::getContent();
40		}
41		}
42		/* vim: set tabstop=4 shiftwidth=4 expandtab: */
43

BurningFlipside / CommonCode

Push — master ( 40b8dd...0c2ef0 )

FlipAdminPage::getContent() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like