Issues in class.LoginRequiredPage.php - New Issues - Inspection of "Moving to template based rendering for pages to ma..." - BurningFlipside/CommonCode - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#89)

by Patrick

created 2018-06-08 16:42 UTC

Http/class.LoginRequiredPage.php (4 issues)

Labels

Bug 4

Severity

Major 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Http;
/**
 * A WebPage class that requires login to view
 *
 * This file describes an abstraction for creating a webpage with JQuery, Bootstrap,
 * and other framework specific abilities that requires a login
 *
 * PHP version 5 and 7
 *
 * @author Patrick Boyd / [email protected]
 * @copyright Copyright (c) 2017, Austin Artistic Reconstruction
 * @license http://www.apache.org/licenses/ Apache 2.0 License
 */

/**
 * A webpage abstraction for login required pages
 *
 * This class adds a login requirement to FlipPage
 */
class LoginRequiredPage extends WebPage
{
    protected function getContent()
    {
        if($this->user === false || $this->user === null)
class MyClass { }

$x = new MyClass();
$x->foo = true;
        {
          $this->content['body'] = '
class MyClass { }

$x = new MyClass();
$x->foo = true;
            <div id="content">
              <div class="row">
                <div class="col-lg-12">
                  <h1 class="page-header">You must <a href="'.$this->loginUrl.'?return='.$this->currentUrl().'">log in <span class="fa fa-sign-in"></span></a> to access the '.$this->content['pageTitle'].' system!</h1>
class MyClass { }

$x = new MyClass();
$x->foo = true;
                </div>
              </div>
            </div>
          ';
        }
        else if(!isset($this->content['body']))
        {
          $this->content['body'] = $this->body;
        }
        return $this->twig->render($this->templateName, $this->content);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}
/* vim: set tabstop=4 shiftwidth=4 expandtab: */


1			<?php
2			namespace Http;
3			/**
4			* A WebPage class that requires login to view
5			*
6			* This file describes an abstraction for creating a webpage with JQuery, Bootstrap,
7			* and other framework specific abilities that requires a login
8			*
9			* PHP version 5 and 7
10			*
11			* @author Patrick Boyd / [email protected]
12			* @copyright Copyright (c) 2017, Austin Artistic Reconstruction
13			* @license http://www.apache.org/licenses/ Apache 2.0 License
14			*/
15
16			/**
17			* A webpage abstraction for login required pages
18			*
19			* This class adds a login requirement to FlipPage
20			*/
21			class LoginRequiredPage extends WebPage
22			{
23			protected function getContent()
24			{
25			if($this->user === false \|\| $this->user === null)
			0 ignored issues – show Bug introduced 2018-06-08 16:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `user` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26			{
27			$this->content['body'] = '
			0 ignored issues – show Bug introduced 2018-06-08 16:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `content` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
28			<div id="content">
29			<div class="row">
30			<div class="col-lg-12">
31			<h1 class="page-header">You must <a href="'.$this->loginUrl.'?return='.$this->currentUrl().'">log in <span class="fa fa-sign-in"></span></a> to access the '.$this->content['pageTitle'].' system!</h1>
			0 ignored issues – show Bug introduced 2018-06-08 16:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `loginUrl` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
32			</div>
33			</div>
34			</div>
35			';
36			}
37			else if(!isset($this->content['body']))
38			{
39			$this->content['body'] = $this->body;
40			}
41			return $this->twig->render($this->templateName, $this->content);
			0 ignored issues – show Bug introduced 2018-06-08 16:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `twig` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
42			}
43			}
44			/* vim: set tabstop=4 shiftwidth=4 expandtab: */
45

BurningFlipside / CommonCode

Pull Request — develop (#89)

Http/class.LoginRequiredPage.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like