Data\SQLDataSet

Complexity

Total Complexity

45

Size/Duplication

Total Lines	216
Duplicated Lines	41.67 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	1

12 Methods

Rating	Name	Duplication	Size	Complexity
A	_get_row_count_for_query()	0	15	3
A	_tableExistsNoPrefix()	12	12	3
A	_tableExists()	12	12	3
A	_viewExists()	12	12	3
A	tableExists()	0	16	4
A	getTable()	0	16	4
C	read()	0	44	11
A	update()	21	21	4
B	create()	22	22	4
A	raw_query()	0	10	2
A	delete()	0	9	2
A	__construct()	11	11	2

<?php
namespace Data;

class SQLDataSet extends DataSet
{
    protected $pdo;

    function __construct($params)

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        if(isset($params['user']))
        {
            $this->pdo = new \PDO($params['dsn'], $params['user'], $params['pass']);
        }
        else
        {
            $this->pdo = new \PDO($params['dsn']);
        }
    }

    function _get_row_count_for_query($sql)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $stmt = $this->pdo->query($sql);
        if($stmt === false)
        {
            return 0;
        }
        $count = $stmt->rowCount();
        if($count === 0)
        {
            $array = $stmt->fetchAll();
            $count = count($array);
        }
        return $count;
    }

    function _tableExistsNoPrefix($name)

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        if($this->_get_row_count_for_query('SHOW TABLES LIKE '.$this->pdo->quote($name)) > 0)
        {
            return true;
        }
        else if($this->_get_row_count_for_query('SELECT * FROM sqlite_master WHERE name LIKE '.$this->pdo->quote($name)) > 0)
        {
            return true;
        }
        return false;
    }

    function _tableExists($name)

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        if($this->_get_row_count_for_query('SHOW TABLES LIKE '.$this->pdo->quote('tbl'.$name)) > 0)
        {
            return true;
        }
        else if($this->_get_row_count_for_query('SELECT * FROM sqlite_master WHERE name LIKE '.$this->pdo->quote('tbl'.$name)) > 0)
        {
            return true;
        }
        return false;
    }

    function _viewExists($name)

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        if($this->_get_row_count_for_query('SHOW TABLES LIKE '.$this->pdo->quote('v'.$name)) > 0)
        {
            return true;
        }
        else if($this->_get_row_count_for_query('SELECT * FROM sqlite_master WHERE name LIKE '.$this->pdo->quote('v'.$name)) > 0)
        {
            return true;
        }
        return false;
    }

    function tableExists($name)

It is generally recommended to explicitly declare the visibility for methods.

    {
        if($this->_tableExists($name))
        {
            return true;
        }
        if($this->_tableExistsNoPrefix($name))
        {
            return true;
        }
        if($this->_viewExists($name))
        {
            return true;
        }
        return false;
    }

    function getTable($name)

It is generally recommended to explicitly declare the visibility for methods.

    {
        if($this->_tableExists($name))
        {
            return new SQLDataTable($this, 'tbl'.$name);
        }
        if($this->_viewExists($name))
        {
            return new SQLDataTable($this, 'v'.$name);
        }
        if($this->_tableExistsNoPrefix($name))
        {
            return new SQLDataTable($this, $name);
        }
        throw new \Exception('No such table '.$name);
    }

    function read($tablename, $where=false, $select='*', $count=false, $skip=false, $sort=false)

It is generally recommended to explicitly declare the visibility for methods.

    {
        if($select === false)
        {
            $select = '*';
        }
        $sql = "SELECT $select FROM $tablename";
        if($where !== false)
        {
            $sql.=' WHERE '.$where;
        }
        if($count !== false)
        {
            if($skip === false)
            {
                $sql.=' LIMIT '.(int)$count;
            }
            else
            {
                $sql.=" LIMIT $skip, $count";
            }
        }
        if($sort !== false)
        {
            $sql.=' ORDER BY ';
            $tmp = array();
            foreach($sort as $sort_col=>$dir)

The expression $sort of type boolean is not traversable.

            {
                array_push($tmp, $sort_col.' '.($dir === 1?'ASC':'DESC'));
            }
            $sql.=implode($tmp,',');
        }
        $stmt = $this->pdo->query($sql, \PDO::FETCH_ASSOC);
        if($stmt === false)
        {
            return false;
        }
        $ret = $stmt->fetchAll();
        if($ret === false || empty($ret))
        {
            return false;
        }
        return $ret;
    }

    function update($tablename, $where, $data)

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        $set = array();
        if(is_object($data))
        {
            $data = (array)$data;
        }
        $cols = array_keys($data);
        $count = count($cols);
        for($i = 0; $i < $count; $i++)
        {
            array_push($set, $cols[$i].'='.$this->pdo->quote($data[$cols[$i]]));
        }
        $set = implode(',', $set);
        $sql = "UPDATE $tablename SET $set WHERE $where";
        if($this->pdo->exec($sql) === false)
        {
            return false;
        }
        return true;
    }

    function create($tablename, $data)

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        $set = array();
        if(is_object($data))
        {
            $data = (array)$data;
        }
        $cols = array_keys($data);
        $count = count($cols);
        for($i = 0; $i < $count; $i++)
        {
            array_push($set, $this->pdo->quote($data[$cols[$i]]));
        }
        $cols = implode(',', $cols);
        $set = implode(',', $set);
        $sql = "INSERT INTO $tablename ($cols) VALUES ($set);";
        if($this->pdo->exec($sql) === false)
        {
            return false;
        }
        return true;
    }

    function delete($tablename, $where)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $sql = "DELETE FROM $tablename WHERE $where";
        if($this->pdo->exec($sql) === false)
        {
            return false;
        }
        return true;
    }

    function raw_query($sql)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $stmt = $this->pdo->query($sql, \PDO::FETCH_ASSOC);
        if($stmt === false)
        {
            return false;
        }
        $ret = $stmt->fetchAll();
        return $ret;
    }
}
?>

It is not recommended to use PHP's closing tag ?> in files other than templates.