ExcelSerializer - Code Metrics - Inspection of "Add Excel Serializer" - BurningFlipside/CommonCode - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d887f9...fd888a )

by Patrick

created 2016-06-05 19:31 UTC

ExcelSerializer A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
dl	0
loc	48
rs	10
c	1
b	0
f	1
wmc	8
lcom	0
cbo	1

1 Method

Rating	Name	Duplication	Size	Complexity
C	serializeData()	0	43	8

<?php
namespace Serialize;

require_once dirname(__FILE__) . '/../libs/PHPExcel/Classes/PHPExcel.php';

class ExcelSerializer extends SpreadSheetSerializer
{
    protected $types = array('xlsx', 'xls', 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet', 'application/vnd.ms-excel');

    public function serializeData($type, $array)
    {
        if($this->supportsType($type) === false)
        {
            return null;
        }
        if(count($array) === 0)
        {
            return null;
        }
        $data = $this->getArray($array);
        $ssheat = new \PHPExcel();
        $sheat = $ssheat->setActiveSheetIndex(0);
        $keys = array_shift($data);
        $rowCount = count($data);
        $colCount = count($keys);
        for($i = 0; $i < $colCount; $i++)
        {
            $sheat->setCellValueByColumnAndRow($i, 1, $keys[$i]);
        }
        for($i = 0; $i < $rowCount; $i++)
        {
            for($j = 0; $j < $colCount; $j++)
            {
                $colName = $keys[$j];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $sheat->setCellValueByColumnAndRow($j, 2+$i, $data[$i][$j]);
            }
        }
        if(strcasecmp($type, 'xlsx') === 0 || strcasecmp($type, 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet') === 0)
        {
            $writer = \PHPExcel_IOFactory::createWriter($ssheat, 'Excel2007');
            ob_start();
            $writer->save('php://output');
            return ob_get_clean();
        }
        else
        {
            $writer = \PHPExcel_IOFactory::createWriter($ssheat, 'Excel5');
            ob_start();
            $writer->save('php://output');
            return ob_get_clean();
        }
    }
}
?>



1			<?php
2			namespace Serialize;
3
4			require_once dirname(__FILE__) . '/../libs/PHPExcel/Classes/PHPExcel.php';
5
6			class ExcelSerializer extends SpreadSheetSerializer
7			{
8			protected $types = array('xlsx', 'xls', 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet', 'application/vnd.ms-excel');
9
10			public function serializeData($type, $array)
11			{
12			if($this->supportsType($type) === false)
13			{
14			return null;
15			}
16			if(count($array) === 0)
17			{
18			return null;
19			}
20			$data = $this->getArray($array);
21			$ssheat = new \PHPExcel();
22			$sheat = $ssheat->setActiveSheetIndex(0);
23			$keys = array_shift($data);
24			$rowCount = count($data);
25			$colCount = count($keys);
26			for($i = 0; $i < $colCount; $i++)
27			{
28			$sheat->setCellValueByColumnAndRow($i, 1, $keys[$i]);
29			}
30			for($i = 0; $i < $rowCount; $i++)
31			{
32			for($j = 0; $j < $colCount; $j++)
33			{
34			$colName = $keys[$j];
			0 ignored issues – show Unused Code introduced 2016-06-05 19:34 UTC by Report Bug Copy Issue Report `$colName` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
35			$sheat->setCellValueByColumnAndRow($j, 2+$i, $data[$i][$j]);
36			}
37			}
38			if(strcasecmp($type, 'xlsx') === 0 \|\| strcasecmp($type, 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet') === 0)
39			{
40			$writer = \PHPExcel_IOFactory::createWriter($ssheat, 'Excel2007');
41			ob_start();
42			$writer->save('php://output');
43			return ob_get_clean();
44			}
45			else
46			{
47			$writer = \PHPExcel_IOFactory::createWriter($ssheat, 'Excel5');
48			ob_start();
49			$writer->save('php://output');
50			return ob_get_clean();
51			}
52			}
53			}
54			?>
			0 ignored issues – show Best Practice introduced 2016-06-05 19:34 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
55

BurningFlipside / CommonCode

Push — master ( d887f9...fd888a )

ExcelSerializer A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like