Issues in class.FlipsideAuthenticator.php - New Issues - Inspection of "Fix errors in filterArrayPerSelect" - BurningFlipside/CommonCode - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#48)

by Patrick

created 2017-06-03 03:32 UTC

Auth/OAuth2/class.FlipsideAuthenticator.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Auth\OAuth2;

class FlipsideAuthenticator extends OAuth2Authenticator
{
    private $apiUrl = 'https://profiles.burningflipside.com/api/v1';
    private $oauthUrl = 'https://profiles.burningflipside.com/OAUTH2';

    public function __construct($params)
    {
        parent::__construct($params);
        if(isset($params['api_url']))
        {
            $this->apiUrl = $params['api_url'];
        }
        if(isset($params['oauth_url']))
        {
            $this->oauthUrl = $params['oauth_url'];
        }
    }

    public function getHostName()
    {
        return 'burningflipside.com';
    }

    public function getAuthorizationUrl()
    {
        return $this->oauthUrl.'/authorize.php?client_id=test&redirect_uri='.urlencode($this->redirect_uri).'&scope=user';
    }

    public function getAccessTokenUrl()
    {
        return $this->oauthUrl.'/token.php?client_id=test&redirect_uri='.urlencode($this->redirect_uri);
    }

    public function getUserFromToken($token)
    {
        if($token === false)
        {
            $token = \FlipSession::getVar('OAuthToken');
        }
        $resp = \Httpful\Request::get($this->apiUrl.'/users/me')->addHeader('Authorization', 'token '.$token['access_token'])->send();
        $data = array('extended'=>$resp->body);
        $user = new \Auth\FlipsideAPIUser($data);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $user->addLoginProvider($this->getHostName());
        return $user;
    }

    public function login($username, $password)
    {
        $resp = \Httpful\Request::post($this->apiUrl.'/login?username='.urlencode($username).'&password='.urlencode($password))->send();
        if($resp->hasErrors())
        {
            return false;
        }
        $this->user = $resp->body->extended;
        $this->user->userPassword = $password;
        return array('res'=>true, 'extended'=>$this->user);
    }

    public function isLoggedIn($data)
    {
        if(isset($this->user))
        {
            return true;
        }
        if(isset($data['res']))
        {
            return $data['res'];
        }
        return false;
    }

    public function getUser($data)
    {
        return new \Auth\FlipsideAPIUser($data, $this->apiUrl);
    }
}


1			<?php
2			namespace Auth\OAuth2;
3
4			class FlipsideAuthenticator extends OAuth2Authenticator
5			{
6			private $apiUrl = 'https://profiles.burningflipside.com/api/v1';
7			private $oauthUrl = 'https://profiles.burningflipside.com/OAUTH2';
8
9			public function __construct($params)
10			{
11			parent::__construct($params);
12			if(isset($params['api_url']))
13			{
14			$this->apiUrl = $params['api_url'];
15			}
16			if(isset($params['oauth_url']))
17			{
18			$this->oauthUrl = $params['oauth_url'];
19			}
20			}
21
22			public function getHostName()
23			{
24			return 'burningflipside.com';
25			}
26
27			public function getAuthorizationUrl()
28			{
29			return $this->oauthUrl.'/authorize.php?client_id=test&redirect_uri='.urlencode($this->redirect_uri).'&scope=user';
30			}
31
32			public function getAccessTokenUrl()
33			{
34			return $this->oauthUrl.'/token.php?client_id=test&redirect_uri='.urlencode($this->redirect_uri);
35			}
36
37			public function getUserFromToken($token)
38			{
39			if($token === false)
40			{
41			$token = \FlipSession::getVar('OAuthToken');
42			}
43			$resp = \Httpful\Request::get($this->apiUrl.'/users/me')->addHeader('Authorization', 'token '.$token['access_token'])->send();
44			$data = array('extended'=>$resp->body);
45			$user = new \Auth\FlipsideAPIUser($data);
			0 ignored issues – show Documentation introduced 2017-02-10 00:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$data` is of type `array<string,array\|strin..."array\|string\|object"}>`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
46			$user->addLoginProvider($this->getHostName());
47			return $user;
48			}
49
50			public function login($username, $password)
51			{
52			$resp = \Httpful\Request::post($this->apiUrl.'/login?username='.urlencode($username).'&password='.urlencode($password))->send();
53			if($resp->hasErrors())
54			{
55			return false;
56			}
57			$this->user = $resp->body->extended;
58			$this->user->userPassword = $password;
59			return array('res'=>true, 'extended'=>$this->user);
60			}
61
62			public function isLoggedIn($data)
63			{
64			if(isset($this->user))
65			{
66			return true;
67			}
68			if(isset($data['res']))
69			{
70			return $data['res'];
71			}
72			return false;
73			}
74
75			public function getUser($data)
76			{
77			return new \Auth\FlipsideAPIUser($data, $this->apiUrl);
78			}
79			}
80

BurningFlipside / CommonCode

Pull Request — develop (#48)

Auth/OAuth2/class.FlipsideAuthenticator.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like