Completed
Push — develop ( 6b358f...19e70a )
by Patrick
08:59 queued 05:47
created

XMLSerializer   A

Complexity

Total Complexity 5

Size/Duplication

Total Lines 27
Duplicated Lines 40.74 %

Coupling/Cohesion

Components 1
Dependencies 1

Importance

Changes 1
Bugs 0 Features 0
Metric Value
c 1
b 0
f 0
dl 11
loc 27
rs 10
wmc 5
lcom 1
cbo 1

2 Methods

Rating   Name   Duplication   Size   Complexity  
A supportsType() 11 11 3
A serializeData() 0 10 2

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
namespace Serialize;
3
4
class XMLSerializer implements ISerializer
5
{
6
    private $types = array('xml', 'application/xml', 'text/xml');
7
8 View Code Duplication
    public function supportsType($type)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
9
    {
10
        foreach($this->types as $t)
11
        {
12
            if(strcasecmp($t, $type) === 0)
13
            {
14
                return true;
15
            }
16
        }
17
        return false;
18
    }
19
20
    public function serializeData(&$type, $array)
21
    {
22
        if($this->supportsType($type) === false)
23
        {
24
            return null;
25
        }
26
        $obj = new \SerializableObject($array);
27
        $type = 'text/xml';
28
        return $obj->xmlSerialize();
29
    }
30
}
31