ExcelSerializer::serializeData() - Code Metrics - Inspection of "Prod" - BurningFlipside/CommonCode - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#109)

by Patrick

created 2019-05-02 20:26 UTC

ExcelSerializer::serializeData() A

↳ Parent: ExcelSerializer

Complexity

Conditions	5
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
nc	5
nop	2
dl	0
loc	33
rs	9.0808
c	0
b	0
f	0

<?php
namespace Serialize;
require_once dirname(__FILE__).'/../vendor/autoload.php';

use PhpOffice\PhpSpreadsheet\Spreadsheet;
use PhpOffice\PhpSpreadsheet\Writer\Xlsx;
use PhpOffice\PhpSpreadsheet\Writer\Xls;

class ExcelSerializer extends SpreadSheetSerializer
{
    protected $types = array('xlsx', 'xls', 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet', 'application/vnd.ms-excel');

    protected function setRowFromArray(&$sheat, $row, $array, $count = 0)
    {
        if($count === 0)
        {
            $count = count($array);
        }
        for($i = 0; $i < $count; $i++)

        {
            if(isset($array[$i]))
            {
                $sheat->setCellValueByColumnAndRow($i+1, $row, $array[$i]);
            }
        }
    }

    public function serializeData(&$type, $array)
    {
        if($this->supportsType($type) === false)
        {
            return null;
        }
        $data = $this->getArray($array);
        $ssheat = new Spreadsheet();
        $sheat = $ssheat->getActiveSheet();
        $keys = array_shift($data);
        $rowCount = count($data);
        $colCount = count($keys);
        $this->setRowFromArray($sheat, 1, $keys, $colCount);
        for($i = 0; $i < $rowCount; $i++)
        {
            $this->setRowFromArray($sheat, (2 + $i), $data[$i], $colCount);
        }
        $writerType = 'Excel5';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if(strcasecmp($type, 'xlsx') === 0 || strcasecmp($type, 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet') === 0)
        {
            $writer = new Xlsx($ssheat);
            $writerType = 'Excel2007';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $type = 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet';
        }
        else
        {
            $writer = new Xls($ssheat);
            $type = 'application/vnd.ms-excel';
        }
        ob_start();
        $writer->save('php://output');
        return ob_get_clean();
    }
}


1		<?php
2		namespace Serialize;
3		require_once dirname(__FILE__).'/../vendor/autoload.php';
4
5		use PhpOffice\PhpSpreadsheet\Spreadsheet;
6		use PhpOffice\PhpSpreadsheet\Writer\Xlsx;
7		use PhpOffice\PhpSpreadsheet\Writer\Xls;
8
9		class ExcelSerializer extends SpreadSheetSerializer
10		{
11		protected $types = array('xlsx', 'xls', 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet', 'application/vnd.ms-excel');
12
13		protected function setRowFromArray(&$sheat, $row, $array, $count = 0)
14		{
15		if($count === 0)
16		{
17		$count = count($array);
18		}
19	View Code Duplication	for($i = 0; $i < $count; $i++)
		0 ignored issues – show Duplication introduced 2018-02-16 16:23 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
20		{
21		if(isset($array[$i]))
22		{
23		$sheat->setCellValueByColumnAndRow($i+1, $row, $array[$i]);
24		}
25		}
26		}
27
28		public function serializeData(&$type, $array)
29		{
30		if($this->supportsType($type) === false)
31		{
32		return null;
33		}
34		$data = $this->getArray($array);
35		$ssheat = new Spreadsheet();
36		$sheat = $ssheat->getActiveSheet();
37		$keys = array_shift($data);
38		$rowCount = count($data);
39		$colCount = count($keys);
40		$this->setRowFromArray($sheat, 1, $keys, $colCount);
41		for($i = 0; $i < $rowCount; $i++)
42		{
43		$this->setRowFromArray($sheat, (2 + $i), $data[$i], $colCount);
44		}
45		$writerType = 'Excel5';
		0 ignored issues – show Unused Code introduced 2019-02-06 00:57 UTC by Report Bug Copy Issue Report `$writerType` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
46		if(strcasecmp($type, 'xlsx') === 0 \|\| strcasecmp($type, 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet') === 0)
47		{
48		$writer = new Xlsx($ssheat);
49		$writerType = 'Excel2007';
		0 ignored issues – show Unused Code introduced 2019-02-06 00:57 UTC by Report Bug Copy Issue Report `$writerType` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
50		$type = 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet';
51		}
52		else
53		{
54		$writer = new Xls($ssheat);
55		$type = 'application/vnd.ms-excel';
56		}
57		ob_start();
58		$writer->save('php://output');
59		return ob_get_clean();
60		}
61		}
62

BurningFlipside / CommonCode

Pull Request — master (#109)

ExcelSerializer::serializeData() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like