Completed
Push — develop ( 10136e...e84b09 )
by Patrick
05:41 queued 02:40
created

Serialize/class.XMLSerializer.php (1 issue)

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
namespace Serialize;
3
4
class XMLSerializer implements ISerializer
5
{
6
    private $types = array('xml', 'application/xml', 'text/xml');
7
8 View Code Duplication
    public function supportsType(&$type)
9
    {
10
        foreach($this->types as $t)
11
        {
12
            if(strcasecmp($t, $type) === 0)
13
            {
14
                return true;
15
            }
16
        }
17
        return false;
18
    }
19
20
    public function serializeData($type, $array)
21
    {
22
        if($this->supportsType($type) === false)
23
        {
24
            return null;
25
        }
26
        $obj = new \SerializableObject($array);
27
        $type = 'text/xml';
0 ignored issues
show
$type is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
28
        return $obj->xmlSerialize();
29
    }
30
}
31