SQLDataSet::_viewExists() - Code Metrics - Inspection of "Merge branch 'errorInODataFilter'" - BurningFlipside/CommonCode - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1814f6...b13845 )

by Patrick

created 2017-06-03 03:37 UTC

SQLDataSet::_viewExists() A

↳ Parent: SQLDataSet

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php
namespace Data;

class SQLDataSet extends DataSet
{
    protected $pdo;

    /**
     * Create a new SQLDataSet
     *
     * @param array $params An array containing atleast 'dsn' and possibly 'user' and 'pass'
     */
    public function __construct($params)

    {
        if(isset($params['user']))
        {
            $this->pdo = new \PDO($params['dsn'], $params['user'], $params['pass']);
        }
        else
        {
            $this->pdo = new \PDO($params['dsn']);
        }
    }

    /**
     * Get the number of rows affected by the query
     *
     * @param string $sql The SQL string
     *
     * @return integer The number of rows affected by the query
     */
    private function _get_row_count_for_query($sql)
    {
        $stmt = $this->pdo->query($sql);
        if($stmt === false)
        {
            return 0;
        }
        $count = $stmt->rowCount();
        if($count === 0)
        {
            $array = $stmt->fetchAll();
            $count = count($array);
        }
        return $count;
    }

    private function _tableExistsNoPrefix($name)
    {
        if($this->_get_row_count_for_query('SHOW TABLES LIKE '.$this->pdo->quote($name)) > 0)
        {
            return true;
        }
        else if($this->_get_row_count_for_query('SELECT * FROM sqlite_master WHERE name LIKE '.$this->pdo->quote($name)) > 0)
        {
            return true;
        }
        return false;
    }

    private function _tableExists($name)
    {
        return $this->_tableExistsNoPrefix('tbl'.$name);
    }

    private function _viewExists($name)
    {
        return $this->_tableExistsNoPrefix('v'.$name);
    }

    public function tableExists($name)
    {
        if($this->_tableExists($name))
        {
            return true;
        }
        if($this->_tableExistsNoPrefix($name))
        {
            return true;
        }
        if($this->_viewExists($name))
        {
            return true;
        }
        return false;
    }

    public function getTable($name)
    {
        if($this->_tableExists($name))
        {
            return new SQLDataTable($this, 'tbl'.$name);
        }
        if($this->_viewExists($name))
        {
            return new SQLDataTable($this, 'v'.$name);
        }
        if($this->_tableExistsNoPrefix($name))
        {
            return new SQLDataTable($this, $name);
        }
        throw new \Exception('No such table '.$name);
    }

    /**
     * @param boolean|array $sort The array to sort by or false to not sort
     */
    private function getOrderByClause($sort)
    {
        if(empty($sort))
        {
            return false;
        }
        $sql = ' ORDER BY ';
        $tmp = array();
        foreach($sort as $sort_col=>$dir)
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
        {
            array_push($tmp, $sort_col.' '.($dir === 1 ? 'ASC' : 'DESC'));
        }
        $sql .= implode($tmp, ',');
        return $sql;
    }

    /**
     * Convert OData style $count and $skip into SQL LIMIT
     *
     * @param boolean|string $count The number of items to return
     * @param boolean|string $skip The number of items to skip
     */
    private function getLimitClause($count, $skip)
    {
        if($count === false)
        {
            return false;
        }
        $count = intval($count);
        if($skip !== false)
        {
            $skip = intval($count);
            return " LIMIT $skip, $count";
        }
        return ' LIMIT '.$count;
    }

    /**
     * Read data from the specified SQL table
     *
     * @param string $tablename The name of the table to read from
     * @param boolean|string $where The where caluse of the SQL statement
     * @param string $select The colums to read
     * @param boolean|string $count The number of rows to read
     * @param boolean|string $skip The number of rows to skip over
     * @param boolean|array $sort The array to sort by or false to not sort
     *
     * @return false|array An array of all the returned records
     */
    public function read($tablename, $where = false, $select = '*', $count = false, $skip = false, $sort = false)
    {
        if($select === false)
        {
            $select = '*';
        }
        $sql = "SELECT $select FROM $tablename";
        if($where !== false)
        {
            $sql .= ' WHERE '.$where;
        }
        $tmp = $this->getLimitClause($count, $skip);
        if($tmp !== false)
        {
            $sql .= $tmp;
        }
        $tmp = $this->getOrderByClause($sort);
        if($tmp !== false)
        {
            $sql .= $tmp;
        }
        $stmt = $this->pdo->query($sql, \PDO::FETCH_ASSOC);
        if($stmt === false)
        {
            return false;
        }
        $ret = $stmt->fetchAll();
        if(empty($ret))
        {
            return false;
        }
        return $ret;
    }

    /**
     * Perform an SQL update on the specified table
     *
     * @param string $tablename The name of the table to insert to
     * @param string $where The where clause in SQL format
     * @param mixed $data The data to write to the table
     *
     * @return boolean true if successful, false otherwise
     */
    public function update($tablename, $where, $data)
    {
        $set = array();
        if(is_object($data))
        {
            $data = (array)$data;
        }
        $cols = array_keys($data);
        $count = count($cols);
        for($i = 0; $i < $count; $i++)
        {
            array_push($set, $cols[$i].'='.$this->pdo->quote($data[$cols[$i]]));
        }
        $set = implode(',', $set);
        $sql = "UPDATE $tablename SET $set WHERE $where";
        if($this->pdo->exec($sql) === false)
        {
            return false;
        }
        return true;
    }

    /**
     * Perform an SQL insert on the specified table
     *
     * @param string $tablename The name of the table to insert to
     * @param mixed $data The data to write to the table
     *
     * @return boolean true if successful, false otherwise
     */
    public function create($tablename, $data)
    {
        $set = array();
        if(is_object($data))
        {
            $data = (array)$data;
        }
        $cols = array_keys($data);
        $count = count($cols);
        for($i = 0; $i < $count; $i++)
        {
            if($data[$cols[$i]] === null)
            {
                array_push($set, 'NULL');
            }
            else
            {
                array_push($set, $this->pdo->quote($data[$cols[$i]]));
            }
        }
        $cols = implode(',', $cols);
        $set = implode(',', $set);
        $sql = "INSERT INTO $tablename ($cols) VALUES ($set);";
        if($this->pdo->exec($sql) === false)
        {
            //error_log($sql);
            return false;
        }
        return true;
    }

    /**
     * Perform an SQL delete on the specified table
     *
     * @param string $tablename The name of the table to insert to
     * @param string $where The where clause in SQL format
     *
     * @return boolean true if successful, false otherwise
     */
    public function delete($tablename, $where)
    {
        $sql = "DELETE FROM $tablename WHERE $where";
        if($this->pdo->exec($sql) === false)
        {
            return false;
        }
        return true;
    }

    /**
     * Perform an SQL query
     *
     * @param string $sql The raw SQL
     *
     * @return mixed false on a failure, an array of data otherwise
     */
    public function raw_query($sql)
    {
        $stmt = $this->pdo->query($sql, \PDO::FETCH_ASSOC);
        if($stmt === false)
        {
            return false;
        }
        $ret = $stmt->fetchAll();
        return $ret;
    }

    public function getLastError()
    {
        return $this->pdo->errorInfo();
    }
}
/* vim: set tabstop=4 shiftwidth=4 expandtab: */


1			<?php
2			namespace Data;
3
4			class SQLDataSet extends DataSet
5			{
6			protected $pdo;
7
8			/**
9			* Create a new SQLDataSet
10			*
11			* @param array $params An array containing atleast 'dsn' and possibly 'user' and 'pass'
12			*/
13			public function __construct($params)
			0 ignored issues – show Duplication introduced 2016-05-13 19:31 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14			{
15			if(isset($params['user']))
16			{
17			$this->pdo = new \PDO($params['dsn'], $params['user'], $params['pass']);
18			}
19			else
20			{
21			$this->pdo = new \PDO($params['dsn']);
22			}
23			}
24
25			/**
26			* Get the number of rows affected by the query
27			*
28			* @param string $sql The SQL string
29			*
30			* @return integer The number of rows affected by the query
31			*/
32			private function _get_row_count_for_query($sql)
33			{
34			$stmt = $this->pdo->query($sql);
35			if($stmt === false)
36			{
37			return 0;
38			}
39			$count = $stmt->rowCount();
40			if($count === 0)
41			{
42			$array = $stmt->fetchAll();
43			$count = count($array);
44			}
45			return $count;
46			}
47
48			private function _tableExistsNoPrefix($name)
49			{
50			if($this->_get_row_count_for_query('SHOW TABLES LIKE '.$this->pdo->quote($name)) > 0)
51			{
52			return true;
53			}
54			else if($this->_get_row_count_for_query('SELECT * FROM sqlite_master WHERE name LIKE '.$this->pdo->quote($name)) > 0)
55			{
56			return true;
57			}
58			return false;
59			}
60
61			private function _tableExists($name)
62			{
63			return $this->_tableExistsNoPrefix('tbl'.$name);
64			}
65
66			private function _viewExists($name)
67			{
68			return $this->_tableExistsNoPrefix('v'.$name);
69			}
70
71			public function tableExists($name)
72			{
73			if($this->_tableExists($name))
74			{
75			return true;
76			}
77			if($this->_tableExistsNoPrefix($name))
78			{
79			return true;
80			}
81			if($this->_viewExists($name))
82			{
83			return true;
84			}
85			return false;
86			}
87
88			public function getTable($name)
89			{
90			if($this->_tableExists($name))
91			{
92			return new SQLDataTable($this, 'tbl'.$name);
93			}
94			if($this->_viewExists($name))
95			{
96			return new SQLDataTable($this, 'v'.$name);
97			}
98			if($this->_tableExistsNoPrefix($name))
99			{
100			return new SQLDataTable($this, $name);
101			}
102			throw new \Exception('No such table '.$name);
103			}
104
105			/**
106			* @param boolean\|array $sort The array to sort by or false to not sort
107			*/
108			private function getOrderByClause($sort)
109			{
110			if(empty($sort))
111			{
112			return false;
113			}
114			$sql = ' ORDER BY ';
115			$tmp = array();
116			foreach($sort as $sort_col=>$dir)
			0 ignored issues – show Bug introduced 2016-07-08 00:40 UTC by Report Bug Copy Issue Report The expression `$sort` of type `boolean\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
117			{
118			array_push($tmp, $sort_col.' '.($dir === 1 ? 'ASC' : 'DESC'));
119			}
120			$sql .= implode($tmp, ',');
121			return $sql;
122			}
123
124			/**
125			* Convert OData style $count and $skip into SQL LIMIT
126			*
127			* @param boolean\|string $count The number of items to return
128			* @param boolean\|string $skip The number of items to skip
129			*/
130			private function getLimitClause($count, $skip)
131			{
132			if($count === false)
133			{
134			return false;
135			}
136			$count = intval($count);
137			if($skip !== false)
138			{
139			$skip = intval($count);
140			return " LIMIT $skip, $count";
141			}
142			return ' LIMIT '.$count;
143			}
144
145			/**
146			* Read data from the specified SQL table
147			*
148			* @param string $tablename The name of the table to read from
149			* @param boolean\|string $where The where caluse of the SQL statement
150			* @param string $select The colums to read
151			* @param boolean\|string $count The number of rows to read
152			* @param boolean\|string $skip The number of rows to skip over
153			* @param boolean\|array $sort The array to sort by or false to not sort
154			*
155			* @return false\|array An array of all the returned records
156			*/
157			public function read($tablename, $where = false, $select = '*', $count = false, $skip = false, $sort = false)
158			{
159			if($select === false)
160			{
161			$select = '*';
162			}
163			$sql = "SELECT $select FROM $tablename";
164			if($where !== false)
165			{
166			$sql .= ' WHERE '.$where;
167			}
168			$tmp = $this->getLimitClause($count, $skip);
169			if($tmp !== false)
170			{
171			$sql .= $tmp;
172			}
173			$tmp = $this->getOrderByClause($sort);
174			if($tmp !== false)
175			{
176			$sql .= $tmp;
177			}
178			$stmt = $this->pdo->query($sql, \PDO::FETCH_ASSOC);
179			if($stmt === false)
180			{
181			return false;
182			}
183			$ret = $stmt->fetchAll();
184			if(empty($ret))
185			{
186			return false;
187			}
188			return $ret;
189			}
190
191			/**
192			* Perform an SQL update on the specified table
193			*
194			* @param string $tablename The name of the table to insert to
195			* @param string $where The where clause in SQL format
196			* @param mixed $data The data to write to the table
197			*
198			* @return boolean true if successful, false otherwise
199			*/
200			public function update($tablename, $where, $data)
201			{
202			$set = array();
203			if(is_object($data))
204			{
205			$data = (array)$data;
206			}
207			$cols = array_keys($data);
208			$count = count($cols);
209			for($i = 0; $i < $count; $i++)
210			{
211			array_push($set, $cols[$i].'='.$this->pdo->quote($data[$cols[$i]]));
212			}
213			$set = implode(',', $set);
214			$sql = "UPDATE $tablename SET $set WHERE $where";
215			if($this->pdo->exec($sql) === false)
216			{
217			return false;
218			}
219			return true;
220			}
221
222			/**
223			* Perform an SQL insert on the specified table
224			*
225			* @param string $tablename The name of the table to insert to
226			* @param mixed $data The data to write to the table
227			*
228			* @return boolean true if successful, false otherwise
229			*/
230			public function create($tablename, $data)
231			{
232			$set = array();
233			if(is_object($data))
234			{
235			$data = (array)$data;
236			}
237			$cols = array_keys($data);
238			$count = count($cols);
239			for($i = 0; $i < $count; $i++)
240			{
241			if($data[$cols[$i]] === null)
242			{
243			array_push($set, 'NULL');
244			}
245			else
246			{
247			array_push($set, $this->pdo->quote($data[$cols[$i]]));
248			}
249			}
250			$cols = implode(',', $cols);
251			$set = implode(',', $set);
252			$sql = "INSERT INTO $tablename ($cols) VALUES ($set);";
253			if($this->pdo->exec($sql) === false)
254			{
255			//error_log($sql);
256			return false;
257			}
258			return true;
259			}
260
261			/**
262			* Perform an SQL delete on the specified table
263			*
264			* @param string $tablename The name of the table to insert to
265			* @param string $where The where clause in SQL format
266			*
267			* @return boolean true if successful, false otherwise
268			*/
269			public function delete($tablename, $where)
270			{
271			$sql = "DELETE FROM $tablename WHERE $where";
272			if($this->pdo->exec($sql) === false)
273			{
274			return false;
275			}
276			return true;
277			}
278
279			/**
280			* Perform an SQL query
281			*
282			* @param string $sql The raw SQL
283			*
284			* @return mixed false on a failure, an array of data otherwise
285			*/
286			public function raw_query($sql)
287			{
288			$stmt = $this->pdo->query($sql, \PDO::FETCH_ASSOC);
289			if($stmt === false)
290			{
291			return false;
292			}
293			$ret = $stmt->fetchAll();
294			return $ret;
295			}
296
297			public function getLastError()
298			{
299			return $this->pdo->errorInfo();
300			}
301			}
302			/* vim: set tabstop=4 shiftwidth=4 expandtab: */
303

BurningFlipside / CommonCode

Push — master ( 1814f6...b13845 )

SQLDataSet::_viewExists() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like