ObjectDataTable::update() - Code Metrics - Inspection of "Merge branch 'errorInODataFilter'" - BurningFlipside/CommonCode - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1814f6...b13845 )

by Patrick

created 2017-06-03 03:37 UTC

ObjectDataTable::update() A

↳ Parent: ObjectDataTable

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	4
c	1
b	0
f	0
nc	2
nop	2
dl	0
loc	8
rs	9.4285

<?php
namespace Data;

class ObjectDataTable extends \Data\DataTable
{
    protected $dataTable;
    protected $className = 'SerializableObject';

    public static function getInstance()
    {
        static $instance = null;
        if(null === $instance)
        {
            $instance = new static();

        }
        return $instance;
    }

    protected function __construct($dataTable)
    {
        $this->dataTable = $dataTable;
    }

    public function create($data)
    {
        if(is_array($data))
        {
            $data = new $this->className($data);
        }
        if(method_exists($data, 'preCreate'))
        {
            $data = $data->preCreate();
        }
        return $this->dataTable->create($data);
    }

    public function read($filter=false, $select=false, $count=false, $skip=false, $sort=false, $params=false)
    {
        $res = $this->dataTable->read($filter, $select, $count, $skip, $sort, $params);
        if($res === false)
        {
            return false;
        }
        if(!is_array($res))
        {
            $res = array($res);
        }
        $objCount = count($res);
        for($i = 0; $i < $objCount; $i++)
        {
            $res[$i] = new $this->className($res[$i]);
        }
        return $res;
    }

    public function update($filter, $data)
    {
        if(method_exists($data, 'preUpdate'))
        {
            $data = $data->preUpdate();
        }
        return $this->dataTable->update($filter, $data);
    }

    public function delete($filter)
    {
        if(method_exists($data, 'preDelete'))
function someFunction() {
    $x = 5;
    echo $x;
}
        {
            $data = $data->preDelete();
function someFunction() {
    $x = 5;
    echo $x;
}
        }
        return $dataTable->delete($filter);

    }

    public function count($filter=false)
    {
        return parent::count($filter);
    }
}


1			<?php
2			namespace Data;
3
4			class ObjectDataTable extends \Data\DataTable
5			{
6			protected $dataTable;
7			protected $className = 'SerializableObject';
8
9			public static function getInstance()
10			{
11			static $instance = null;
12			if(null === $instance)
13			{
14			$instance = new static();
			0 ignored issues – show Bug introduced 2017-06-03 03:40 UTC by Report Bug Copy Issue Report The call to `ObjectDataTable::__construct()` misses a required argument `$dataTable`. This check looks for function calls that miss required arguments. Loading history...
15			}
16			return $instance;
17			}
18
19			protected function __construct($dataTable)
20			{
21			$this->dataTable = $dataTable;
22			}
23
24			public function create($data)
25			{
26			if(is_array($data))
27			{
28			$data = new $this->className($data);
29			}
30			if(method_exists($data, 'preCreate'))
31			{
32			$data = $data->preCreate();
33			}
34			return $this->dataTable->create($data);
35			}
36
37			public function read($filter=false, $select=false, $count=false, $skip=false, $sort=false, $params=false)
38			{
39			$res = $this->dataTable->read($filter, $select, $count, $skip, $sort, $params);
40			if($res === false)
41			{
42			return false;
43			}
44			if(!is_array($res))
45			{
46			$res = array($res);
47			}
48			$objCount = count($res);
49			for($i = 0; $i < $objCount; $i++)
50			{
51			$res[$i] = new $this->className($res[$i]);
52			}
53			return $res;
54			}
55
56			public function update($filter, $data)
57			{
58			if(method_exists($data, 'preUpdate'))
59			{
60			$data = $data->preUpdate();
61			}
62			return $this->dataTable->update($filter, $data);
63			}
64
65			public function delete($filter)
66			{
67			if(method_exists($data, 'preDelete'))
			0 ignored issues – show Bug introduced 2017-06-03 03:40 UTC by Report Bug Copy Issue Report The variable `$data` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
68			{
69			$data = $data->preDelete();
			0 ignored issues – show Bug introduced 2017-06-03 03:40 UTC by Report Bug Copy Issue Report The variable `$data` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history... Unused Code introduced 2017-06-03 03:40 UTC by Report Bug Copy Issue Report `$data` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
70			}
71			return $dataTable->delete($filter);
			0 ignored issues – show Bug introduced 2017-06-03 03:40 UTC by Report Bug Copy Issue Report The variable `$dataTable` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
72			}
73
74			public function count($filter=false)
75			{
76			return parent::count($filter);
77			}
78			}
79

BurningFlipside / CommonCode

Push — master ( 1814f6...b13845 )

ObjectDataTable::update() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like