Conditions | 10 |
Paths | 6 |
Total Lines | 37 |
Code Lines | 21 |
Lines | 0 |
Ratio | 0 % |
Changes | 2 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
36 | public function onPostSerialize(ObjectEvent $event) |
||
37 | { |
||
38 | $object = $this->getObject($event); |
||
39 | $objectUid = spl_object_hash($object); |
||
40 | |||
41 | if (in_array($objectUid, $this->postSerializedObjects, true)) { |
||
42 | return; |
||
43 | } |
||
44 | |||
45 | $classAnnotation = $this->annotationReader->getClassAnnotation( |
||
46 | new \ReflectionClass(ClassUtils::getClass($object)), |
||
47 | LiipImagineSerializableClass::class |
||
48 | ); |
||
49 | |||
50 | if ($classAnnotation instanceof LiipImagineSerializableClass) { |
||
51 | $reflectionClass = ClassUtils::newReflectionClass(get_class($object)); |
||
52 | |||
53 | foreach ($reflectionClass->getProperties() as $property) { |
||
54 | $liipAnnotation = $this->annotationReader->getPropertyAnnotation($property, LiipImagineSerializableField::class); |
||
55 | $property->setAccessible(true); |
||
56 | |||
57 | if ($liipAnnotation instanceof LiipImagineSerializableField && ($value = $property->getValue($object)) && ($virtualField = $liipAnnotation->getVirtualField())) { |
||
58 | if (array_key_exists('vichUploaderSerialize', $this->config) && $this->config['vichUploaderSerialize'] && $liipAnnotation->getVichUploaderField()) { |
||
59 | $valueArray = explode('/', $value); |
||
60 | $value = end($valueArray); |
||
61 | $property->setValue($object, $value); |
||
62 | } |
||
63 | |||
64 | /** @var GenericSerializationVisitor $visitor */ |
||
65 | $visitor = $event->getVisitor(); |
||
66 | $visitor->addData($virtualField, $this->serializeValue($liipAnnotation, $object, $value)); |
||
67 | } |
||
68 | } |
||
69 | |||
70 | $this->postSerializedObjects[$objectUid] = $objectUid; |
||
71 | } |
||
72 | } |
||
73 | } |
||
74 |