Conditions | 10 |
Paths | 6 |
Total Lines | 35 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php declare(strict_types = 1); |
||
29 | public function onPostSerialize(ObjectEvent $event): void |
||
30 | { |
||
31 | $object = $this->getObject($event); |
||
32 | |||
33 | $classAnnotation = $this->annotationReader->getClassAnnotation( |
||
34 | new \ReflectionClass(ClassUtils::getClass($object)), |
||
35 | LiipImagineSerializableClass::class |
||
36 | ); |
||
37 | |||
38 | if ($classAnnotation instanceof LiipImagineSerializableClass) { |
||
39 | $reflectionClass = ClassUtils::newReflectionClass(\get_class($object)); |
||
40 | |||
41 | foreach ($reflectionClass->getProperties() as $property) { |
||
42 | $liipAnnotation = $this->annotationReader->getPropertyAnnotation($property, LiipImagineSerializableField::class); |
||
43 | $property->setAccessible(true); |
||
44 | |||
45 | if ($liipAnnotation instanceof LiipImagineSerializableField) { |
||
46 | $value = $property->getValue($object); |
||
47 | $virtualField = $liipAnnotation->getVirtualField(); |
||
48 | |||
49 | if ($value && !\is_array($value) && $virtualField) { |
||
50 | if (\array_key_exists('vichUploaderSerialize', $this->config) && $this->config['vichUploaderSerialize'] && $liipAnnotation->getVichUploaderField()) { |
||
51 | $valueArray = \explode('/', $value); |
||
52 | $value = \end($valueArray); |
||
53 | $property->setValue($object, $value); |
||
54 | } |
||
55 | |||
56 | /** @var GenericSerializationVisitor $visitor */ |
||
57 | $visitor = $event->getVisitor(); |
||
58 | $visitor->setData($virtualField, $this->serializeValue($liipAnnotation, $object, $value)); |
||
59 | } |
||
60 | } |
||
61 | } |
||
62 | } |
||
63 | } |
||
64 | } |
||
65 |