BuildR\TestTools\DataSetLoader\XML\Parser\StandardXMLDefinitionParser

Complexity

Total Complexity

8

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setTestGroup()	0	3	1
A	getXPathQuery()	0	7	2
A	createTestArrayFromXmlElement()	0	14	3
A	parse()	0	9	2

<?php namespace BuildR\TestTools\DataSetLoader\XML\Parser;

use BuildR\TestTools\DataSetLoader\XML\Helper\SimpleXMLNodeTypedAttributeGetter;
use BuildR\TestTools\Exception\XMLDataSetParsingException;
use SimpleXMLElement;

class StandardXMLDefinitionParser implements XMLDefinitionParserInterface {

    private $groupName;

    public function setTestGroup($groupName) {
        $this->groupName = $groupName;
    }

    private function getXPathQuery() {
        if($this->groupName === NULL) {
            return '/testGroups/testGroup[1]';
        }

        return '/testGroups/testGroup[@name="' . $this->groupName . '"]';
    }

    private function createTestArrayFromXmlElement(SimpleXMLElement $element) {
        $result = [];

$result is not used, you could remove the assignment.

        $dataSets = $element->xpath('*');

        foreach($dataSets as $dataSet) {
            $values = [];

$values is not used, you could remove the assignment.

            $properties = $dataSet->xpath('*');

            foreach($properties as $property) {
                $typedGetter = new SimpleXMLNodeTypedAttributeGetter($property);
                die(var_dump($typedGetter->value));

var_dump($typedGetter->value); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

The method createTestArrayFromXmlElement() contains an exit expression.

            }
        }
    }

    public function parse(SimpleXMLElement $root) {
        $result = $root->xpath($this->getXPathQuery());
        
        if(empty($result)) {
            throw XMLDataSetParsingException::noResult($this->getXPathQuery());
        }

        return $this->createTestArrayFromXmlElement($result[0]);
    }
    
}