AbstractCollection - Code Metrics - Inspection of "*Removed array conversion from AbstractCollection:..." - BuildrPHP/Collection - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8cc10c...1afeda )

by Zoltán

created 2016-01-19 11:17 UTC

AbstractCollection A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	157
Duplicated Lines	9.55 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	23
c	2
b	0
f	0
lcom	1
cbo	1
dl	15
loc	157
ccs	38
cts	38
cp	1
rs	10

15 Methods

Rating	Name	Duplication	Size	Complexity
A	toArray()	0	3	1
A	clear()	0	3	1
A	contains()	0	3	2
A	containsAll()	15	15	3
A	containsAny()	0	11	3
A	equals()	0	11	2
A	isEmpty()	0	3	1
A	size()	0	3	2
A	current()	0	3	1
A	next()	0	3	1
A	key()	0	3	1
A	valid()	0	3	1
A	rewind()	0	3	1
A	count()	0	3	1
A	collectionToArray()	0	7	2

How to fix Duplicated Code

<?php namespace BuildR\Collection\Collection;

use BuildR\Collection\Interfaces\CollectionInterface;
use BuildR\Foundation\Object\ArrayConvertibleInterface;

/**
 * Abstract collection implementation
 *
 * BuildR PHP Framework
 *
 * @author Zoltán Borsos <[email protected]>
 * @package Collection
 * @subpackage Collection
 *
 * @copyright    Copyright 2015, Zoltán Borsos.
 * @license      https://github.com/Zolli/BuildR/blob/master/LICENSE.md
 * @link         https://github.com/Zolli/BuildR
 */
abstract class AbstractCollection implements CollectionInterface {

    /**
     * @type array
     */
    protected $data = [];

    /**
     * {@inheritdoc}
     */
    public function toArray() {
        return (array) $this->data;
    }

    /**
     * {@inheritdoc}
     */
    public function clear() {
        $this->data = [];
    }

    /**
     * {@inheritdoc}
     */
    public function contains($element) {
        return (array_search($element, $this->data, TRUE) === FALSE) ? FALSE : TRUE;
    }

    /**
     * {@inheritdoc}
     */
    public function containsAll($elements) {

        $elements = $this->collectionToArray($elements);

        $result = TRUE;

        foreach($elements as $item) {
            if($this->contains($item) === FALSE) {
                $result = FALSE;

                break;
            }
        }

        return $result;
    }

    /**
     * {@inheritdoc}
     */
    public function containsAny($elements) {
        $elements = $this->collectionToArray($elements);

        foreach($elements as $item) {
            if($this->contains($item) === TRUE) {
                return TRUE;
            }
        }

        return FALSE;
    }

    /**
     * {@inheritdoc}
     */
    public function equals(CollectionInterface $collection) {
        //First check the size, if this not equals the tow collection
        //not be identical
        if($collection->size() !== $this->size()) {
            return FALSE;
        }

        //Use strict comparison to check arrays are equals
        //(Values and orders)
        return $collection->toArray() === $this->data;
    }

    /**
     * {@inheritdoc}
     */
    public function isEmpty() {
        return empty($this->data);
    }

    /**
     * {@inheritdoc}
     */
    public function size() {
        return (is_array($this->data)) ? count($this->data) : 0;
    }

    /**
     * {@inheritdoc}
     *
     * @codeCoverageIgnore
     */
    public function current() {
        return $this->data[$this->position];
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * {@inheritdoc}
     *
     * @codeCoverageIgnore
     */
    public function next() {
        return next($this->data);
    }

    /**
     * {@inheritdoc}
     *
     * @codeCoverageIgnore
     */
    public function key() {
        return key($this->data);
    }

    /**
     * {@inheritdoc}
     *
     * @codeCoverageIgnore
     */
    public function valid() {
        return key($this->data) !== NULL;
    }

    /**
     * {@inheritdoc}
     *
     * @codeCoverageIgnore
     */
    public function rewind() {
        return reset($this->data);
    }

    /**
     * {@inheritdoc}
     */
    public function count() {
        return $this->size();
    }

    /**
     * @param array|\BuildR\Collection\Interfaces\CollectionInterface $elements
     *
     * @return array
     */
    protected function collectionToArray($elements) {
        if($elements instanceof CollectionInterface) {
            $elements = $elements->toArray();
        }

        return $elements;
    }

}


1			<?php namespace BuildR\Collection\Collection;
2
3			use BuildR\Collection\Interfaces\CollectionInterface;
4			use BuildR\Foundation\Object\ArrayConvertibleInterface;
5
6			/**
7			* Abstract collection implementation
8			*
9			* BuildR PHP Framework
10			*
11			* @author Zoltán Borsos <[email protected]>
12			* @package Collection
13			* @subpackage Collection
14			*
15			* @copyright Copyright 2015, Zoltán Borsos.
16			* @license https://github.com/Zolli/BuildR/blob/master/LICENSE.md
17			* @link https://github.com/Zolli/BuildR
18			*/
19			abstract class AbstractCollection implements CollectionInterface {
20
21			/**
22			* @type array
23			*/
24			protected $data = [];
25
26			/**
27			* {@inheritdoc}
28			*/
29	11		public function toArray() {
30	11		return (array) $this->data;
31			}
32
33			/**
34			* {@inheritdoc}
35			*/
36	1		public function clear() {
37	1		$this->data = [];
38	1		}
39
40			/**
41			* {@inheritdoc}
42			*/
43	23		public function contains($element) {
44	23		return (array_search($element, $this->data, TRUE) === FALSE) ? FALSE : TRUE;
45			}
46
47			/**
48			* {@inheritdoc}
49			*/
50	10	View Code Duplication	public function containsAll($elements) {
			0 ignored issues – show Duplication introduced 2016-01-19 10:08 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51	10		$elements = $this->collectionToArray($elements);
52
53	10		$result = TRUE;
54
55	10		foreach($elements as $item) {
56	10		if($this->contains($item) === FALSE) {
57	5		$result = FALSE;
58
59	5		break;
60			}
61	10		}
62
63	10		return $result;
64			}
65
66			/**
67			* {@inheritdoc}
68			*/
69	6		public function containsAny($elements) {
70	6		$elements = $this->collectionToArray($elements);
71
72	6		foreach($elements as $item) {
73	6		if($this->contains($item) === TRUE) {
74	5		return TRUE;
75			}
76	6		}
77
78	6		return FALSE;
79			}
80
81			/**
82			* {@inheritdoc}
83			*/
84	6		public function equals(CollectionInterface $collection) {
85			//First check the size, if this not equals the tow collection
86			//not be identical
87	6		if($collection->size() !== $this->size()) {
88	1		return FALSE;
89			}
90
91			//Use strict comparison to check arrays are equals
92			//(Values and orders)
93	5		return $collection->toArray() === $this->data;
94			}
95
96			/**
97			* {@inheritdoc}
98			*/
99	1		public function isEmpty() {
100	1		return empty($this->data);
101			}
102
103			/**
104			* {@inheritdoc}
105			*/
106	14		public function size() {
107	14		return (is_array($this->data)) ? count($this->data) : 0;
108			}
109
110			/**
111			* {@inheritdoc}
112			*
113			* @codeCoverageIgnore
114			*/
115			public function current() {
116			return $this->data[$this->position];
			0 ignored issues – show Bug introduced 2016-01-19 10:08 UTC by Report Bug Copy Issue Report The property `position` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
117			}
118
119			/**
120			* {@inheritdoc}
121			*
122			* @codeCoverageIgnore
123			*/
124			public function next() {
125			return next($this->data);
126			}
127
128			/**
129			* {@inheritdoc}
130			*
131			* @codeCoverageIgnore
132			*/
133			public function key() {
134			return key($this->data);
135			}
136
137			/**
138			* {@inheritdoc}
139			*
140			* @codeCoverageIgnore
141			*/
142			public function valid() {
143			return key($this->data) !== NULL;
144			}
145
146			/**
147			* {@inheritdoc}
148			*
149			* @codeCoverageIgnore
150			*/
151			public function rewind() {
152			return reset($this->data);
153			}
154
155			/**
156			* {@inheritdoc}
157			*/
158	8		public function count() {
159	8		return $this->size();
160			}
161
162			/**
163			* @param array\|\BuildR\Collection\Interfaces\CollectionInterface $elements
164			*
165			* @return array
166			*/
167	21		protected function collectionToArray($elements) {
168	21		if($elements instanceof CollectionInterface) {
169	1		$elements = $elements->toArray();
170	1		}
171
172	21		return $elements;
173			}
174
175			}
176

BuildrPHP / Collection

Push — master ( 8cc10c...1afeda )

AbstractCollection A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

15 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like