Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php namespace BuildR\ClassLoader\Modules\PEAR; |
||
20 | View Code Duplication | class PEARModuleException extends Exception { |
|
|
|||
21 | |||
22 | const MESSAGE_PREFIX_OCCUPIED = 'This prefix (%s) is already occupied!'; |
||
23 | |||
24 | /** |
||
25 | * Creates a new instance of this exception when is thrown when trying to register |
||
26 | * the same prefix twice into loader |
||
27 | * |
||
28 | * @param string $prefix The registered prefix |
||
29 | * |
||
30 | * @return static |
||
31 | */ |
||
32 | public static function prefixOccupied($prefix) { |
||
35 | |||
36 | /** |
||
37 | * @inheritDoc |
||
38 | */ |
||
39 | public function __construct($message = "", $code = 0, Exception $previous = NULL) { |
||
42 | |||
43 | } |
||
44 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.