Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php namespace BuildR\ClassLoader\Modules\Map; |
||
20 | View Code Duplication | class MapModuleException extends Exception { |
|
|
|||
21 | |||
22 | const MESSAGE_MAP_NAME_OCCUPIED = "The following map name is already occupied: %s"; |
||
23 | |||
24 | /** |
||
25 | * Used when try to register map with name that already registered in the loader |
||
26 | * |
||
27 | * @param string $mapName The map name |
||
28 | * |
||
29 | * @return static |
||
30 | */ |
||
31 | public static function mapNameOccupied($mapName) { |
||
34 | |||
35 | /** |
||
36 | * @inheritDoc |
||
37 | */ |
||
38 | public function __construct($message = "", $code = 0, Exception $previous = NULL) { |
||
41 | |||
42 | } |
||
43 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.