Issues in BooleanVo.php (main) - Issues in main - BruceGitHub/minimal-vo - Measure and Improve Code Quality continuously with Scrutinizer

Issues (13)

src/BaseValueObject/BooleanVo.php (1 issue)

Labels

Best Practice 1
Bug 1

Severity

Major 1

<?php

declare(strict_types=1);

namespace MinimalVo\BaseValueObject;

use MinimalVo\FactoryTrait\BooleanVoFactoryTrait;

/**
* @template-extends AbstractVo<bool,BooleanVo>
*/
final class BooleanVo extends AbstractVo
{
    use BooleanVoFactoryTrait;

    public function equal($vo): bool
    {
        return $this->value === $vo->toValue();
    }

    public function duplicate()
    {
        return new self($this->value);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    protected function valid(): bool
    {
        return is_bool($this->value);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace MinimalVo\BaseValueObject;
6
7			use MinimalVo\FactoryTrait\BooleanVoFactoryTrait;
8
9			/**
10			* @template-extends AbstractVo<bool,BooleanVo>
11			*/
12			final class BooleanVo extends AbstractVo
13			{
14			use BooleanVoFactoryTrait;
15
16			public function equal($vo): bool
17			{
18			return $this->value === $vo->toValue();
19			}
20
21			public function duplicate()
22			{
23			return new self($this->value);
			0 ignored issues – show Bug Best Practice introduced 2022-04-06 20:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return new self($this->value)` returns the type `MinimalVo\BaseValueObject\BooleanVo` which is incompatible with the return type mandated by `MinimalVo\BaseValueObjec...tInterface::duplicate()` of `MinimalVo\BaseValueObject\TVo`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
24			}
25
26			protected function valid(): bool
27			{
28			return is_bool($this->value);
29			}
30			}
31

BruceGitHub / minimal-vo

Issues (13)

src/BaseValueObject/BooleanVo.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like