App\Controller\ProviderController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	getResultUrls()	0	26	7

<?php

namespace App\Controller;

use App\Enum\PropertyType;
use App\Enum\Provider;
use App\Exception\UrlBuilderNotFoundException;
use App\Factory\ProviderUrlFactory;
use App\Formatter\DecimalFormatter;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Routing\Annotation\Route;

#[Route("/provider")]
class ProviderController extends AbstractController
{
    #[Route("/result-urls", name: "provider_result_urls", options: ["expose" => true], methods: ["GET"])]
    public function getResultUrls(
        Request $request,
        ProviderUrlFactory $urlFactory,
        DecimalFormatter $formatter
    ): JsonResponse {
        $params = $request->query->all();
        $city = $params['city'];
        $types = isset($params['types']) ? array_keys($params['types']) : PropertyType::getAvailableValues();
        $minPrice = isset($params['min_price']) ? $formatter->parse($params['min_price']) : null;
        $maxPrice = $formatter->parse($params['max_price']);
        $minArea = isset($params['min_area']) ? $formatter->parse($params['min_area']) : null;
        $maxArea = isset($params['max_area']) ? $formatter->parse($params['max_area']) : null;
        $minRoomsCount = $params['min_rooms_count'];
        $urls = [];

        foreach (Provider::getAvailableValues() as $providerName) {
            try {
                $urls[] = $urlFactory->create($providerName, $city, $types, $minPrice, $maxPrice, $minArea, $maxArea, $minRoomsCount);

It seems like $minArea can also be of type double; however, parameter $minArea of App\Factory\ProviderUrlFactory::create() does only seem to accept integer|null, maybe add an additional type check?

$maxPrice of type double is incompatible with the type integer expected by parameter $maxPrice of App\Factory\ProviderUrlFactory::create().

It seems like $maxArea can also be of type double; however, parameter $maxArea of App\Factory\ProviderUrlFactory::create() does only seem to accept integer|null, maybe add an additional type check?

It seems like $minPrice can also be of type double; however, parameter $minPrice of App\Factory\ProviderUrlFactory::create() does only seem to accept integer|null, maybe add an additional type check?

            // TODO: process ParuVendu
            } catch (UrlBuilderNotFoundException) {
                continue;
            }
        }

        return $this->json($urls);
    }
}