App\Parser\SuperimmoParser

Complexity

Total Complexity

1

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	parsePhoto()	0	6	1

<?php

namespace App\Parser;

use App\Enum\Provider;
use Symfony\Component\DomCrawler\Crawler;

/**
 * Note: some newsletters start with an advertising, uncatchable for the moment (2020-04-12)
 */
class SuperimmoParser extends AbstractParser
{
    protected const PROVIDER = Provider::SUPERIMMO;

    protected const SELECTOR_AD_WRAPPER  = 'td[style="width: 540px;"]';
    protected const SELECTOR_LOCATION    = 'table:nth-child(2) tr:nth-child(2) span';
    protected const SELECTOR_TITLE       = 'table:nth-child(2) tr:nth-child(1) span';
    protected const SELECTOR_DESCRIPTION = 'span[style="font-size: 14px;color:#282828;"]'; // Not a structuring property because of a possible "à partir de" row before

    /**
     * {@inheritDoc}
     */
    protected function parsePhoto(Crawler $crawler): ?string
    {
        $photo = parent::parsePhoto($crawler);
        $photo = substr($photo, strpos($photo, '#'));

It seems like $photo can also be of type null; however, parameter $haystack of strpos() does only seem to accept string, maybe add an additional type check?

It seems like $photo can also be of type null; however, parameter $string of substr() does only seem to accept string, maybe add an additional type check?

        return str_replace('wide', 'biggest', $photo);
    }
}