build.cogs.databasecog.DatabaseCog.db_update_spots_old() - Code Metrics - Inspection of "Update databasecog.py" - BonHowi/discordPogmareBot - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — BonHowi (5fc634)

by Bartosz

created 2021-09-13 19:46 UTC

DatabaseCog.db_update_spots_old() A

↳ Parent: build.cogs.databasecog

Complexity

Conditions

Size

Total Lines	38
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	34
dl	0
loc	38
rs	9.064
c	0
b	0
f	0
cc	3
nop	2

from discord.ext import commands, tasks
from discord_slash import cog_ext
from modules.get_settings import get_settings
from sqlalchemy import create_engine, Table, Column, Integer, String, MetaData, ForeignKey, \
    BigInteger, update, select, DateTime, delete
from sqlalchemy.dialects.mysql import insert
import cogs.cogbase as cogbase
from datetime import datetime
import pandas as pd

metadata_obj = MetaData()
member = Table('member', metadata_obj,
               Column('id', BigInteger, primary_key=True),
               Column('name', String(50), nullable=False),
               Column('display_name', String(50), nullable=False)
               )
fk_member_id = "member.id"

spots = Table('spots', metadata_obj,
              Column('member_id', BigInteger, ForeignKey(fk_member_id), primary_key=True),
              Column('legendary', Integer, default=0),
              Column('rare', Integer, default=0),
              Column('common', Integer, default=0),
              Column('event1', Integer, default=0),
              Column('event2', Integer, default=0)
              )

spots_temp = Table('spots_temp', metadata_obj,
                   Column('member_id', BigInteger, ForeignKey(fk_member_id), primary_key=True),
                   Column('legendary', Integer, default=0),
                   Column('rare', Integer, default=0),
                   Column('common', Integer, default=0),
                   Column('event1', Integer, default=0),
                   Column('event2', Integer, default=0)
                   )

warn = Table('warn', metadata_obj,
             Column('id', Integer, primary_key=True),
             Column('member_id', BigInteger, ForeignKey(fk_member_id)),
             Column('reason', String(120), nullable=False),
             Column('date', DateTime, nullable=False),
             )

coords = Table('coords', metadata_obj,
               Column('id', Integer, primary_key=True),
               Column('coords', String(100), nullable=False),
               Column('monster_type', String(20), nullable=False)
               )


# noinspection PyPropertyAccess
class DatabaseCog(cogbase.BaseCog):
    user = get_settings("DB_U")
    password = get_settings("DB_P")
    engine = create_engine(f"mysql+mysqldb://{user}:{password}@localhost/server_database?charset=utf8mb4")
    metadata_obj.create_all(engine)
    conn = None

    def __init__(self, base):
        super().__init__(base)

        # Connect to database
        self.engine = DatabaseCog.engine
        metadata_obj.create_all(self.engine)
        self.db_update_loop.start()
        self.conn = DatabaseCog.conn

    # ----- BASE DATABASE OPERATIONS -----

    # Add or update member in member table
    def db_add_update_member(self, _member):
        self.conn = self.engine.connect()
        stmt = insert(member).values(
            id=_member.id, name=_member.name,
            display_name=_member.display_name)
        do_update_stmt = stmt.on_duplicate_key_update(
            name=stmt.inserted.name, display_name=stmt.inserted.display_name
        )
        self.conn.execute(do_update_stmt)
        self.conn.close()

    # Add or update spots in spots table
    def db_add_update_spots(self, spots_table, guild_member):
        self.conn = self.engine.connect()
        stmt = insert(spots_table).values(
            member_id=guild_member.id)
        do_update_stmt = stmt.on_duplicate_key_update(member_id=stmt.inserted.member_id)
        self.conn.execute(do_update_stmt)
        self.conn.close()

    # Add or refresh all guild members and spots to database
    async def db_update(self):
        self.conn = self.engine.connect()
        guild = self.bot.get_guild(self.bot.guild[0])
        dt_string = self.bot.get_current_time()
        print(f"({dt_string})\t[{self.__class__.__name__}]: Refreshing member and spots tables")
        for guild_member in guild.members:
            # Member tables
            self.db_add_update_member(guild_member)
            # Spots tables
            self.db_add_update_spots(spots, guild_member)
            self.db_add_update_spots(spots_temp, guild_member)
        dt_string = self.bot.get_current_time()
        print(f"({dt_string})\t[{self.__class__.__name__}]: Member and spots tables refreshed")
        self.conn.close()

    @tasks.loop(hours=12)
    async def db_update_loop(self):
        await self.db_update()

    @db_update_loop.before_loop
    async def before_db_update_loop(self):
        dt_string = self.bot.get_current_time()
        print(f'({dt_string})\t[{self.__class__.__name__}]: Waiting until Bot is ready')
        await self.bot.wait_until_ready()

    # Add member to database on member join
    @commands.Cog.listener()
    async def on_member_join(self, _member):
        self.db_add_update_member(_member)
        self.db_add_update_spots(spots, _member)
        self.db_add_update_spots(spots_temp, _member)

    # Command for loading data from previous bot
    @cog_ext.cog_slash(name="updateSpotsWithOld", guild_ids=cogbase.GUILD_IDS,
                       description="Change N-Word channel name",
                       permissions=cogbase.PERMISSION_ADMINS)
    async def db_update_spots_old(self, ctx):
        self.conn = self.engine.connect()
        import json
        with open('server_files/old_base_test.json', 'r', encoding='utf-8-sig') as fp:
            old_db = json.load(fp)

        for mem_id in old_db:
            stmt = select(spots.c.member_id, spots.c.legendary, spots.c.rare, spots.c.common).where(
                spots.c.member_id == mem_id)
            result = self.conn.execute(stmt).fetchall()
            result = result[0]
            counter_lege = result[1]
            counter_rare = result[2]
            counter_common = result[3]

            stmt = insert(spots).values(
                member_id=mem_id, legendary=old_db[mem_id]["type_1"],
                rare=old_db[mem_id]["type_0"])
            do_update_stmt = stmt.on_duplicate_key_update(legendary=stmt.inserted.legendary + counter_lege,
                                                          rare=stmt.inserted.rare + counter_rare,
                                                          common=stmt.inserted.common + counter_common)
            self.conn.execute(do_update_stmt)

            stmt = insert(spots_temp).values(
                member_id=mem_id, legendary=old_db[mem_id]["type_1"],
                rare=old_db[mem_id]["type_0"])
            do_update_stmt = stmt.on_duplicate_key_update(legendary=stmt.inserted.legendary + counter_lege,
                                                          rare=stmt.inserted.rare + counter_rare,
                                                          common=stmt.inserted.common + counter_common)
            self.conn.execute(do_update_stmt)

        await ctx.send(f"Spot tables updated with old data", delete_after=3.0)
        dt_string = self.bot.get_current_time()
        print(f'({dt_string})\t[{self.__class__.__name__}]: Spot tables updated with old data')
        self.conn.close()

    # ----- SPOTTING OPERATIONS -----

    # Update spots tables
    @classmethod
    async def db_count_spot(cls, _id: int, monster_type: str):
        cls.conn = cls.engine.connect()
        # Get member nr of spots for certain monster type
        stmt = select(spots.c.member_id, spots.c.legendary, spots.c.rare, spots.c.common, spots.c.event1,
                      spots.c.event2).where(
            spots.c.member_id == _id)
        result = cls.conn.execute(stmt)
        counter = []
        for nr_of_kills in result.columns(monster_type):
            counter = nr_of_kills[0]
        stmt = update(spots).where(spots.c.member_id == _id).values({f"{monster_type}": counter + 1})
        cls.conn.execute(stmt)

        stmt = select(spots_temp.c.member_id, spots_temp.c.legendary, spots_temp.c.rare, spots_temp.c.common,
                      spots.c.event1,
                      spots.c.event2).where(
            spots_temp.c.member_id == _id)
        result = cls.conn.execute(stmt)
        for nr_of_kills in result.columns(monster_type):
            counter = nr_of_kills[0]
        stmt = update(spots_temp).where(spots_temp.c.member_id == _id).values({f"{monster_type}": counter + 1})
        cls.conn.execute(stmt)
        cls.conn.close()

    # Save coords from spotting channels to database
    @classmethod
    async def db_save_coords(cls, _coords: str, _monster_type):
        cls.conn = cls.engine.connect()
        stmt = insert(coords).values(coords=_coords, monster_type=_monster_type)
        cls.conn.execute(stmt)
        cls.conn.close()

    # Clear data from spots_temp table(for events etc)
    @classmethod
    async def db_clear_spots_temp_table(cls):
        cls.conn = cls.engine.connect()
        stmt = delete(spots_temp)
        cls.conn.execute(stmt)
        cls.conn.close()

    # ----- LEADERBOARD OPERATIONS -----

    # Return all members' spots
    @classmethod
    async def db_get_spots_df(cls):
        cls.conn = cls.engine.connect()
        stmt = select(spots.c.member_id, member.c.display_name, spots.c.legendary, spots.c.rare,
                      spots.c.common, spots.c.event1, spots.c.event2
                      ).select_from(member
                                    ).join(spots, member.c.id == spots.c.member_id)
        cls.conn.execute(stmt)
        df = pd.read_sql(stmt, cls.conn)
        cls.conn.close()
        return df

    # ----- WARN OPERATIONS -----

    # Add member's warn to database
    @classmethod
    async def db_add_warn(cls, _member: int, _reason: str):
        cls.conn = cls.engine.connect()
        stmt = insert(warn).values(member_id=_member, reason=_reason, date=datetime.now())
        cls.conn.execute(stmt)
        cls.conn.close()

    # Get member's warns from database
    @classmethod
    async def db_get_warns(cls, _member: int):
        cls.conn = cls.engine.connect()
        stmt = select(warn.c.reason, warn.c.date).select_from(member).join(warn, member.c.id == warn.c.member_id).where(
            member.c.id == _member)
        result = cls.conn.execute(stmt)
        date_warn = []
        counter = 0
        for warns in result.columns("reason", "date"):
            reason_with_date = [warns[1], warns[0]]
            date_warn.append(reason_with_date)
            counter += 1
        warns_list = [': \t'.join([str(elem) for elem in sublist]) for sublist in date_warn]
        cls.conn.close()
        return warns_list, counter

    # Remove all member's warns
    @classmethod
    async def db_remove_warns(cls, _member: int):
        cls.conn = cls.engine.connect()
        stmt = delete(warn).where(warn.c.member_id == _member)
        cls.conn.execute(stmt)
        cls.conn.close()

    # ----- MEMBER OPERATIONS -----

    # Return member's spots
    @classmethod
    async def db_get_member_stats(cls, _member: int):
        cls.conn = cls.engine.connect()
        stmt = select(member.c.display_name, spots.c.legendary, spots.c.rare, spots.c.common).select_from(member).join(
            spots,
            member.c.id == spots.c.member_id).where(spots.c.member_id == _member)
        df = pd.read_sql(stmt, cls.conn)
        cls.conn.close()
        return df

    # ----- COORDS OPERATIONS -----

    # Return coords
    @classmethod
    async def db_get_coords(cls):
        cls.conn = cls.engine.connect()
        stmt = select(coords.c.id, coords.c.coords, coords.c.monster_type).select_from(coords)
        df = pd.read_sql(stmt, cls.conn)
        cls.conn.close()
        return df


def setup(bot: commands.Bot):
    bot.add_cog(DatabaseCog(bot))


1			from discord.ext import commands, tasks
2			from discord_slash import cog_ext
3			from modules.get_settings import get_settings
4			from sqlalchemy import create_engine, Table, Column, Integer, String, MetaData, ForeignKey, \
5			BigInteger, update, select, DateTime, delete
6			from sqlalchemy.dialects.mysql import insert
7			import cogs.cogbase as cogbase
8			from datetime import datetime
9			import pandas as pd
10
11			metadata_obj = MetaData()
12			member = Table('member', metadata_obj,
13			Column('id', BigInteger, primary_key=True),
14			Column('name', String(50), nullable=False),
15			Column('display_name', String(50), nullable=False)
16			)
17			fk_member_id = "member.id"
18
19			spots = Table('spots', metadata_obj,
20			Column('member_id', BigInteger, ForeignKey(fk_member_id), primary_key=True),
21			Column('legendary', Integer, default=0),
22			Column('rare', Integer, default=0),
23			Column('common', Integer, default=0),
24			Column('event1', Integer, default=0),
25			Column('event2', Integer, default=0)
26			)
27
28			spots_temp = Table('spots_temp', metadata_obj,
29			Column('member_id', BigInteger, ForeignKey(fk_member_id), primary_key=True),
30			Column('legendary', Integer, default=0),
31			Column('rare', Integer, default=0),
32			Column('common', Integer, default=0),
33			Column('event1', Integer, default=0),
34			Column('event2', Integer, default=0)
35			)
36
37			warn = Table('warn', metadata_obj,
38			Column('id', Integer, primary_key=True),
39			Column('member_id', BigInteger, ForeignKey(fk_member_id)),
40			Column('reason', String(120), nullable=False),
41			Column('date', DateTime, nullable=False),
42			)
43
44			coords = Table('coords', metadata_obj,
45			Column('id', Integer, primary_key=True),
46			Column('coords', String(100), nullable=False),
47			Column('monster_type', String(20), nullable=False)
48			)
49
50
51			# noinspection PyPropertyAccess
52			class DatabaseCog(cogbase.BaseCog):
53			user = get_settings("DB_U")
54			password = get_settings("DB_P")
55			engine = create_engine(f"mysql+mysqldb://{user}:{password}@localhost/server_database?charset=utf8mb4")
56			metadata_obj.create_all(engine)
57			conn = None
58
59			def __init__(self, base):
60			super().__init__(base)
61
62			# Connect to database
63			self.engine = DatabaseCog.engine
64			metadata_obj.create_all(self.engine)
65			self.db_update_loop.start()
66			self.conn = DatabaseCog.conn
67
68			# ----- BASE DATABASE OPERATIONS -----
69
70			# Add or update member in member table
71			def db_add_update_member(self, _member):
72			self.conn = self.engine.connect()
73			stmt = insert(member).values(
74			id=_member.id, name=_member.name,
75			display_name=_member.display_name)
76			do_update_stmt = stmt.on_duplicate_key_update(
77			name=stmt.inserted.name, display_name=stmt.inserted.display_name
78			)
79			self.conn.execute(do_update_stmt)
80			self.conn.close()
81
82			# Add or update spots in spots table
83			def db_add_update_spots(self, spots_table, guild_member):
84			self.conn = self.engine.connect()
85			stmt = insert(spots_table).values(
86			member_id=guild_member.id)
87			do_update_stmt = stmt.on_duplicate_key_update(member_id=stmt.inserted.member_id)
88			self.conn.execute(do_update_stmt)
89			self.conn.close()
90
91			# Add or refresh all guild members and spots to database
92			async def db_update(self):
93			self.conn = self.engine.connect()
94			guild = self.bot.get_guild(self.bot.guild[0])
95			dt_string = self.bot.get_current_time()
96			print(f"({dt_string})\t[{self.__class__.__name__}]: Refreshing member and spots tables")
97			for guild_member in guild.members:
98			# Member tables
99			self.db_add_update_member(guild_member)
100			# Spots tables
101			self.db_add_update_spots(spots, guild_member)
102			self.db_add_update_spots(spots_temp, guild_member)
103			dt_string = self.bot.get_current_time()
104			print(f"({dt_string})\t[{self.__class__.__name__}]: Member and spots tables refreshed")
105			self.conn.close()
106
107			@tasks.loop(hours=12)
108			async def db_update_loop(self):
109			await self.db_update()
110
111			@db_update_loop.before_loop
112			async def before_db_update_loop(self):
113			dt_string = self.bot.get_current_time()
114			print(f'({dt_string})\t[{self.__class__.__name__}]: Waiting until Bot is ready')
115			await self.bot.wait_until_ready()
116
117			# Add member to database on member join
118			@commands.Cog.listener()
119			async def on_member_join(self, _member):
120			self.db_add_update_member(_member)
121			self.db_add_update_spots(spots, _member)
122			self.db_add_update_spots(spots_temp, _member)
123
124			# Command for loading data from previous bot
125			@cog_ext.cog_slash(name="updateSpotsWithOld", guild_ids=cogbase.GUILD_IDS,
126			description="Change N-Word channel name",
127			permissions=cogbase.PERMISSION_ADMINS)
128			async def db_update_spots_old(self, ctx):
129			self.conn = self.engine.connect()
130			import json
131			with open('server_files/old_base_test.json', 'r', encoding='utf-8-sig') as fp:
132			old_db = json.load(fp)
133
134			for mem_id in old_db:
135			stmt = select(spots.c.member_id, spots.c.legendary, spots.c.rare, spots.c.common).where(
136			spots.c.member_id == mem_id)
137			result = self.conn.execute(stmt).fetchall()
138			result = result[0]
139			counter_lege = result[1]
140			counter_rare = result[2]
141			counter_common = result[3]
142
143			stmt = insert(spots).values(
144			member_id=mem_id, legendary=old_db[mem_id]["type_1"],
145			rare=old_db[mem_id]["type_0"])
146			do_update_stmt = stmt.on_duplicate_key_update(legendary=stmt.inserted.legendary + counter_lege,
147			rare=stmt.inserted.rare + counter_rare,
148			common=stmt.inserted.common + counter_common)
149			self.conn.execute(do_update_stmt)
150
151			stmt = insert(spots_temp).values(
152			member_id=mem_id, legendary=old_db[mem_id]["type_1"],
153			rare=old_db[mem_id]["type_0"])
154			do_update_stmt = stmt.on_duplicate_key_update(legendary=stmt.inserted.legendary + counter_lege,
155			rare=stmt.inserted.rare + counter_rare,
156			common=stmt.inserted.common + counter_common)
157			self.conn.execute(do_update_stmt)
158
159			await ctx.send(f"Spot tables updated with old data", delete_after=3.0)
160			dt_string = self.bot.get_current_time()
161			print(f'({dt_string})\t[{self.__class__.__name__}]: Spot tables updated with old data')
162			self.conn.close()
163
164			# ----- SPOTTING OPERATIONS -----
165
166			# Update spots tables
167			@classmethod
168			async def db_count_spot(cls, _id: int, monster_type: str):
169			cls.conn = cls.engine.connect()
170			# Get member nr of spots for certain monster type
171			stmt = select(spots.c.member_id, spots.c.legendary, spots.c.rare, spots.c.common, spots.c.event1,
172			spots.c.event2).where(
173			spots.c.member_id == _id)
174			result = cls.conn.execute(stmt)
175			counter = []
176			for nr_of_kills in result.columns(monster_type):
177			counter = nr_of_kills[0]
178			stmt = update(spots).where(spots.c.member_id == _id).values({f"{monster_type}": counter + 1})
179			cls.conn.execute(stmt)
180
181			stmt = select(spots_temp.c.member_id, spots_temp.c.legendary, spots_temp.c.rare, spots_temp.c.common,
182			spots.c.event1,
183			spots.c.event2).where(
184			spots_temp.c.member_id == _id)
185			result = cls.conn.execute(stmt)
186			for nr_of_kills in result.columns(monster_type):
187			counter = nr_of_kills[0]
188			stmt = update(spots_temp).where(spots_temp.c.member_id == _id).values({f"{monster_type}": counter + 1})
189			cls.conn.execute(stmt)
190			cls.conn.close()
191
192			# Save coords from spotting channels to database
193			@classmethod
194			async def db_save_coords(cls, _coords: str, _monster_type):
195			cls.conn = cls.engine.connect()
196			stmt = insert(coords).values(coords=_coords, monster_type=_monster_type)
197			cls.conn.execute(stmt)
198			cls.conn.close()
199
200			# Clear data from spots_temp table(for events etc)
201			@classmethod
202			async def db_clear_spots_temp_table(cls):
203			cls.conn = cls.engine.connect()
204			stmt = delete(spots_temp)
205			cls.conn.execute(stmt)
206			cls.conn.close()
207
208			# ----- LEADERBOARD OPERATIONS -----
209
210			# Return all members' spots
211			@classmethod
212			async def db_get_spots_df(cls):
213			cls.conn = cls.engine.connect()
214			stmt = select(spots.c.member_id, member.c.display_name, spots.c.legendary, spots.c.rare,
215			spots.c.common, spots.c.event1, spots.c.event2
216			).select_from(member
217			).join(spots, member.c.id == spots.c.member_id)
218			cls.conn.execute(stmt)
219			df = pd.read_sql(stmt, cls.conn)
220			cls.conn.close()
221			return df
222
223			# ----- WARN OPERATIONS -----
224
225			# Add member's warn to database
226			@classmethod
227			async def db_add_warn(cls, _member: int, _reason: str):
228			cls.conn = cls.engine.connect()
229			stmt = insert(warn).values(member_id=_member, reason=_reason, date=datetime.now())
230			cls.conn.execute(stmt)
231			cls.conn.close()
232
233			# Get member's warns from database
234			@classmethod
235			async def db_get_warns(cls, _member: int):
236			cls.conn = cls.engine.connect()
237			stmt = select(warn.c.reason, warn.c.date).select_from(member).join(warn, member.c.id == warn.c.member_id).where(
238			member.c.id == _member)
239			result = cls.conn.execute(stmt)
240			date_warn = []
241			counter = 0
242			for warns in result.columns("reason", "date"):
243			reason_with_date = [warns[1], warns[0]]
244			date_warn.append(reason_with_date)
245			counter += 1
246			warns_list = [': \t'.join([str(elem) for elem in sublist]) for sublist in date_warn]
247			cls.conn.close()
248			return warns_list, counter
249
250			# Remove all member's warns
251			@classmethod
252			async def db_remove_warns(cls, _member: int):
253			cls.conn = cls.engine.connect()
254			stmt = delete(warn).where(warn.c.member_id == _member)
255			cls.conn.execute(stmt)
256			cls.conn.close()
257
258			# ----- MEMBER OPERATIONS -----
259
260			# Return member's spots
261			@classmethod
262			async def db_get_member_stats(cls, _member: int):
263			cls.conn = cls.engine.connect()
264			stmt = select(member.c.display_name, spots.c.legendary, spots.c.rare, spots.c.common).select_from(member).join(
265			spots,
266			member.c.id == spots.c.member_id).where(spots.c.member_id == _member)
267			df = pd.read_sql(stmt, cls.conn)
268			cls.conn.close()
269			return df
270
271			# ----- COORDS OPERATIONS -----
272
273			# Return coords
274			@classmethod
275			async def db_get_coords(cls):
276			cls.conn = cls.engine.connect()
277			stmt = select(coords.c.id, coords.c.coords, coords.c.monster_type).select_from(coords)
278			df = pd.read_sql(stmt, cls.conn)
279			cls.conn.close()
280			return df
281
282
283			def setup(bot: commands.Bot):
284			bot.add_cog(DatabaseCog(bot))
285

BonHowi / discordPogmareBot

Branch — BonHowi (5fc634)

DatabaseCog.db_update_spots_old() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like