build.cogs.databasecog.DatabaseCog.db_get_spots_df() - Code Metrics - Inspection of "Update commandscog.py" - BonHowi/discordPogmareBot - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — BonHowi (3ad014)

by Bartosz

created 2021-09-10 19:20 UTC

DatabaseCog.db_get_spots_df() A

↳ Parent: build.cogs.databasecog

Complexity

Conditions

Size

Total Lines	6
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	6
dl	0
loc	6
rs	10
c	0
b	0
f	0
cc	1
nop	1

from discord.ext import commands, tasks
from discord_slash import cog_ext
from modules.get_settings import get_settings
from sqlalchemy import create_engine, Table, Column, Integer, String, MetaData, ForeignKey, \
    BigInteger, update, select, DateTime, delete
from sqlalchemy.dialects.mysql import insert
import cogs.cogbase as cogbase
from datetime import datetime
import pandas as pd

metadata_obj = MetaData()
member = Table('member', metadata_obj,
               Column('id', BigInteger, primary_key=True),
               Column('name', String(50), nullable=False),
               Column('display_name', String(50), nullable=False)
               )
fk_member_id = "member.id"

spots = Table('spots', metadata_obj,
              Column('member_id', BigInteger, ForeignKey(fk_member_id), primary_key=True),
              Column('legendary', Integer, default=0),
              Column('rare', Integer, default=0),
              Column('common', Integer, default=0),
              Column('event1', Integer, default=0),
              Column('event2', Integer, default=0)
              )

spots_temp = Table('spots_temp', metadata_obj,
                   Column('member_id', BigInteger, ForeignKey(fk_member_id), primary_key=True),
                   Column('legendary', Integer, default=0),
                   Column('rare', Integer, default=0),
                   Column('common', Integer, default=0),
                   Column('event1', Integer, default=0),
                   Column('event2', Integer, default=0)
                   )

warn = Table('warn', metadata_obj,
             Column('id', Integer, primary_key=True),
             Column('member_id', BigInteger, ForeignKey(fk_member_id)),
             Column('reason', String(120), nullable=False),
             Column('date', DateTime, nullable=False),
             )

coords = Table('coords', metadata_obj,
               Column('id', Integer, primary_key=True),
               Column('coords', String(100), nullable=False),
               Column('monster_type', String(20), nullable=False)
               )


# noinspection PyPropertyAccess
class DatabaseCog(cogbase.BaseCog):
    password = get_settings("DB_P")
    engine = create_engine(f"mysql+mysqldb://BonHowi:{password}@localhost/server_database")
    metadata_obj.create_all(engine)
    conn = engine.connect()

    def __init__(self, base):
        super().__init__(base)

        # Connect to database
        self.engine = DatabaseCog.engine
        metadata_obj.create_all(self.engine)
        self.conn = DatabaseCog.conn
        self.db_update_loop.start()

    # ----- BASE DATABASE OPERATIONS -----

    # Add or update member in member table
    def db_add_update_member(self, _member):
        stmt = insert(member).values(
            id=_member.id, name=_member.name,
            display_name=_member.display_name)
        do_update_stmt = stmt.on_duplicate_key_update(
            name=stmt.inserted.name, display_name=stmt.inserted.display_name
        )
        self.conn.execute(do_update_stmt)

    # Add or update spots in spots table
    def db_add_update_spots(self, spots_table, guild_member):
        stmt = insert(spots_table).values(
            member_id=guild_member.id)
        do_update_stmt = stmt.on_duplicate_key_update(member_id=stmt.inserted.member_id)
        self.conn.execute(do_update_stmt)

    # Add or refresh all guild members and spots to database
    async def db_update(self):
        guild = self.bot.get_guild(self.bot.guild[0])

        print(f"[{self.__class__.__name__}]: Refreshing member and spots tables")
        for guild_member in guild.members:
            # Member tables
            self.db_add_update_member(guild_member)
            # Spots tables
            self.db_add_update_spots(spots, guild_member)
            self.db_add_update_spots(spots_temp, guild_member)
        print(f"[{self.__class__.__name__}]: Member and spots tables refreshed")

    @tasks.loop(hours=12)
    async def db_update_loop(self):
        await self.db_update()

    @db_update_loop.before_loop
    async def before_db_update_loop(self):
        print(f'[{self.__class__.__name__}]: Waiting until Bot is ready')
        await self.bot.wait_until_ready()

    # Add member to database on member join
    @commands.Cog.listener()
    async def on_member_join(self, _member):
        self.db_add_update_member(_member)
        self.db_add_update_spots(spots, _member)
        self.db_add_update_spots(spots_temp, _member)

    # Command for loading data from previous bot
    @cog_ext.cog_slash(name="updateSpotsWithOld", guild_ids=cogbase.GUILD_IDS,
                       description="Change N-Word channel name",
                       permissions=cogbase.PERMISSION_ADMINS)
    async def db_update_spots_old(self, ctx):
        import json
        with open('server_files/old_base_test.json', 'r', encoding='utf-8-sig') as fp:
            old_db = json.load(fp)

        for mem_id in old_db:
            stmt = insert(spots).values(
                member_id=mem_id, legendary=old_db[mem_id]["type_1"],
                rare=old_db[mem_id]["type_0"])
            do_update_stmt = stmt.on_duplicate_key_update(legendary=stmt.inserted.legendary,
                                                          rare=stmt.inserted.rare,
                                                          common=stmt.inserted.common)
            self.conn.execute(do_update_stmt)
            stmt = insert(spots_temp).values(
                member_id=mem_id, legendary=old_db[mem_id]["type_1"],
                rare=old_db[mem_id]["type_0"])
            do_update_stmt = stmt.on_duplicate_key_update(legendary=stmt.inserted.legendary,
                                                          rare=stmt.inserted.rare,
                                                          common=stmt.inserted.common)
            self.conn.execute(do_update_stmt)
        await ctx.send(f"Spot tables updated with old data", delete_after=3.0)
        print(f'[{self.__class__.__name__}]: Spot tables updated with old data')

    # ----- SPOTTING OPERATIONS -----

    # Update spots tables
    @classmethod
    async def db_count_spot(cls, _id: int, monster_type: str):
        # Get member nr of spots for certain monster type
        stmt = select(spots.c.member_id, spots.c.legendary, spots.c.rare, spots.c.common).where(
            spots.c.member_id == _id)
        result = cls.conn.execute(stmt)
        counter = []
        for nr_of_kills in result.columns(monster_type):
            counter = nr_of_kills[0]
        stmt = update(spots).where(spots.c.member_id == _id).values({f"{monster_type}": counter + 1})
        cls.conn.execute(stmt)

        stmt = select(spots_temp.c.member_id, spots_temp.c.legendary, spots_temp.c.rare, spots_temp.c.common).where(
            spots_temp.c.member_id == _id)
        result = cls.conn.execute(stmt)
        for nr_of_kills in result.columns(monster_type):
            counter = nr_of_kills[0]
        stmt = update(spots_temp).where(spots_temp.c.member_id == _id).values({f"{monster_type}": counter + 1})
        cls.conn.execute(stmt)

    # Save coords from spotting channels to database
    @classmethod
    async def db_save_coords(cls, _coords: str, _monster_type):
        stmt = insert(coords).values(coords=_coords, monster_type=_monster_type)
        cls.conn.execute(stmt)

    # Clear data from spots_temp table(for events etc)
    @classmethod
    async def db_clear_spots_temp_table(cls):
        stmt = delete(spots_temp)
        cls.conn.execute(stmt)

    # ----- LEADERBOARD OPERATIONS -----

    # Return all members' spots
    @classmethod
    async def db_get_spots_df(cls):
        stmt = select(spots.c.member_id, member.c.display_name, spots.c.legendary, spots.c.rare,
                      spots.c.common).select_from(member).join(spots, member.c.id == spots.c.member_id)
        df = pd.read_sql(stmt, cls.conn)
        return df

    # ----- WARN OPERATIONS -----

    # Add member's warn to database
    @classmethod
    async def db_add_warn(cls, _member: int, _reason: str):
        stmt = insert(warn).values(member_id=_member, reason=_reason, date=datetime.now())
        cls.conn.execute(stmt)

    # Get member's warns from database
    @classmethod
    async def db_get_warns(cls, _member: int):
        stmt = select(warn.c.reason, warn.c.date).select_from(member).join(warn, member.c.id == warn.c.member_id).where(
            member.c.id == _member)
        result = cls.conn.execute(stmt)
        date_warn = []
        counter = 0
        for warns in result.columns("reason", "date"):
            reason_with_date = [warns[1], warns[0]]
            date_warn.append(reason_with_date)
            counter += 1
        warns_list = [': \t'.join([str(elem) for elem in sublist]) for sublist in date_warn]
        return warns_list, counter

    # Remove all member's warns
    @classmethod
    async def db_remove_warns(cls, _member: int):
        stmt = delete(warn).where(warn.c.member_id == _member)
        cls.conn.execute(stmt)

    # ----- MEMBER OPERATIONS -----

    # Return member's spots
    @classmethod
    async def db_get_member_stats(cls, _member: int):
        stmt = select(member.c.display_name, spots.c.legendary, spots.c.rare, spots.c.common).select_from(member).join(
            spots,
            member.c.id == spots.c.member_id).where(spots.c.member_id == _member)
        df = pd.read_sql(stmt, cls.conn)
        return df


def setup(bot: commands.Bot):
    bot.add_cog(DatabaseCog(bot))


1			from discord.ext import commands, tasks
2			from discord_slash import cog_ext
3			from modules.get_settings import get_settings
4			from sqlalchemy import create_engine, Table, Column, Integer, String, MetaData, ForeignKey, \
5			BigInteger, update, select, DateTime, delete
6			from sqlalchemy.dialects.mysql import insert
7			import cogs.cogbase as cogbase
8			from datetime import datetime
9			import pandas as pd
10
11			metadata_obj = MetaData()
12			member = Table('member', metadata_obj,
13			Column('id', BigInteger, primary_key=True),
14			Column('name', String(50), nullable=False),
15			Column('display_name', String(50), nullable=False)
16			)
17			fk_member_id = "member.id"
18
19			spots = Table('spots', metadata_obj,
20			Column('member_id', BigInteger, ForeignKey(fk_member_id), primary_key=True),
21			Column('legendary', Integer, default=0),
22			Column('rare', Integer, default=0),
23			Column('common', Integer, default=0),
24			Column('event1', Integer, default=0),
25			Column('event2', Integer, default=0)
26			)
27
28			spots_temp = Table('spots_temp', metadata_obj,
29			Column('member_id', BigInteger, ForeignKey(fk_member_id), primary_key=True),
30			Column('legendary', Integer, default=0),
31			Column('rare', Integer, default=0),
32			Column('common', Integer, default=0),
33			Column('event1', Integer, default=0),
34			Column('event2', Integer, default=0)
35			)
36
37			warn = Table('warn', metadata_obj,
38			Column('id', Integer, primary_key=True),
39			Column('member_id', BigInteger, ForeignKey(fk_member_id)),
40			Column('reason', String(120), nullable=False),
41			Column('date', DateTime, nullable=False),
42			)
43
44			coords = Table('coords', metadata_obj,
45			Column('id', Integer, primary_key=True),
46			Column('coords', String(100), nullable=False),
47			Column('monster_type', String(20), nullable=False)
48			)
49
50
51			# noinspection PyPropertyAccess
52			class DatabaseCog(cogbase.BaseCog):
53			password = get_settings("DB_P")
54			engine = create_engine(f"mysql+mysqldb://BonHowi:{password}@localhost/server_database")
55			metadata_obj.create_all(engine)
56			conn = engine.connect()
57
58			def __init__(self, base):
59			super().__init__(base)
60
61			# Connect to database
62			self.engine = DatabaseCog.engine
63			metadata_obj.create_all(self.engine)
64			self.conn = DatabaseCog.conn
65			self.db_update_loop.start()
66
67			# ----- BASE DATABASE OPERATIONS -----
68
69			# Add or update member in member table
70			def db_add_update_member(self, _member):
71			stmt = insert(member).values(
72			id=_member.id, name=_member.name,
73			display_name=_member.display_name)
74			do_update_stmt = stmt.on_duplicate_key_update(
75			name=stmt.inserted.name, display_name=stmt.inserted.display_name
76			)
77			self.conn.execute(do_update_stmt)
78
79			# Add or update spots in spots table
80			def db_add_update_spots(self, spots_table, guild_member):
81			stmt = insert(spots_table).values(
82			member_id=guild_member.id)
83			do_update_stmt = stmt.on_duplicate_key_update(member_id=stmt.inserted.member_id)
84			self.conn.execute(do_update_stmt)
85
86			# Add or refresh all guild members and spots to database
87			async def db_update(self):
88			guild = self.bot.get_guild(self.bot.guild[0])
89
90			print(f"[{self.__class__.__name__}]: Refreshing member and spots tables")
91			for guild_member in guild.members:
92			# Member tables
93			self.db_add_update_member(guild_member)
94			# Spots tables
95			self.db_add_update_spots(spots, guild_member)
96			self.db_add_update_spots(spots_temp, guild_member)
97			print(f"[{self.__class__.__name__}]: Member and spots tables refreshed")
98
99			@tasks.loop(hours=12)
100			async def db_update_loop(self):
101			await self.db_update()
102
103			@db_update_loop.before_loop
104			async def before_db_update_loop(self):
105			print(f'[{self.__class__.__name__}]: Waiting until Bot is ready')
106			await self.bot.wait_until_ready()
107
108			# Add member to database on member join
109			@commands.Cog.listener()
110			async def on_member_join(self, _member):
111			self.db_add_update_member(_member)
112			self.db_add_update_spots(spots, _member)
113			self.db_add_update_spots(spots_temp, _member)
114
115			# Command for loading data from previous bot
116			@cog_ext.cog_slash(name="updateSpotsWithOld", guild_ids=cogbase.GUILD_IDS,
117			description="Change N-Word channel name",
118			permissions=cogbase.PERMISSION_ADMINS)
119			async def db_update_spots_old(self, ctx):
120			import json
121			with open('server_files/old_base_test.json', 'r', encoding='utf-8-sig') as fp:
122			old_db = json.load(fp)
123
124			for mem_id in old_db:
125			stmt = insert(spots).values(
126			member_id=mem_id, legendary=old_db[mem_id]["type_1"],
127			rare=old_db[mem_id]["type_0"])
128			do_update_stmt = stmt.on_duplicate_key_update(legendary=stmt.inserted.legendary,
129			rare=stmt.inserted.rare,
130			common=stmt.inserted.common)
131			self.conn.execute(do_update_stmt)
132			stmt = insert(spots_temp).values(
133			member_id=mem_id, legendary=old_db[mem_id]["type_1"],
134			rare=old_db[mem_id]["type_0"])
135			do_update_stmt = stmt.on_duplicate_key_update(legendary=stmt.inserted.legendary,
136			rare=stmt.inserted.rare,
137			common=stmt.inserted.common)
138			self.conn.execute(do_update_stmt)
139			await ctx.send(f"Spot tables updated with old data", delete_after=3.0)
140			print(f'[{self.__class__.__name__}]: Spot tables updated with old data')
141
142			# ----- SPOTTING OPERATIONS -----
143
144			# Update spots tables
145			@classmethod
146			async def db_count_spot(cls, _id: int, monster_type: str):
147			# Get member nr of spots for certain monster type
148			stmt = select(spots.c.member_id, spots.c.legendary, spots.c.rare, spots.c.common).where(
149			spots.c.member_id == _id)
150			result = cls.conn.execute(stmt)
151			counter = []
152			for nr_of_kills in result.columns(monster_type):
153			counter = nr_of_kills[0]
154			stmt = update(spots).where(spots.c.member_id == _id).values({f"{monster_type}": counter + 1})
155			cls.conn.execute(stmt)
156
157			stmt = select(spots_temp.c.member_id, spots_temp.c.legendary, spots_temp.c.rare, spots_temp.c.common).where(
158			spots_temp.c.member_id == _id)
159			result = cls.conn.execute(stmt)
160			for nr_of_kills in result.columns(monster_type):
161			counter = nr_of_kills[0]
162			stmt = update(spots_temp).where(spots_temp.c.member_id == _id).values({f"{monster_type}": counter + 1})
163			cls.conn.execute(stmt)
164
165			# Save coords from spotting channels to database
166			@classmethod
167			async def db_save_coords(cls, _coords: str, _monster_type):
168			stmt = insert(coords).values(coords=_coords, monster_type=_monster_type)
169			cls.conn.execute(stmt)
170
171			# Clear data from spots_temp table(for events etc)
172			@classmethod
173			async def db_clear_spots_temp_table(cls):
174			stmt = delete(spots_temp)
175			cls.conn.execute(stmt)
176
177			# ----- LEADERBOARD OPERATIONS -----
178
179			# Return all members' spots
180			@classmethod
181			async def db_get_spots_df(cls):
182			stmt = select(spots.c.member_id, member.c.display_name, spots.c.legendary, spots.c.rare,
183			spots.c.common).select_from(member).join(spots, member.c.id == spots.c.member_id)
184			df = pd.read_sql(stmt, cls.conn)
185			return df
186
187			# ----- WARN OPERATIONS -----
188
189			# Add member's warn to database
190			@classmethod
191			async def db_add_warn(cls, _member: int, _reason: str):
192			stmt = insert(warn).values(member_id=_member, reason=_reason, date=datetime.now())
193			cls.conn.execute(stmt)
194
195			# Get member's warns from database
196			@classmethod
197			async def db_get_warns(cls, _member: int):
198			stmt = select(warn.c.reason, warn.c.date).select_from(member).join(warn, member.c.id == warn.c.member_id).where(
199			member.c.id == _member)
200			result = cls.conn.execute(stmt)
201			date_warn = []
202			counter = 0
203			for warns in result.columns("reason", "date"):
204			reason_with_date = [warns[1], warns[0]]
205			date_warn.append(reason_with_date)
206			counter += 1
207			warns_list = [': \t'.join([str(elem) for elem in sublist]) for sublist in date_warn]
208			return warns_list, counter
209
210			# Remove all member's warns
211			@classmethod
212			async def db_remove_warns(cls, _member: int):
213			stmt = delete(warn).where(warn.c.member_id == _member)
214			cls.conn.execute(stmt)
215
216			# ----- MEMBER OPERATIONS -----
217
218			# Return member's spots
219			@classmethod
220			async def db_get_member_stats(cls, _member: int):
221			stmt = select(member.c.display_name, spots.c.legendary, spots.c.rare, spots.c.common).select_from(member).join(
222			spots,
223			member.c.id == spots.c.member_id).where(spots.c.member_id == _member)
224			df = pd.read_sql(stmt, cls.conn)
225			return df
226
227
228			def setup(bot: commands.Bot):
229			bot.add_cog(DatabaseCog(bot))
230

BonHowi / discordPogmareBot

Branch — BonHowi (3ad014)

DatabaseCog.db_get_spots_df() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like