BonHowi /
discordPogmareBot
| Conditions | 12 |
| Total Lines | 56 |
| Code Lines | 38 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like build.cogs.spotcog.SpotCog.count_spot() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | """ |
||
| 47 | role = get(ctx.guild.roles, name=spotted_monster["name"]) |
||
| 48 | await ctx.delete() |
||
| 49 | await ctx.channel.send(f"{role.mention}") |
||
| 50 | # await self.count_spot(ctx, spotted_monster["type"]) |
||
| 51 | await DatabaseCog.db_count_spot(ctx.author.id, |
||
| 52 | monster_type_dict[spotted_monster["type"]]) |
||
| 53 | return |
||
| 54 | else: |
||
| 55 | await ctx.channel.send( |
||
| 56 | f"{ctx.author.mention} monster not found; are you sure that name is correct?", delete_after=5) |
||
| 57 | elif ctx.content[0] in cords_beginning: |
||
| 58 | await DatabaseCog.db_save_coords(ctx.content, ctx.channel.name) |
||
| 59 | return |
||
| 60 | |||
| 61 | # @cog_ext.cog_slash(name="setMemberSpotsCounter", guild_ids=cogbase.GUILD_IDS, |
||
| 62 | # description="Function for managing user's spots", |
||
| 63 | # default_permission=False, |
||
| 64 | # permissions=cogbase.PERMISSION_MODS) |
||
| 65 | # async def set_spot_count(self, ctx: SlashContext, user: discord.User, monster_type: int, number: int): |
||
| 66 | # """ |
||
| 67 | # |
||
| 68 | # :param ctx: |
||
| 69 | # :type ctx: |
||
| 70 | # :param user: |
||
| 71 | # :type user: |
||
| 72 | # :param monster_type: |
||
| 73 | # :type monster_type: |
||
| 74 | # :param number: |
||
| 75 | # :type number: |
||
| 76 | # :return: |
||
| 77 | # :rtype: |
||
| 78 | # """ |
||
| 79 | # if number < 0: |
||
| 80 | # await ctx.channel.send("Nr of spots can't be lower than 0", delete_after=2) |
||
| 81 | # return |
||
| 82 | # with open("./server_files/monster_spots.json", encoding="utf-8") as f: |
||
| 83 | # try: |
||
| 84 | # spots = json.load(f) |
||
| 85 | # except ValueError: |
||
| 86 | # spots = {"users": []} |
||
| 87 | # await ctx.channel.send("monster_spots.json created", delete_after=1) |
||
| 88 | # |
||
| 89 | # # TODO: Too many ifs? actually this whole function is written in bad way |
||
| 90 | # for current_user in spots["users"]: |
||
| 91 | # if current_user["id"] == user.id: |
||
| 92 | # if monster_type == 0: |
||
| 93 | # current_user["rare_spots"] = number |
||
| 94 | # elif monster_type == 1: |
||
| 95 | # current_user["lege_spots"] = number |
||
| 96 | # elif monster_type == 2: |
||
| 97 | # pass |
||
| 98 | # elif monster_type == 3: |
||
| 99 | # pass |
||
| 100 | # elif monster_type == 4: |
||
| 101 | # current_user["common_spots"] = number |
||
| 102 | # else: |
||
| 103 | # print("Wrong monster type(?)") |
||
| 115 |
