Caller::setHttpClient() - Code Metrics - Inspection of "BWD-00 Log responses" - Bokbasen/php-api-client - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#2)

by Harald

created 2019-06-19 12:36 UTC

Caller::setHttpClient() A

↳ Parent: Caller

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php

namespace Bokbasen\ApiClient;

use Bokbasen\ApiClient\Exceptions\BokbasenApiClientException;
use Http\Client\HttpClient;
use Http\Discovery\HttpClientDiscovery;
use Http\Discovery\MessageFactoryDiscovery;
use Http\Discovery\Psr17FactoryDiscovery;
use Http\Discovery\Psr18ClientDiscovery;
use Http\Discovery\StreamFactoryDiscovery;
use Http\Message\MessageFactory;
use Http\Message\StreamFactory;
use Psr\Http\Client\ClientExceptionInterface;
use Psr\Http\Client\ClientInterface;
use Psr\Http\Message\RequestFactoryInterface;
filter:
    dependency_paths: ["lib/*"]
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\StreamInterface;
use Psr\Http\Message\UriInterface;

class Caller
{
    /**
     * @var HttpClient
     */
    private $httpClient;

    /**
     * @var StreamFactory
     */
    private $streamFactory;

    /**
     * @var RequestFactoryInterface
     */
    private $requestFactory;

    public function __construct(
        ClientInterface $httpClient = null,
        RequestFactoryInterface $requestFactory = null,
        StreamInterface $streamFactory = null
    ) {
        $this->httpClient = $httpClient ?: Psr18ClientDiscovery::find();
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->requestFactory = $requestFactory ?: Psr17FactoryDiscovery::findRequestFactory();
        $this->streamFactory = $streamFactory ?: Psr17FactoryDiscovery::findStreamFactory();
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * @param string                               $method
     * @param string|UriInterface                  $url
     * @param array                                $headers
     * @param resource|string|StreamInterface|null $body
     *
     * @return ResponseInterface
     *
     * @throws BokbasenApiClientException
     */
    public function request(string $method, $url, array $headers = [], $body = null): ResponseInterface
    {
        try {
            $request = $this->requestFactory->createRequest($method, $url);

            if (!empty($headers)) {
                foreach ($headers as $name => $value) {
                    $request = $request->withHeader($name, $value);
                }
            }

            if ($body !== null) {
                $request = $request->withBody(
                    $this->streamFactory->createStream($body)
                );
            }

            return $this->httpClient->sendRequest($request);
        } catch (ClientExceptionInterface | \Exception $e) {
            throw new BokbasenApiClientException($e->getMessage(), $e->getCode(), $e);
        }
    }

    public function setHttpClient(ClientInterface $httpClient): void
    {
        $this->httpClient = $httpClient;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
    }
}


1		<?php
2
3		namespace Bokbasen\ApiClient;
4
5		use Bokbasen\ApiClient\Exceptions\BokbasenApiClientException;
6		use Http\Client\HttpClient;
7		use Http\Discovery\HttpClientDiscovery;
8		use Http\Discovery\MessageFactoryDiscovery;
9		use Http\Discovery\Psr17FactoryDiscovery;
10		use Http\Discovery\Psr18ClientDiscovery;
11		use Http\Discovery\StreamFactoryDiscovery;
12		use Http\Message\MessageFactory;
13		use Http\Message\StreamFactory;
14		use Psr\Http\Client\ClientExceptionInterface;
15		use Psr\Http\Client\ClientInterface;
16		use Psr\Http\Message\RequestFactoryInterface;
		0 ignored issues – show Bug introduced 2019-06-19 12:41 UTC by Report Bug Copy Issue Report The type `Psr\Http\Message\RequestFactoryInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
17		use Psr\Http\Message\ResponseInterface;
18		use Psr\Http\Message\StreamInterface;
19		use Psr\Http\Message\UriInterface;
20
21		class Caller
22		{
23		/**
24		* @var HttpClient
25		*/
26		private $httpClient;
27
28		/**
29		* @var StreamFactory
30		*/
31		private $streamFactory;
32
33		/**
34		* @var RequestFactoryInterface
35		*/
36		private $requestFactory;
37
38	2	public function __construct(
39		ClientInterface $httpClient = null,
40		RequestFactoryInterface $requestFactory = null,
41		StreamInterface $streamFactory = null
42		) {
43	2	$this->httpClient = $httpClient ?: Psr18ClientDiscovery::find();
		0 ignored issues – show Documentation Bug introduced 2019-06-19 12:41 UTC by Report Bug Copy Issue Report `$httpClient ?: Http\Disc...ClientDiscovery::find()` is of type `Psr\Http\Client\ClientInterface`, but the property `$httpClient` was declared to be of type `Http\Client\HttpClient`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
44		$this->requestFactory = $requestFactory ?: Psr17FactoryDiscovery::findRequestFactory();
45		$this->streamFactory = $streamFactory ?: Psr17FactoryDiscovery::findStreamFactory();
		0 ignored issues – show Documentation Bug introduced 2019-06-19 12:41 UTC by Report Bug Copy Issue Report It seems like `$streamFactory ?: Http\D...ry::findStreamFactory()` can also be of type `Psr\Http\Message\StreamInterface`. However, the property `$streamFactory` is declared as type `Http\Message\StreamFactory`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
46		}
47
48		/**
49		* @param string $method
50		* @param string\|UriInterface $url
51		* @param array $headers
52		* @param resource\|string\|StreamInterface\|null $body
53		*
54		* @return ResponseInterface
55		*
56		* @throws BokbasenApiClientException
57		*/
58		public function request(string $method, $url, array $headers = [], $body = null): ResponseInterface
59		{
60		try {
61		$request = $this->requestFactory->createRequest($method, $url);
62
63		if (!empty($headers)) {
64		foreach ($headers as $name => $value) {
65		$request = $request->withHeader($name, $value);
66		}
67		}
68
69		if ($body !== null) {
70		$request = $request->withBody(
71		$this->streamFactory->createStream($body)
72		);
73		}
74
75		return $this->httpClient->sendRequest($request);
76		} catch (ClientExceptionInterface \| \Exception $e) {
77		throw new BokbasenApiClientException($e->getMessage(), $e->getCode(), $e);
78		}
79		}
80
81		public function setHttpClient(ClientInterface $httpClient): void
82		{
83		$this->httpClient = $httpClient;
		0 ignored issues – show Documentation Bug introduced 2019-06-19 12:41 UTC by Report Bug Copy Issue Report `$httpClient` is of type `Psr\Http\Client\ClientInterface`, but the property `$httpClient` was declared to be of type `Http\Client\HttpClient`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
84		}
85		}
86

Bokbasen / php-api-client

GitHub Access Token became invalid

Pull Request — master (#2)

Caller::setHttpClient() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like