Bokbasen\ApiClient\Caller

Complexity

Total Complexity

10

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Test Coverage

Coverage

11.11%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	request()	0	20	5
A	setHttpClient()	0	3	1
A	__construct()	0	8	4

<?php

namespace Bokbasen\ApiClient;

use Bokbasen\ApiClient\Exceptions\BokbasenApiClientException;
use Http\Client\HttpClient;
use Http\Discovery\Psr17FactoryDiscovery;
use Http\Discovery\Psr18ClientDiscovery;
use Http\Message\StreamFactory;
use Psr\Http\Client\ClientExceptionInterface;
use Psr\Http\Client\ClientInterface;
use Psr\Http\Message\RequestFactoryInterface;

The type Psr\Http\Message\RequestFactoryInterface was not found. Maybe you did not declare it correctly or list all dependencies?

use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\StreamInterface;
use Psr\Http\Message\UriInterface;

class Caller
{
    /**
     * @var HttpClient
     */
    private $httpClient;

    /**
     * @var StreamFactory
     */
    private $streamFactory;

    /**
     * @var RequestFactoryInterface
     */
    private $requestFactory;

    public function __construct(
        ClientInterface $httpClient = null,
        RequestFactoryInterface $requestFactory = null,
        StreamInterface $streamFactory = null
    ) {
        $this->httpClient = $httpClient ?: Psr18ClientDiscovery::find();

$httpClient ?: Http\Discovery\Psr18ClientDiscovery::find() is of type Psr\Http\Client\ClientInterface, but the property $httpClient was declared to be of type Http\Client\HttpClient. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->requestFactory = $requestFactory ?: Psr17FactoryDiscovery::findRequestFactory();
        $this->streamFactory = $streamFactory ?: Psr17FactoryDiscovery::findStreamFactory();

It seems like $streamFactory ?: Http\Discovery\Psr17FactoryDiscovery::findStreamFactory() can also be of type Psr\Http\Message\StreamInterface. However, the property $streamFactory is declared as type Http\Message\StreamFactory. Maybe add an additional type check?

    }

    /**
     * @param string                               $method
     * @param string|UriInterface                  $url
     * @param array                                $headers
     * @param resource|string|StreamInterface|null $body
     *
     * @return ResponseInterface
     *
     * @throws BokbasenApiClientException
     */
    public function request(string $method, $url, array $headers = [], $body = null): ResponseInterface
    {
        try {
            $request = $this->requestFactory->createRequest($method, $url);

            if (!empty($headers)) {
                foreach ($headers as $name => $value) {
                    $request = $request->withHeader($name, $value);
                }
            }

            if ($body !== null) {
                $request = $request->withBody(
                    $this->streamFactory->createStream($body)
                );
            }

            return $this->httpClient->sendRequest($request);
        } catch (ClientExceptionInterface | \Exception $e) {
            throw new BokbasenApiClientException($e->getMessage(), $e->getCode(), $e);
        }
    }

    public function setHttpClient(ClientInterface $httpClient): void
    {
        $this->httpClient = $httpClient;

$httpClient is of type Psr\Http\Client\ClientInterface, but the property $httpClient was declared to be of type Http\Client\HttpClient. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }
}