Bludata /
laravel-seed
| Conditions | 18 |
| Paths | 516 |
| Total Lines | 50 |
| Code Lines | 29 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 25 | public function resourceRoutes(string $uri, string $controller, Closure $routes = null, array $options = []) |
||
| 26 | { |
||
| 27 | $options['name'] = $options['name'] ?? $uri; |
||
| 28 | $options['only'] = $options['only'] ?? []; |
||
| 29 | $options['except'] = $options['except'] ?? []; |
||
| 30 | |||
| 31 | $exceptAll = isset($options['except'][0]) && $options['except'][0] == '*'; |
||
| 32 | |||
| 33 | if (!$exceptAll) { |
||
| 34 | if (in_array('index', $options['only']) && !in_array('index', $options['except'])) { |
||
| 35 | Route::get($uri, $controller.'@index') |
||
| 36 | ->name($options['name'].'.index'); |
||
| 37 | } |
||
| 38 | |||
| 39 | if (in_array('show', $options['only']) && !in_array('show', $options['except'])) { |
||
| 40 | Route::get($uri.'/{uuid}', $controller.'@show') |
||
| 41 | ->name($options['name'].'.show'); |
||
| 42 | } |
||
| 43 | |||
| 44 | if (in_array('store', $options['only']) && !in_array('store', $options['except'])) { |
||
| 45 | Route::post($uri, $controller.'@store') |
||
| 46 | ->name($options['name'].'.store'); |
||
| 47 | } |
||
| 48 | |||
| 49 | if (in_array('update', $options['only']) && !in_array('update', $options['except'])) { |
||
| 50 | Route::put($uri.'/{uuid}', $controller.'@update') |
||
| 51 | ->name($options['name'].'.update'); |
||
| 52 | } |
||
| 53 | |||
| 54 | if (in_array('destroy', $options['only']) && !in_array('destroy', $options['except'])) { |
||
| 55 | Route::delete($uri.'/{uuid}', $controller.'@destroy') |
||
| 56 | ->name($options['name'].'.destroy'); |
||
| 57 | } |
||
| 58 | |||
| 59 | if (in_array('destroyed', $options['only']) && !in_array('destroyed', $options['except'])) { |
||
| 60 | Route::get($uri.'/destroyed', $controller.'@destroyed') |
||
| 61 | ->name($options['name'].'.destroyed'); |
||
| 62 | } |
||
| 63 | |||
| 64 | if (in_array('restoreDestroyed', $options['only']) && !in_array('restoreDestroyed', $options['except'])) { |
||
| 65 | Route::post($uri.'/{uuid}', $controller.'@restoreDestroyed') |
||
| 66 | ->name($options['name'].'.restoreDestroyed'); |
||
| 67 | } |
||
| 68 | } |
||
| 69 | |||
| 70 | if ($routes instanceof Closure) { |
||
| 71 | $routes($uri, $controller, $options); |
||
| 72 | } |
||
| 73 | |||
| 74 | return $this; |
||
| 75 | } |
||
| 77 |
