WorkspaceCheckinTest::testPostWorkspaceCheck() - Code Metrics - Inspection of "added testing for user, fixed some minur issue wit..." - BitPrepared/d1b0 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 57ebb4...86d5a0 )

by Danger

created 2016-10-11 15:10 UTC

WorkspaceCheckinTest::testPostWorkspaceCheck() B

↳ Parent: WorkspaceCheckinTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	27
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	27
rs	8.8571
c	0
b	0
f	0
cc	1
eloc	21
nc	1
nop	0

<?php

namespace Tests;

use Silex\WebTestCase;
use JsonSchema\Validator;

class WorkspaceCheckinTest extends PartTest
{
    use AbstractAppTest;


    public function testPostWorkspaceCheck(){
        $blob = $this->testPostWorkspacePart();
        $id = $blob[0];
        $part_id= $blob[1];

        print_r("FANFARA!");
        var_dump($blob);

        $client = $this->createClient();
        $client = $this->logIn2($client);
        $client->request(
          'POST',
          '/api/v1/workspace/'.$id.'/part/'.$part_id.'/checkin',
          [],
          [],
          ['CONTENT_TYPE' => 'application/json'],
          '');
        $response = $client->getResponse();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $data = $client->getResponse()->getContent();
        print_r("ROBAGROSSA");
        var_dump($data);
        $js = json_decode($data);
        $points = $js->points;

        $this->assertTrue(is_numeric($points));  //TODO verificare che il numero sia adeguato ai punti attesi

        return [$id,$part_id];
    }

    public function testDeletePostWorkspaceCheck(){
        $blob = $this->testPostWorkspaceCheck();
        $id = $blob[0];
        $part_id= $blob[1];

        print_r("FANFARA!");
        var_dump($blob);

        $client = $this->createClient();
        $client = $this->logIn2($client);
        $client->request(
          'DELETE',
          '/api/v1/workspace/'.$id.'/part/'.$part_id.'/checkin',
          [],
          [],
          ['CONTENT_TYPE' => 'application/json'],
          '');
        $response = $client->getResponse();


        $this->assertEquals(204,$response->getStatusCode());  //TODO verificare che il dato non sia più presente sul server

        return [$id,$part_id];
    }
}


1			<?php
2
3			namespace Tests;
4
5			use Silex\WebTestCase;
6			use JsonSchema\Validator;
7
8			class WorkspaceCheckinTest extends PartTest
9			{
10			use AbstractAppTest;
11
12
13			public function testPostWorkspaceCheck(){
14			$blob = $this->testPostWorkspacePart();
15			$id = $blob[0];
16			$part_id= $blob[1];
17
18			print_r("FANFARA!");
19			var_dump($blob);
			0 ignored issues – show Security Debugging Code introduced 2016-10-11 15:13 UTC by Report Bug Copy Issue Report `var_dump($blob);` looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data. Loading history...
20			$client = $this->createClient();
21			$client = $this->logIn2($client);
22			$client->request(
23			'POST',
24			'/api/v1/workspace/'.$id.'/part/'.$part_id.'/checkin',
25			[],
26			[],
27			['CONTENT_TYPE' => 'application/json'],
28			'');
29			$response = $client->getResponse();
			0 ignored issues – show Unused Code introduced 2016-10-11 15:13 UTC by Report Bug Copy Issue Report `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
30			$data = $client->getResponse()->getContent();
31			print_r("ROBAGROSSA");
32			var_dump($data);
33			$js = json_decode($data);
34			$points = $js->points;
35
36			$this->assertTrue(is_numeric($points)); //TODO verificare che il numero sia adeguato ai punti attesi
37
38			return [$id,$part_id];
39			}
40
41			public function testDeletePostWorkspaceCheck(){
42			$blob = $this->testPostWorkspaceCheck();
43			$id = $blob[0];
44			$part_id= $blob[1];
45
46			print_r("FANFARA!");
47			var_dump($blob);
			0 ignored issues – show Security Debugging Code introduced 2016-10-11 15:13 UTC by Report Bug Copy Issue Report `var_dump($blob);` looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data. Loading history...
48			$client = $this->createClient();
49			$client = $this->logIn2($client);
50			$client->request(
51			'DELETE',
52			'/api/v1/workspace/'.$id.'/part/'.$part_id.'/checkin',
53			[],
54			[],
55			['CONTENT_TYPE' => 'application/json'],
56			'');
57			$response = $client->getResponse();
58
59
60			$this->assertEquals(204,$response->getStatusCode()); //TODO verificare che il dato non sia più presente sul server
61
62			return [$id,$part_id];
63			}
64			}
65

BitPrepared / d1b0

GitHub Access Token became invalid

Push — master ( 57ebb4...86d5a0 )

WorkspaceCheckinTest::testPostWorkspaceCheck() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like