View GitHub Repository d1b0

Schedule Inspection
Subscribe

GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Push — master ( daf6e6...30b81a )
by Danger
02:11
created
Status
Category
Toggle Patches
src/BitPrepared/Bundle/D1b0Workspace/Controller/V1/SecurityController.php 1 patch
Braces   +4 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -53,15 +53,14 @@  discard block
 
 block discarded – undo
53 53 
                         "clientId"=>$user->id
54 54 
                 ];
55 55 
                 $response = JsonResponse::create($res, 200, $headers)->setSharedMaxAge(300);
56 
-            }else {
56 
+            } else {
57 57 
                 $headers = [];
58 58 
                 $res = [
59 59 
                         "errore"=>"sbagliato password o user" //TODO roba
60 60 
                 ];
61 61 
                 $response = JsonResponse::create($res, 401, $headers)->setSharedMaxAge(300);
62 62 
             }
63 
-        }
64 
-        else {
63 
+        } else {
65 64 
             //Facebook Redirect
66 65 
         }
67 66 
         return $response; // JsonResponse::create($output, 200, $headers)->setSharedMaxAge(300);
 
@@ -82,14 +81,14 @@  discard block
 
 block discarded – undo
82 81 
             if (!$bean->id) {
83 82 
                 //TODO mettere un controllo agli IP che forzano le richieste di token falsi
84 83 
                 $response = "<html><head></head><body>Token non esistente!</body></html>";
85 
-            }else {
84 
+            } else {
86 85 
                 if (strtotime($verify->inserttime) < strtotime("-15 minutes")) {
87 86 
                     $user = R::load('user', $verify->user);
88 87 
                     $user->status = "enabled";
89 88 
                     $user->updatetime = date('Y-m-d H:i:s');
90 89 
                     $id = R::store($user);
91 90 
                     $response = "<html><head></head><body>Account attivato complimenti!</body></html>";
92 
-                }else {
91 
+                } else {
93 92 
                     $response = "<html><head></head><body>Impossibile attivare account inserire mail e password per richiedere un nuovo token!</body></html>";
94 93 
                 }
95 94 
             }
Please login to merge, or discard this patch.
src/BitPrepared/Bundle/D1b0Workspace/Controller/V1/UserController.php 1 patch
Braces   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -106,11 +106,11 @@
 
 block discarded – undo
106 106 
                 $user->updatetime = date('Y-m-d G:i:s');
107 107 
                 $id = R::store($user);
108 108 
                 $res = (object)["id" => $id];
109 
-            }catch (Exception $e) {
109 
+            } catch (Exception $e) {
110 110 
                 echo $e;
111 111 
             }
112 112
113 
-        }else {
113 
+        } else {
114 114
115 115 
         }
116 116
Please login to merge, or discard this patch.
src/BitPrepared/Bundle/D1b0Workspace/Controller/V1/WorkspaceController.php 2 patches
Braces   +10 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -216,7 +216,7 @@  discard block
 
 block discarded – undo
216 216 
                 $headers = [];
217 217 
                 $response = JsonResponse::create(["id"=>$wp_id], 200, $headers)->setSharedMaxAge(300);
218 218
219 
-            }else{
219 
+            } else{
220 220 
                 $headers = [];
221 221 
                 $response = JsonResponse::create(["message"=>"Key no more valid"], 498, $headers)->setSharedMaxAge(300);
222 222 
             }
 
@@ -339,8 +339,10 @@  discard block
 
 block discarded – undo
339 339 
                 $resource->totalpoint = 0;
340 340 
             $resource_id = R::store($resource);
341 341 
             $rem_id=getPositionInArray($delete_res,$resource_id);
342 
-            if($rem_id != 0)
343 
-                array_splice($delete_res,$rem_id,1); //RIMUOVO GLI ELEMENTI CHE HO MODIFICATO
342 
+            if($rem_id != 0) {
343 
+                            array_splice($delete_res,$rem_id,1);
344 
+            }
345 
+            //RIMUOVO GLI ELEMENTI CHE HO MODIFICATO
344 346 
         }
345 347
346 348 
         foreach($delete_res as $d){
 
@@ -358,8 +360,10 @@  discard block
 
 block discarded – undo
358 360 
                 $pb->part = $part_id;
359 361 
             $tmp = R::store($pb);
360 362 
             $rem_id=getPositionInArray($delete_badge,$tmp);
361 
-            if($rem_id != 0)
362 
-                array_splice($delete_badge,$rem_id,1); //RIMUOVO GLI ELEMENTI CHE HO MODIFICATO
363 
+            if($rem_id != 0) {
364 
+                            array_splice($delete_badge,$rem_id,1);
365 
+            }
366 
+            //RIMUOVO GLI ELEMENTI CHE HO MODIFICATO
363 367 
         }
364 368
365 369 
         foreach($delete_badge as $d){
 
@@ -380,7 +384,7 @@  discard block
 
 block discarded – undo
380 384 
                 if($b->completed === True){
381 385 
                     echo "CASO 1;<BR />";
382 386 
                     return $this->$POINT_FOR_USING_A_CONQUERED_BADGE;
383 
-                }else{
387 
+                } else{
384 388 
                     echo "CASO 2;<BR />";
385 389 
                     return $this->POINT_FOR_USING_A_BADGE;
386 390 
                 }
Please login to merge, or discard this patch.
Spacing   +70 added lines, -70 removed lines patch added patch discarded remove patch 
@@ -132,7 +132,7 @@  discard block
 
 block discarded – undo
132 132 
         return JsonResponse::create($res, 201, $headers)->setSharedMaxAge(300);
133 133 
     }
134 134
135 
-    public function putWorkspace($id,Request $request)
135 
+    public function putWorkspace($id, Request $request)
136 136 
     {
137 137 
         $user_id = $this->getSessionId();
138 138 
         $data = json_decode($request->getContent(), true);
 
@@ -146,7 +146,7 @@  discard block
 
 block discarded – undo
146 146 
         $unit = $data['team']['unit'];
147 147 
         $group = $data['team']['group'];
148 148
149 
-        $wp = R::load("workspace",$id);
149 
+        $wp = R::load("workspace", $id);
150 150 
             $ws->title = $title;
151 151 
             $ws->description = $description;
152 152 
             $ws->environment = $environment;
 
@@ -155,7 +155,7 @@  discard block
 
 block discarded – undo
155 155 
         $id = R::store($ws);
156 156
157 157 
         //save the team
158 
-        $team = R::findOne("team","workspace = ?",[$id]);
158 
+        $team = R::findOne("team", "workspace = ?", [$id]);
159 159 
             $team->patrol = $patrol;
160 160 
             $team->unit = $unit;
161 161 
             $team->group = $group;
 
@@ -202,11 +202,11 @@  discard block
 
 block discarded – undo
202 202 
         return JsonResponse::create($res, 201, $headers)->setSharedMaxAge(300);
203 203 
     }
204 204
205 
-    public function deleteWorkspace($id,Request $request)
205 
+    public function deleteWorkspace($id, Request $request)
206 206 
     {
207 207 
         $user_id = $this->getSessionId();
208 208
209 
-        $wp = R::load("workspace",$id);
209 
+        $wp = R::load("workspace", $id);
210 210 
         R::trash($ws); //TODO add soft delete!!!! we can not manage this one in production
211 211
212 212 
         //TODO soft delete all the part!!
 
@@ -253,16 +253,16 @@  discard block
 
 block discarded – undo
253 253
254 254 
         $key = $data['key'];
255 255
256 
-        $share = R::findOne("share","key = ?",[$key]);
256 
+        $share = R::findOne("share", "key = ?", [$key]);
257 257 
         echo $share->inserttime;
258 
-        if($share !== NULL){
258 
+        if ($share !== NULL) {
259 259 
             $date = new \DateTime();
260 260 
             date_sub($date, date_interval_create_from_date_string('15 minutes'));
261 261
262 
-            $wp_id=$share['workspace'];
262 
+            $wp_id = $share['workspace'];
263 263
264 264 
             $dateOld = new \DateTime($share->inserttime);
265 
-            if($dateOld > $date){
265 
+            if ($dateOld > $date) {
266 266 
                 $usw = R::dispense("userworkspace");
267 267 
                     $usw->user = $user_id;
268 268 
                     $usw->workspace = $wp_id;
 
@@ -271,7 +271,7 @@  discard block
 
 block discarded – undo
271 271 
                 $headers = [];
272 272 
                 $response = JsonResponse::create(["id"=>$wp_id], 200, $headers)->setSharedMaxAge(300);
273 273
274 
-            }else{
274 
+            }else {
275 275 
                 $headers = [];
276 276 
                 $response = JsonResponse::create(["message"=>"Key no more valid"], 498, $headers)->setSharedMaxAge(300);
277 277 
             }
 
@@ -293,7 +293,7 @@  discard block
 
 block discarded – undo
293 293 
             $part->totalpoint = 0;
294 294 
         $part_id = R::store($part);
295 295
296 
-        foreach($data['part'] as $r){ //TODO va fixato nelle api
296 
+        foreach ($data['part'] as $r) { //TODO va fixato nelle api
297 297 
             $resource = R::dispense("resource");
298 298 
                 $resource->part = $part_id;
299 299 
                 $resource->inserttime = date('Y-m-d H:i:s');
 
@@ -305,7 +305,7 @@  discard block
 
 block discarded – undo
305 305 
             $resource_id = R::store($resource);
306 306 
         }
307 307
308 
-        foreach($data['badges'] as $badge_id){ //TODO va fixato nelle api
308 
+        foreach ($data['badges'] as $badge_id) { //TODO va fixato nelle api
309 309 
             $pb = R::dispense("partbadge");
310 310 
                 $pb->badge = $badge_id;
311 311 
                 $pb->part = $part_id;
 
@@ -318,20 +318,20 @@  discard block
 
 block discarded – undo
318 318 
         return JsonResponse::create($res, 201, $headers)->setSharedMaxAge(300);
319 319 
     }
320 320
321 
-    public function getPart($id,$part_id, Request $request) {
321 
+    public function getPart($id, $part_id, Request $request) {
322 322 
         $user_id = $this->getSessionId();
323 323
324 324 
         $data = json_decode($request->getContent(), true);
325 325
326 
-        $part = R::findOne("part","id = ?",[$part_id]);
326 
+        $part = R::findOne("part", "id = ?", [$part_id]);
327 327
328 
-        $resource = R::findAll("resource","part = ?",[$part_id]);
328 
+        $resource = R::findAll("resource", "part = ?", [$part_id]);
329 329
330 
-        $partecipants = R::findAll("cero","part = ?",[$part_id]);
330 
+        $partecipants = R::findAll("cero", "part = ?", [$part_id]);
331 331
332 
-        $badges = R::findAll("partbadge","part = ? AND deleted = 0",[$part_id]);
332 
+        $badges = R::findAll("partbadge", "part = ? AND deleted = 0", [$part_id]);
333 333
334 
-        $res= [
334 
+        $res = [
335 335 
             "id"=>$part->id,
336 336 
             "creation"=>$part->inserttime,
337 337 
             "points"=>$part->points,
 
@@ -341,28 +341,28 @@  discard block
 
 block discarded – undo
341 341 
             "partecipants"=>[]
342 342 
         ];
343 343
344 
-        foreach($badges as $b){
345 
-            array_push($res['badges'],$b->id);
344 
+        foreach ($badges as $b) {
345 
+            array_push($res['badges'], $b->id);
346 346 
         }
347 
-        foreach($resource as $r){
348 
-            array_push($res['part'],[
347 
+        foreach ($resource as $r) {
348 
+            array_push($res['part'], [
349 349 
                 "type"=>$r->type,
350 350 
                 "hash"=>$r->hash,
351 351 
                 "ref"=>$r->ref
352 352 
             ]);
353 353 
         }
354 
-        foreach($partecipants as $p){
355 
-            array_push($res['partecipants'],$p->user);//TODO forse va usato l'id del c'ero e non l'id dell'utente
354 
+        foreach ($partecipants as $p) {
355 
+            array_push($res['partecipants'], $p->user); //TODO forse va usato l'id del c'ero e non l'id dell'utente
356 356 
         }
357 357
358 358 
         $headers = [];
359 359 
         return JsonResponse::create($res, 201, $headers)->setSharedMaxAge(300);
360 360 
     }
361 361
362 
-    private function getPositionInArray($array,$id){
363 
-        $count =0;
364 
-        foreach($array as $a){
365 
-            if($a->id === $id){
362 
+    private function getPositionInArray($array, $id) {
363 
+        $count = 0;
364 
+        foreach ($array as $a) {
365 
+            if ($a->id === $id) {
366 366 
                 return $count;
367 367 
             }
368 368 
             $count = $count + 1;
 
@@ -370,22 +370,22 @@  discard block
 
 block discarded – undo
370 370 
         return -1;
371 371 
     }
372 372
373 
-    public function putPart($id,$part_id, Request $request) {
373 
+    public function putPart($id, $part_id, Request $request) {
374 374 
         $user_id = $this->getSessionId();
375 375
376 376 
         $data = json_decode($request->getContent(), true);
377 377
378 
-        $part = R::load("part",$part_id);
378 
+        $part = R::load("part", $part_id);
379 379 
             $part->workspace = $id;
380 380 
             $part->user = $user_id;
381 381 
             $part->lastupdatetime = date('Y-m-d H:i:s');
382 382 
             $part->totalpoint = 0;
383 383 
         $part_id = R::store($part);
384 384
385 
-        $delete_res=R::findAll("resource","WHERE part = ?",[$part_id]);
385 
+        $delete_res = R::findAll("resource", "WHERE part = ?", [$part_id]);
386 386
387 
-        foreach($data['part'] as $r){ //TODO va fixato nelle api
388 
-            $resource = R::findOne("resource","WHERE hash = ? AND deleted = 0",[$r->hash]);//TODO BISOGNA FARE IL DIFF TRA QUELLE PRESENTI E QUELLE NON PRESENTI
387 
+        foreach ($data['part'] as $r) { //TODO va fixato nelle api
388 
+            $resource = R::findOne("resource", "WHERE hash = ? AND deleted = 0", [$r->hash]); //TODO BISOGNA FARE IL DIFF TRA QUELLE PRESENTI E QUELLE NON PRESENTI
389 389 
                 $resource->part = $part_id;
390 390 
                 $resource->updatetime = date('Y-m-d H:i:s');
391 391 
                 $resource->type = $r->type;
 
@@ -393,34 +393,34 @@  discard block
 
 block discarded – undo
393 393 
                 $resource->hash = $r->hash;
394 394 
                 $resource->totalpoint = 0;
395 395 
             $resource_id = R::store($resource);
396 
-            $rem_id=getPositionInArray($delete_res,$resource_id);
397 
-            if($rem_id != 0)
398 
-                array_splice($delete_res,$rem_id,1); //RIMUOVO GLI ELEMENTI CHE HO MODIFICATO
396 
+            $rem_id = getPositionInArray($delete_res, $resource_id);
397 
+            if ($rem_id != 0)
398 
+                array_splice($delete_res, $rem_id, 1); //RIMUOVO GLI ELEMENTI CHE HO MODIFICATO
399 399 
         }
400 400
401 
-        foreach($delete_res as $d){
401 
+        foreach ($delete_res as $d) {
402 402 
             //RIMUOVO REALMENTE DAL DB LE COSE CHE HO LASCIATO FUORI DALLA PUT (PRESENTI NEL DB MA NON NELLA NUOVA VERSIONE ODIO LE PUT)
403 
-            $resource = R::load("resource",[$d->id]);
404 
-            $resource->deleted=true;
403 
+            $resource = R::load("resource", [$d->id]);
404 
+            $resource->deleted = true;
405 405 
             R::store($resource);
406 406 
         }
407 407
408 
-        $delete_badge=R::findAll("partbadge","WHERE part = ? AND deleted = 0",[$part_id]);
408 
+        $delete_badge = R::findAll("partbadge", "WHERE part = ? AND deleted = 0", [$part_id]);
409 409
410 
-        foreach($data['badges'] as $badge_id){
411 
-            $pb = R::load("partbadge",$badge_id);
410 
+        foreach ($data['badges'] as $badge_id) {
411 
+            $pb = R::load("partbadge", $badge_id);
412 412 
                 $pb->badge = $badge_id;
413 413 
                 $pb->part = $part_id;
414 414 
             $tmp = R::store($pb);
415 
-            $rem_id=getPositionInArray($delete_badge,$tmp);
416 
-            if($rem_id != 0)
417 
-                array_splice($delete_badge,$rem_id,1); //RIMUOVO GLI ELEMENTI CHE HO MODIFICATO
415 
+            $rem_id = getPositionInArray($delete_badge, $tmp);
416 
+            if ($rem_id != 0)
417 
+                array_splice($delete_badge, $rem_id, 1); //RIMUOVO GLI ELEMENTI CHE HO MODIFICATO
418 418 
         }
419 419
420 
-        foreach($delete_badge as $d){
420 
+        foreach ($delete_badge as $d) {
421 421 
             //RIMUOVO REALMENTE DAL DB LE COSE CHE HO LASCIATO FUORI DALLA PUT (PRESENTI NEL DB MA NON NELLA NUOVA VERSIONE ODIO LE PUT)
422 
-            $badge = R::load("partbadge",[$d->id]);//FORSE RILOADARLI NON È NECESSARIO
423 
-            $badge->deleted=true;
422 
+            $badge = R::load("partbadge", [$d->id]); //FORSE RILOADARLI NON È NECESSARIO
423 
+            $badge->deleted = true;
424 424 
             R::store($badge);
425 425 
         }
426 426 
 
@@ -429,17 +429,17 @@  discard block
 
 block discarded – undo
429 429 
         return JsonResponse::create($res, 201, $headers)->setSharedMaxAge(300);
430 430 
     }
431 431
432 
-    public function deletePart($id,$part_id, Request $request) {
432 
+    public function deletePart($id, $part_id, Request $request) {
433 433 
         $user_id = $this->getSessionId();
434 
-        $part = R::load("part",$part_id);
434 
+        $part = R::load("part", $part_id);
435 435 
         R::trash($part);
436 436
437 437 
         //TODO soft delete all the part badge!!
438 438
439 
-        $delete_badge=R::findAll("partbadge","WHERE part = ?",[$part_id]);
440 
-        foreach($delete_badge as $d){
441 
-            $badge = R::load("partbadge",[$d->id]);//FORSE RILOADARLI NON È NECESSARIO BASTA FARE $d->deleted=true; e store($d)
442 
-                $badge->deleted=true;
439 
+        $delete_badge = R::findAll("partbadge", "WHERE part = ?", [$part_id]);
440 
+        foreach ($delete_badge as $d) {
441 
+            $badge = R::load("partbadge", [$d->id]); //FORSE RILOADARLI NON È NECESSARIO BASTA FARE $d->deleted=true; e store($d)
442 
+                $badge->deleted = true;
443 443 
             R::store($badge);
444 444 
         }
445 445 
 
@@ -449,13 +449,13 @@  discard block
 
 block discarded – undo
449 449 
         $response->setSharedMaxAge(300);
450 450 
     }
451 451
452 
-    private function getPoint($badge_id,$badges){
453 
-        foreach($badges as $b){
454 
-            if($b->id === $badge_id){
455 
-                if($b->completed === True){
452 
+    private function getPoint($badge_id, $badges) {
453 
+        foreach ($badges as $b) {
454 
+            if ($b->id === $badge_id) {
455 
+                if ($b->completed === True) {
456 456 
                     echo "CASO 1;<BR />";
457 457 
                     return $this->$POINT_FOR_USING_A_CONQUERED_BADGE;
458 
-                }else{
458 
+                }else {
459 459 
                     echo "CASO 2;<BR />";
460 460 
                     return $this->POINT_FOR_USING_A_BADGE;
461 461 
                 }
 
@@ -464,16 +464,16 @@  discard block
 
 block discarded – undo
464 464 
         echo "CASO 3;<BR />";
465 465 
         return $this->POINT_DEFAULT;
466 466 
     }
467 
-    public function checkin($id,$part_id, Request $request) {
467 
+    public function checkin($id, $part_id, Request $request) {
468 468 
         $user_id = $this->getSessionId();
469 469
470 
-        $badges = R::findAll("partbadge","part = ? AND deleted = 0",[$part_id]);
471 
-        $u_badges = R::findAll("userbadge","user = ? AND deleted = 0",[$user_id]);
470 
+        $badges = R::findAll("partbadge", "part = ? AND deleted = 0", [$part_id]);
471 
+        $u_badges = R::findAll("userbadge", "user = ? AND deleted = 0", [$user_id]);
472 472
473 473 
         $point_earned = 0;
474 
-        foreach($badges as $b){ //SE CI SONO DEI BADGE
475 
-            $point = $this->getPoint($b->id,$u_badges);
476 
-            if($point != $this->POINT_DEFAULT){ //SE SEI IN CAMMINO PER QUEI BADGE O SE LI POSSIEDI GIÀ
474 
+        foreach ($badges as $b) { //SE CI SONO DEI BADGE
475 
+            $point = $this->getPoint($b->id, $u_badges);
476 
+            if ($point != $this->POINT_DEFAULT) { //SE SEI IN CAMMINO PER QUEI BADGE O SE LI POSSIEDI GIÀ
477 477 
                 echo "PUNTI:".$point;
478 478 
                 $point_earned = $point_earned + $point;
479 479 
                 $pb = R::dispense("cero");
 
@@ -484,7 +484,7 @@  discard block
 
 block discarded – undo
484 484 
                     $pb->points = $point;
485 485 
                 $tmp = R::store($pb);
486 486
487 
-                if($point === $this->POINT_FOR_USING_A_BADGE){ //SE SEI IN CAMMINO MA NON LI HAI ANCORA RAGGIUNTI
487 
+                if ($point === $this->POINT_FOR_USING_A_BADGE) { //SE SEI IN CAMMINO MA NON LI HAI ANCORA RAGGIUNTI
488 488 
                     $ubc = R::dispense("userbadgeclove");
489 489 
                         $ubc->user = $user_id;
490 490 
                         $ubc->badge = $b->id;
 
@@ -495,7 +495,7 @@  discard block
 
 block discarded – undo
495 495 
             }
496 496 
         }
497 497
498 
-        if($point_earned <= 0){ //SE NON CI SONO BADGE O SE TU NON SEI IN CAMMINO PER NESSUNO DI LORO
498 
+        if ($point_earned <= 0) { //SE NON CI SONO BADGE O SE TU NON SEI IN CAMMINO PER NESSUNO DI LORO
499 499 
             $pb = R::dispense("cero");
500 500 
                 $pb->user = $user_id;
501 501 
                 $pb->part = $part_id;
 
@@ -509,13 +509,13 @@  discard block
 
 block discarded – undo
509 509
510 510 
     }
511 511
512 
-    public function deleteCheckin($id,$part_id, Request $request) {
512 
+    public function deleteCheckin($id, $part_id, Request $request) {
513 513 
         $user_id = $this->getSessionId();
514 514
515 
-        $u_badges = R::findAll("userbadge","user = ? AND part = ?",[$user_id,$part_id]);
515 
+        $u_badges = R::findAll("userbadge", "user = ? AND part = ?", [$user_id, $part_id]);
516 516 
         R::trashAll($u_badges);
517 517
518 
-        $cero = R::findAll("cero","user = ? AND part = ?",[$user_id,$part_id]);
518 
+        $cero = R::findAll("cero", "user = ? AND part = ?", [$user_id, $part_id]);
519 519 
         R::trashAll($cero);
520 520
521 521 
         $response = new Response();
Please login to merge, or discard this patch.
src/BitPrepared/Bundle/D1b0Workspace/Controller/V1/BadgeController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -28,11 +28,11 @@
 
 block discarded – undo
28 28 
         $filter = $request->get('filterBy');
29 29 
         echo $filter;
30 30
31 
-        $badge = R::findAll("badge","type = ? AND enable = 1",[$filter]);
31 
+        $badge = R::findAll("badge", "type = ? AND enable = 1", [$filter]);
32 32
33 33 
         $res = [];
34 
-        foreach($badge as $b){
35 
-            array_push($res,[
34 
+        foreach ($badge as $b) {
35 
+            array_push($res, [
36 36 
                 "id"=>$b->id,
37 37 
                 "name"=>$b->name,
38 38 
                 "descritpion"=>$b->description,
Please login to merge, or discard this patch.