WorkspacesTest::testGetWorkspaceList() - Code Metrics - Inspection of "breaking the second test! need waffle and help" - BitPrepared/d1b0 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d17431...91c957 )

by Danger

created 2016-10-04 08:42 UTC

WorkspacesTest::testGetWorkspaceList() B

↳ Parent: WorkspacesTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	26
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	26
rs	8.8571
cc	1
eloc	3
nc	1
nop	0

<?php

namespace Tests;

use Silex\WebTestCase;
use JsonSchema\Validator;

class WorkspacesTest extends WebTestCase
{
    use AbstractAppTest;

    public function testGetWorkspaceList(){
        $schema = __DIR__.'/../../../../api/schemas/workspaceList.json';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        //$client = $this->createClient();

        //$client = $this->logIn($client);


        //$crawler = $client->request('GET', '/api/v1/workspace/');

        /*$response = $client->getResponse();

        print_r("funziona:");
        print_r($response);
        $data = $client->getResponse()->getContent();
        print_r($data);
        $validator = $this->askValidation($data,$schema);

        if ($validator->isValid()) {
            echo "The supplied JSON validates against the schema.\n";
            $this->assertTrue(true);
        } else {
            echo "JSON does not validate. Violations:\n";
            foreach ($validator->getErrors() as $error) {
                echo "[{$error['property']}] {$error['message']}\n";
            }
            $this->assertTrue(false);
        }*/
        $this->assertTrue(true);
    }
}


1			<?php
2
3			namespace Tests;
4
5			use Silex\WebTestCase;
6			use JsonSchema\Validator;
7
8			class WorkspacesTest extends WebTestCase
9			{
10			use AbstractAppTest;
11
12			public function testGetWorkspaceList(){
13			$schema = __DIR__.'/../../../../api/schemas/workspaceList.json';
			0 ignored issues – show Unused Code introduced 2016-10-04 08:45 UTC by Report Bug Copy Issue Report `$schema` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
14
15			//$client = $this->createClient();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-10-04 08:45 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
16			//$client = $this->logIn($client);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-10-04 08:45 UTC by Report Bug Copy Issue Report `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
17
18			//$crawler = $client->request('GET', '/api/v1/workspace/');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-10-04 08:45 UTC by Report Bug Copy Issue Report `65%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
19			/*$response = $client->getResponse();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-10-04 08:45 UTC by Report Bug Copy Issue Report `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
20			print_r("funziona:");
21			print_r($response);
22			$data = $client->getResponse()->getContent();
23			print_r($data);
24			$validator = $this->askValidation($data,$schema);
25
26			if ($validator->isValid()) {
27			echo "The supplied JSON validates against the schema.\n";
28			$this->assertTrue(true);
29			} else {
30			echo "JSON does not validate. Violations:\n";
31			foreach ($validator->getErrors() as $error) {
32			echo "[{$error['property']}] {$error['message']}\n";
33			}
34			$this->assertTrue(false);
35			}*/
36			$this->assertTrue(true);
37			}
38			}
39

BitPrepared / d1b0

GitHub Access Token became invalid

Push — master ( d17431...91c957 )

WorkspacesTest::testGetWorkspaceList() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like