WorkspaceController::createWorkspace() - Code Metrics - Inspection of "Added share and get workspace fixed README" - BitPrepared/d1b0 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8f9c3d...610f46 )

unknown

created 2016-09-26 15:17 UTC

WorkspaceController::createWorkspace() A

↳ Parent: WorkspaceController

Complexity

Conditions	2
Paths	2

Size

Total Lines	62
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
dl	0
loc	62
c	2
b	0
f	0
rs	9.4743
cc	2
eloc	45
nc	2
nop	1

How to fix Long Method

<?php

namespace BitPrepared\Bundle\D1b0Workspace\Controller\V1;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\JsonResponse;
use Silex\Application;
use Silex\Api\ControllerProviderInterface;
use Monolog\Logger;
use RedBeanPHP\Facade as R;

class WorkspaceController implements ControllerProviderInterface
{

    private $app;

    public function connect(Application $app)
    {
        $this->app = $app;
        $factory = $app['controllers_factory'];
        # il mount point e' precedente e non serve prima
        $this->app['db'];
        R::fancyDebug( TRUE );
        $factory->get('/', array($this, 'getWorkspaceList'));
        $factory->post('/', array($this, 'createWorkspace'));
        $factory->get('/{id}', array($this, 'getWorkspace'));
        $factory->get('/{id}/share', array($this, 'share'));
        $factory->post('/{id}/part', array($this, 'postPart'));
        return $factory;
    }
    public function getSessionId(){
        $user_id=$this->app['session']->get('user')['id'];
        return $user_id;
    }
    public function getWorkspaceList(Request $request)
    {
        $user_id=$this->getSessionId();
        $workspaces =  R::getAll("SELECT ws.id,
                                          ws.title,
                                          ws.description,
                                          ws.environment,
                                          ws.completed
                                          FROM userworkspace AS uws
                                          LEFT JOIN workspace AS ws
                                          ON uws.workspace = ws.id
                                          WHERE uws.user = ?",[$user_id]);
        $list=[];
        foreach($workspaces as $ws){
            array_push($list,[
                "id"=>$ws['id'],
                "title"=>$ws['title'],
                "description"=>$ws['description'],
                "environment"=>$ws['environment'],
                "point"=>0,//TODO fare una view con i point già calcolati per il ws
                "completed"=>$ws['completed'],
            ]);
        }
        $headers = [];
        return JsonResponse::create($list, 200, $headers)->setSharedMaxAge(300);

    }
    public function createWorkspace(Request $request)
    {
        $user_id=$this->getSessionId();
        $counter=0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $data = json_decode($request->getContent(), true);
        //TODO validate json_decode
        $title=$data['title'];
        $description=$data['description'];
        $environment=$data['environment'];

        $patrol = $data['team']['patrol'];
        $unit = $data['team']['unit'];
        $group = $data['team']['group'];

        //save the workspace get id
        $ws = R::dispense("workspace");
            $ws->title=$title;
            $ws->description=$description;
            $ws->environment=$environment;
            $ws->completed=false;
            $ws->inserttime=date('Y-m-d H:i:s');
            $ws->lastupdatetime=date('Y-m-d H:i:s');
        $id = R::store($ws);

        //save the team
        $team = R::dispense("team");
            $team->workspace=$id;
            $team->patrol=$patrol;
            $team->unit=$unit;
            $team->group=$group;
        $team_id = R::store($team);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        //create a phantom part to add badge
        $part = R::dispense("part");
            $part->workspace=$id;
            $part->user=$user_id;
            $part->inserttime=date('Y-m-d H:i:s');
            $part->lastupdatetime=date('Y-m-d H:i:s');
            $part->totalpoint=0;
        $part_id = R::store($part);

        //add the badge to the project
        foreach($data['badges'] as $badge_id){
            //TODO insert those badge as first hidden post
            $pb = R::dispense("partbadge");
                $pb->badge=$badge_id;
                $pb->part=$part_id;
                $pb->inserttime=date('Y-m-d H:i:s');
            $tmp = R::store($pb);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }

        //add the workspace created to the user as owner
        $usw = R::dispense("userworkspace");
            $usw->user=$user_id;
            $usw->workspace=$id;
            $usw->inserttime=date('Y-m-d H:i:s');
        R::store($usw);

        $res = ["id" => $id];
        $headers = [];
        return JsonResponse::create($res, 201, $headers)->setSharedMaxAge(300);
    }

    public function getWorkspace($id,Request $request){
        $user_id=$this->getSessionId();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        //TODO controllare che l'utente abbia diritto a vedere questo workspace

        $workspace =  R::findOne("workspace","id = ?",[$id]);
        $part = R::findAll("part","workspace = ?",[$id]);

        $badges = R::findAll("workspacebadge","workspace = ?",[$id]);

        $l_part=[];
        foreach($part as $p){
            array_push($l_part,intval($p['id']));
        }
        $l_badges=[];
        foreach($badges as $b){
            array_push($l_badges,intval($b['badge']));
        }

        $res = [
            'id'=> $workspace['id'],
            'title'=> $workspace['title'],
            'description'=> $workspace['description'],
            'environment'=> $workspace['environment'],
            'environment'=> $workspace['environment'],
            'completed'=> $workspace['completed'],
            'parts'=>$l_part,
            'badges'=>$l_badges
        ];
        $headers = [];
        return JsonResponse::create($res, 201, $headers)->setSharedMaxAge(300);
    }

    public function share($id,Request $request){
        $generatedKey = hash("sha256",(mt_rand(10000,99999).time().$id));
        //TODO verificare documentazione realtiva sulla reale entropia generata da questo sistema
        $user_id=$this->getSessionId();
        $share = R::dispense("share");
            $share->user=$user_id;
            $share->workspace=$id;
            $share->key=$generatedKey;
            $share->inserttime=date('Y-m-d H:i:s');
        $share_id = R::store($share);

        $date = new \DateTime();
        date_add($date, date_interval_create_from_date_string('15 minutes'));

        $res = [
            "id"=>$share_id,
            "key"=>$generatedKey,
            "expire"=>$date->format('Y-m-d H:i:s')
        ];

        $headers = [];
        return JsonResponse::create($res, 200, $headers)->setSharedMaxAge(300);
    }

    public function postPart($id,Request $request){
        $user_id=$this->getSessionId();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $res = [];
        $headers = [];
        return JsonResponse::create($res, 200, $headers)->setSharedMaxAge(300);
    }
}


1			<?php
2
3			namespace BitPrepared\Bundle\D1b0Workspace\Controller\V1;
4
5			use Symfony\Component\HttpFoundation\Request;
6			use Symfony\Component\HttpFoundation\Response;
7			use Symfony\Component\HttpFoundation\JsonResponse;
8			use Silex\Application;
9			use Silex\Api\ControllerProviderInterface;
10			use Monolog\Logger;
11			use RedBeanPHP\Facade as R;
12
13			class WorkspaceController implements ControllerProviderInterface
14			{
15
16			private $app;
17
18			public function connect(Application $app)
19			{
20			$this->app = $app;
21			$factory = $app['controllers_factory'];
22			# il mount point e' precedente e non serve prima
23			$this->app['db'];
24			R::fancyDebug( TRUE );
25			$factory->get('/', array($this, 'getWorkspaceList'));
26			$factory->post('/', array($this, 'createWorkspace'));
27			$factory->get('/{id}', array($this, 'getWorkspace'));
28			$factory->get('/{id}/share', array($this, 'share'));
29			$factory->post('/{id}/part', array($this, 'postPart'));
30			return $factory;
31			}
32			public function getSessionId(){
33			$user_id=$this->app['session']->get('user')['id'];
34			return $user_id;
35			}
36			public function getWorkspaceList(Request $request)
37			{
38			$user_id=$this->getSessionId();
39			$workspaces = R::getAll("SELECT ws.id,
40			ws.title,
41			ws.description,
42			ws.environment,
43			ws.completed
44			FROM userworkspace AS uws
45			LEFT JOIN workspace AS ws
46			ON uws.workspace = ws.id
47			WHERE uws.user = ?",[$user_id]);
48			$list=[];
49			foreach($workspaces as $ws){
50			array_push($list,[
51			"id"=>$ws['id'],
52			"title"=>$ws['title'],
53			"description"=>$ws['description'],
54			"environment"=>$ws['environment'],
55			"point"=>0,//TODO fare una view con i point già calcolati per il ws
56			"completed"=>$ws['completed'],
57			]);
58			}
59			$headers = [];
60			return JsonResponse::create($list, 200, $headers)->setSharedMaxAge(300);
61
62			}
63			public function createWorkspace(Request $request)
64			{
65			$user_id=$this->getSessionId();
66			$counter=0;
			0 ignored issues – show Unused Code introduced 2016-09-25 22:09 UTC by Report Bug Copy Issue Report `$counter` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
67			$data = json_decode($request->getContent(), true);
68			//TODO validate json_decode
69			$title=$data['title'];
70			$description=$data['description'];
71			$environment=$data['environment'];
72
73			$patrol = $data['team']['patrol'];
74			$unit = $data['team']['unit'];
75			$group = $data['team']['group'];
76
77			//save the workspace get id
78			$ws = R::dispense("workspace");
79			$ws->title=$title;
80			$ws->description=$description;
81			$ws->environment=$environment;
82			$ws->completed=false;
83			$ws->inserttime=date('Y-m-d H:i:s');
84			$ws->lastupdatetime=date('Y-m-d H:i:s');
85			$id = R::store($ws);
86
87			//save the team
88			$team = R::dispense("team");
89			$team->workspace=$id;
90			$team->patrol=$patrol;
91			$team->unit=$unit;
92			$team->group=$group;
93			$team_id = R::store($team);
			0 ignored issues – show Unused Code introduced 2016-09-25 22:09 UTC by Report Bug Copy Issue Report `$team_id` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
94
95			//create a phantom part to add badge
96			$part = R::dispense("part");
97			$part->workspace=$id;
98			$part->user=$user_id;
99			$part->inserttime=date('Y-m-d H:i:s');
100			$part->lastupdatetime=date('Y-m-d H:i:s');
101			$part->totalpoint=0;
102			$part_id = R::store($part);
103
104			//add the badge to the project
105			foreach($data['badges'] as $badge_id){
106			//TODO insert those badge as first hidden post
107			$pb = R::dispense("partbadge");
108			$pb->badge=$badge_id;
109			$pb->part=$part_id;
110			$pb->inserttime=date('Y-m-d H:i:s');
111			$tmp = R::store($pb);
			0 ignored issues – show Unused Code introduced 2016-09-25 22:09 UTC by Report Bug Copy Issue Report `$tmp` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
112			}
113
114			//add the workspace created to the user as owner
115			$usw = R::dispense("userworkspace");
116			$usw->user=$user_id;
117			$usw->workspace=$id;
118			$usw->inserttime=date('Y-m-d H:i:s');
119			R::store($usw);
120
121			$res = ["id" => $id];
122			$headers = [];
123			return JsonResponse::create($res, 201, $headers)->setSharedMaxAge(300);
124			}
125
126			public function getWorkspace($id,Request $request){
127			$user_id=$this->getSessionId();
			0 ignored issues – show Unused Code introduced 2016-09-26 15:20 UTC by Report Bug Copy Issue Report `$user_id` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
128			//TODO controllare che l'utente abbia diritto a vedere questo workspace
129
130			$workspace = R::findOne("workspace","id = ?",[$id]);
131			$part = R::findAll("part","workspace = ?",[$id]);
132
133			$badges = R::findAll("workspacebadge","workspace = ?",[$id]);
134
135			$l_part=[];
136			foreach($part as $p){
137			array_push($l_part,intval($p['id']));
138			}
139			$l_badges=[];
140			foreach($badges as $b){
141			array_push($l_badges,intval($b['badge']));
142			}
143
144			$res = [
145			'id'=> $workspace['id'],
146			'title'=> $workspace['title'],
147			'description'=> $workspace['description'],
148			'environment'=> $workspace['environment'],
149			'environment'=> $workspace['environment'],
150			'completed'=> $workspace['completed'],
151			'parts'=>$l_part,
152			'badges'=>$l_badges
153			];
154			$headers = [];
155			return JsonResponse::create($res, 201, $headers)->setSharedMaxAge(300);
156			}
157
158			public function share($id,Request $request){
159			$generatedKey = hash("sha256",(mt_rand(10000,99999).time().$id));
160			//TODO verificare documentazione realtiva sulla reale entropia generata da questo sistema
161			$user_id=$this->getSessionId();
162			$share = R::dispense("share");
163			$share->user=$user_id;
164			$share->workspace=$id;
165			$share->key=$generatedKey;
166			$share->inserttime=date('Y-m-d H:i:s');
167			$share_id = R::store($share);
168
169			$date = new \DateTime();
170			date_add($date, date_interval_create_from_date_string('15 minutes'));
171
172			$res = [
173			"id"=>$share_id,
174			"key"=>$generatedKey,
175			"expire"=>$date->format('Y-m-d H:i:s')
176			];
177
178			$headers = [];
179			return JsonResponse::create($res, 200, $headers)->setSharedMaxAge(300);
180			}
181
182			public function postPart($id,Request $request){
183			$user_id=$this->getSessionId();
			0 ignored issues – show Unused Code introduced 2016-09-26 15:20 UTC by Report Bug Copy Issue Report `$user_id` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
184
185			$res = [];
186			$headers = [];
187			return JsonResponse::create($res, 200, $headers)->setSharedMaxAge(300);
188			}
189			}
190

BitPrepared / d1b0

GitHub Access Token became invalid

Push — master ( 8f9c3d...610f46 )

WorkspaceController::createWorkspace() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like