WishlistToken::generate() - Code Metrics - Inspection of "Cookies saving token instead of id" - BitBagCommerce/SyliusWishlistPlugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

unknown

created 2018-05-09 12:13 UTC

WishlistToken::generate() A

↳ Parent: WishlistToken

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	2
nop	1

<?php

declare(strict_types=1);

namespace BitBag\SyliusWishlistPlugin\Entity;

class WishlistToken implements WishlistTokenInterface
{
    protected $value;

    public function __construct(?string $value = null)
    {
        if ($value === null) {
            $this->value = $this->generate(self::VALUE_LENGTH);
        } else {
            $this->setValue($value);
        }
    }

    public function getValue(): string
    {
        return $this->value;
    }

    public function setValue(string $value): void
    {
        $this->value = $value;
    }

    public function __toString()
    {
        return $this->getValue();
    }

    private function generate($length): string
    {
        $token = '';
        $codeAlphabet = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ';
        $codeAlphabet .= 'abcdefghijklmnopqrstuvwxyz';
        $codeAlphabet .= '0123456789';
        $max = strlen($codeAlphabet); // edited

        for ($i = 0; $i < $length; ++$i) {
            $token .= $codeAlphabet[random_int(0, $max - 1)];
        }

        return $token;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace BitBag\SyliusWishlistPlugin\Entity;
6
7			class WishlistToken implements WishlistTokenInterface
8			{
9			protected $value;
10
11			public function __construct(?string $value = null)
12			{
13			if ($value === null) {
14			$this->value = $this->generate(self::VALUE_LENGTH);
15			} else {
16			$this->setValue($value);
17			}
18			}
19
20			public function getValue(): string
21			{
22			return $this->value;
23			}
24
25			public function setValue(string $value): void
26			{
27			$this->value = $value;
28			}
29
30			public function __toString()
31			{
32			return $this->getValue();
33			}
34
35			private function generate($length): string
36			{
37			$token = '';
38			$codeAlphabet = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ';
39			$codeAlphabet .= 'abcdefghijklmnopqrstuvwxyz';
40			$codeAlphabet .= '0123456789';
41			$max = strlen($codeAlphabet); // edited
42
43			for ($i = 0; $i < $length; ++$i) {
44			$token .= $codeAlphabet[random_int(0, $max - 1)];
45			}
46
47			return $token;
48			}
49			}
50

BitBagCommerce / SyliusWishlistPlugin

Pull Request — master (#1)

WishlistToken::generate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like