BitBag\SyliusWishlistPlugin\Resolver\GenerateDataUriForImageResolver

Complexity

Total Complexity

2

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	resolve()	0	8	1

<?php

/*
 * This file was created by developers working at BitBag
 * Do you need more information about us and what we do? Visit our https://bitbag.io website!
 * We are hiring developers from all over the world. Join us and start your new, exciting adventure and become part of us: https://bitbag.io/career
*/

declare(strict_types=1);

namespace BitBag\SyliusWishlistPlugin\Resolver;

use Liip\ImagineBundle\Service\FilterService;
use Sylius\Component\Core\Model\ProductImageInterface;
use Symfony\Component\Asset\PackageInterface;

final class GenerateDataUriForImageResolver implements GenerateDataUriForImageResolverInterface
{
    private PackageInterface $package;

    private FilterService $filterService;

    private string $imageFilterName;

    public function __construct(
        PackageInterface $package,
        FilterService $filterService,
        string $imageFilterName
    ) {
        $this->package = $package;
        $this->filterService = $filterService;
        $this->imageFilterName = $imageFilterName;
    }

    public function resolve(ProductImageInterface $image): string
    {
        $pathToReadFile = $this->package->getUrl($image->getPath());

It seems like $image->getPath() can also be of type null; however, parameter $path of Symfony\Component\Asset\PackageInterface::getUrl() does only seem to accept string, maybe add an additional type check?

        $targetUrl = $this->filterService->getUrlOfFilteredImage($pathToReadFile, $this->imageFilterName);
        $data = file_get_contents($targetUrl);
        $type = pathinfo($image->getPath(), \PATHINFO_EXTENSION);

It seems like $image->getPath() can also be of type null; however, parameter $path of pathinfo() does only seem to accept string, maybe add an additional type check?

        return 'data:image/' . $type . ';base64,' . base64_encode($data);
    }
}